Skip to content

Recover the unit_size maintainability floor after formatting development #1878

Open

Description

@SudoThijn

The maintainability floor fails on #1830: unit_size 4.21 -> 4.19 against the merge base 3cfe33f.

Development's head held 78 frontend files that Prettier never formatted. #1830 formats them (341d50f). That expands long expressions over several lines, which pushes 24 JS units over a SIG unit-size band (15 / 30 / 60 NLOC). Examples, base NLOC → head NLOC:

  • src/store/modules/import.js readWithParser 8 → 23, resolveRowTypes 25 → 32
  • src/utils/versionCompare.js compareStates 14 → 23
  • src/components/VersionHistoryPanel.vue onCompare 15 → 24
  • src/store/modules/attachment.js preview 21 → 32
  • src/health/engine.js analyseRow 29 → 36
  • src/store/modules/secret.js createSecret 30 → 33

Any formatting fix of development lowers the rating this way: the floor was measured on code that broke the format check.

Fix: split enough of these units (or other large JS units) to bring unit_size back to at least 4.21, measured with floor_check.py compare . --base-ref <development> from hydra-gates scripts/lib (lizard 1.24.3).

Activity

  1. github-actions commented on Nov 17, 2026

    @github-actions
    Contributor

    Thank you for opening this issue! It has been assigned to @rubenvdlinde for review.

    What happens next:

    1. A maintainer will review this issue and determine the appropriate action
    2. If accepted, it may be converted into an OpenSpec change for structured development
    3. You will be notified of any status changes

    Triage labels:

    • triage:accept-feature — accepted as a new feature
    • triage:accept-bugfix — accepted as a bug fix
    • triage:needs-info — more information needed
    • triage:wontfix — will not be addressed
    • triage:duplicate — duplicate of another issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

javascriptPull requests that update javascript codetriageAwaiting triage

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions