You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
gate-41 (html-lang) has gate-38's defect verbatim: a PHP COMMENT mentioning <html> makes a mount point a page root #266
templates/fragment.php — a mount point that emits no<html> at all:
<?php// This mount point is substituted into core's page. Core emitted the// <html> element for it, with its lang attribute, long before this file.?>
<div id="app-settings"></div>
txt is the raw file. This is the gate-64 defect and the one gate-38 just shipped a fix for: a checker that greps a string literal misses every constant and matches every comment, failing both ways at once. It also fails the other way — a commented-out <html lang="en"> would satisfy the gate for a template that really does emit an unlangged <html>.
The fix already exists
scripts/lib/php_template_scope.py (landed in #247) classifies emitted markup with PHP regions and HTML comments removed, and is tested for exactly these two comment shapes. gate-41 should run its search over php_template_scope.emitted_markup(src) instead of the raw text.
gate-41 reports PASS across the fleet because no app template emits a document — measured: all 30 are fragments. The false positive only fires on a template whose prose mentions the tag. So the gate is quiet today for a reason unrelated to it being correct, and the first app that writes such a comment gets an unclosable finding.
Fixed and merged to main in #269 (cdfbd7a). Live fleet-wide now. All three loose ends closed, exactly as scoped.
1. The comment defect. The search runs over php_template_scope.emitted_markup(src) — the helper #247 landed — instead of the raw text, so neither a PHP comment naming the tag nor a commented-out <html lang="en"> can decide it. Your reproduction is a unit test verbatim, with all four arms:
a mount point whose comment mentions <html> → 0
a template that really emits <html> with no lang → 1 (the positive control; without it "no findings" proves nothing here, since the gate is quiet fleet-wide for reasons unrelated to being correct)
<html lang="en"> → 0
<!-- <html lang="en"> --> above a real unlangged <html> → 1 (the more dangerous direction you named)
[^>]* went too — a > inside an attribute value is not the end of the tag (#198, #236) — and every emitted <html> is now checked, not just the first.
2. The third scope definition. Gone. gate-41 reads _a11y_markup_files filtered to .php, so a generated phpmetrics/ or vendor/ template is no longer audited here and nowhere else. There are two definitions in the a11y family now, not three, and one of them is shared — no new dialect was introduced, per your "converge, don't add a third".
3. The wiring guard. The inline python3 - <<'PYHL' >> log 2>/dev/null is gone. A missing or crashing helper now reports SKIPPED (wiring) naming how many templates went uninspected, never PASS (#147 / #249). Both failure shapes — helper absent and helper crashing — are asserted in test_gate_a11y_helper_wiring.sh, alongside a positive control proving the gate FAILs on a template that really does emit an unlangged document.
Measured post-merge on nldesign, larpingapp, openconnector, procest and openbuild: [gate-41] html-lang: PASS in both arms — as you predicted, because no app emits a document. The difference is that it is now PASS for the right reason, and a repo that writes such a comment no longer gets an unclosable finding.
Activity
fix(gates): nine checkers matched prose, not code (#191, #196, #220, #…
rubenvdlinde commentedon Aug 8, 2026
Fixed and merged to
mainin #269 (cdfbd7a). Live fleet-wide now. All three loose ends closed, exactly as scoped.1. The comment defect. The search runs over
php_template_scope.emitted_markup(src)— the helper #247 landed — instead of the raw text, so neither a PHP comment naming the tag nor a commented-out<html lang="en">can decide it. Your reproduction is a unit test verbatim, with all four arms:<html>→ 0<html>with nolang→ 1 (the positive control; without it "no findings" proves nothing here, since the gate is quiet fleet-wide for reasons unrelated to being correct)<html lang="en">→ 0<!-- <html lang="en"> -->above a real unlangged<html>→ 1 (the more dangerous direction you named)[^>]*went too — a>inside an attribute value is not the end of the tag (#198, #236) — and every emitted<html>is now checked, not just the first.2. The third scope definition. Gone. gate-41 reads
_a11y_markup_filesfiltered to.php, so a generatedphpmetrics/orvendor/template is no longer audited here and nowhere else. There are two definitions in the a11y family now, not three, and one of them is shared — no new dialect was introduced, per your "converge, don't add a third".3. The wiring guard. The inline
python3 - <<'PYHL' >> log 2>/dev/nullis gone. A missing or crashing helper now reportsSKIPPED (wiring)naming how many templates went uninspected, never PASS (#147 / #249). Both failure shapes — helper absent and helper crashing — are asserted intest_gate_a11y_helper_wiring.sh, alongside a positive control proving the gate FAILs on a template that really does emit an unlangged document.Measured post-merge on nldesign, larpingapp, openconnector, procest and openbuild:
[gate-41] html-lang: PASSin both arms — as you predicted, because no app emits a document. The difference is that it is now PASS for the right reason, and a repo that writes such a comment no longer gets an unclosable finding.fix(gates 35,40,42,44): four a11y gates excused themselves from a rep…