Skip to content

gate-38 skip-link: admin-settings surfaces are still in scope after #201, and they cannot own a page shell #227

Closed

Description

@rubenvdlinde

Follow-up to #201, which fixed the App.vue / CnAppRoot case. Two shapes remain in scope and both are false positives for the same structural reason.

Measured on portaliq origin/development @ 79bbf68, full-tree, hydra-gates @ 756fe89:

[gate-38] skip-link: FAIL — 2 root component(s) without skip-link / <NcContent>
src/views/AdminRoot.vue: no <NcContent> shell, no skip-link affordance
templates/settings/admin.php: no <NcContent> shell, no skip-link affordance

The scope heuristic (run-hydra-gates.sh:3130-3132) is explicit:

a file is in scope if it's a top-level Vue mount root (App.vue / **/AdminRoot.vue / **/Root.vue) OR a settings admin template (templates/settings/*.php)

Neither file is a page

templates/settings/admin.php is not a root component at all. In full, minus comments and provideInitialState calls, it is:

Util::addScript($appId, $appId . "-settings");
?>
<div id="portaliq-settings"></div>

A mount div. There is no page for a skip link to skip into.

src/views/AdminRoot.vue is a fragment that Nextcloud's Settings framework injects into its own settings page. The surrounding chrome — <NcContent>, the settings navigation, and NC's skip link — is rendered by core, not by the app. appinfo/info.xml wires it through <settings><admin> + <admin-section>, so the app never controls the document shell.

The remedy the gate implies is for an app's admin panel to render <NcContent>, which is the whole-page app shell. That would nest an application shell inside NC's settings page — a second landmark structure inside an existing one, which is a worse accessibility outcome than the finding, and the same "bolt a second, redundant skip link on top of the one already there" trap #201 already identified for CnAppRoot.

Why this is the same principle #201 recorded

#201 closed with: "I cannot see it" is not "it is absent" — the affordance was one component deeper than the grep could reach. Here it is one framework up rather than one component down: the shell belongs to core's settings page, so no amount of reading the app's files will find it.

Suggested direction

Drop **/AdminRoot.vue and templates/settings/*.php from the gate-38 scope when the app registers them through <settings><admin> in appinfo/info.xml — that registration is the positive, code-level signal that core owns the surrounding page. A root component that is genuinely the app's own document shell (neither NcContent nor CnAppRoot nor NC-settings-registered) should still be flagged; that part of the gate is doing real work.

No change was made to portaliq for this finding.

Activity

  1. added a commit that references this issue on Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions