Skip to content

gate-38 (skip-link): the templates/settings/*.php arm flags a mount point and fails all 6 apps that have one #216

Closed

Description

@rubenvdlinde

Summary

gate-38's templates/settings/*.php arm reports a finding on every fleet app that ships an admin-settings template. Measured on 8 templates across 6 apps — all 8 have no <NcContent> and no skip-link, so all 8 fail.

It is the same defect the gate's own comment already documents for <CnAppRoot>, one layer down: "'I cannot see it' is not 'it is absent', and only the first of those is true here."

Where it fires

[gate-38] skip-link: FAIL — 1 root component(s) without skip-link / <NcContent>
templates/settings/admin.php: no <NcContent> shell, no skip-link affordance

Reproduced full-tree on ConductionNL/openconnector@development (5ab1c9df) with the gate package cloned fresh from ConductionNL/.github@main (756fe89).

Why it is a false positive

1. The file it inspects is a mount point, not a root component. openconnector's entire templates/settings/admin.php:

<?php
use OCP\Util;
$appId = OCA\OpenConnector\AppInfo\Application::APP_ID;
Util::addScript($appId, $appId . '-settings');
Util::addStyle($appId, 'main');
?>
<div id="settings"></div>

There is no markup here to carry a skip-link. The root component is src/views/admin/AdminSettings.vue, reached via src/settings.js (createApp(AdminSettings).mount('#settings')), and its root element is <CnAdminSettingsShell> from @conduction/nextcloud-vue — the shared admin-settings shell, structurally the same situation as <CnAppRoot>, which this gate already accepts by name for exactly this reason.

2. An admin settings template is not an app root at all. Nextcloud's Settings app renders it inside core's own settings page, which supplies the page chrome and navigation. Putting an <NcContent> in a settings section would nest a second app shell inside the settings page — the gate's advice would make the markup worse, not better.

Fleet-wide, and invisible in CI

Count of skip-link / <NcContent> / <CnAppRoot> markers in each app's settings templates:

app template markers
openregister templates/settings/admin.php 0
openregister templates/settings/integrations-admin.php 0
openregister templates/settings/personal.php 0
opencatalogi templates/settings/admin.php 0
procest templates/settings/admin.php 0
procest templates/settings/email.php 0
docudesk templates/settings/admin.php 0
pipelinq templates/settings/admin.php 0

Nobody sees this because in CI gate-38 runs diff-scoped (_in_scope), so a settings template is only inspected in a PR that happens to touch it. It surfaces the moment anyone measures full-tree — which is the only honest way to get a repo-wide verdict, since push runs scope to the pushed diff.

Suggested fix

Either of:

  • Drop the templates/settings/*.php arm. A settings template is not an app root; the SC 2.4.1 obligation there belongs to core's settings page.
  • Or follow the mount point. If the template's body is only a mount <div id="...">, resolve the Vue root that mounts onto it and apply the existing root-component rules, accepting <CnAdminSettingsShell> alongside <CnAppRoot>.

The first is simpler and I think correct. Whichever is chosen, the change should be paired with a full-tree re-measure across the fleet rather than a diff-scoped run, otherwise the result is unobservable.

What I did NOT do

No app-side waiver, no skip-link markup added to a settings template just to silence the grep — that would have been comment-satisfaction against a control that is asking for the wrong thing in the wrong file. openconnector's gate-38 stays red until this is decided.

Activity

  1. rubenvdlinde commented on Aug 8, 2026

    @rubenvdlinde
    ContributorAuthor

    Confirming from larpingapp — same shape, same file name, and I can add the call path plus why the obvious remediation is a WCAG regression.

    Full-tree gate-38 at larpingapp@development:

    [gate-38] skip-link: FAIL — 1 root component(s) without skip-link / <NcContent>
    templates/settings/admin.php: no <NcContent> shell, no skip-link affordance
    

    The whole file is a mount point:

    <?php
    use OCP\Util;
    $appId = OCA\LarpingApp\AppInfo\Application::APP_ID;
    Util::addScript($appId, $appId . '-shared-vendor');
    Util::addScript($appId, $appId . '-shared-nc-vue');
    Util::addScript($appId, $appId . '-settings');
    Util::addStyle($appId, 'main');
    ?>
    <div id="settings"></div>

    Call path. lib/Settings/LarpingAppAdmin.php::getForm() returns new TemplateResponse(..., 'settings/admin', ...), registered via <settings><admin> in appinfo/info.xml. Nextcloud renders that inside /settings/admin, whose layout is core's core/templates/layout.user.php:

    <a href="<?php p($_['id-app-content']); ?>" class="button primary skip-navigation skip-content"><?php p($l->t('Skip to main content')); ?></a>
    <a href="<?php p($_['id-app-navigation']); ?>" class="button primary skip-navigation"><?php p($l->t('Skip to navigation of app')); ?></a>

    The bypass links are already on the rendered page, one layer above where the gate greps — the same "I cannot see it is not it is absent" carve-out the gate already applies to <CnAppRoot> two lines earlier in its own source.

    Adding a skip link here would make accessibility worse, which is why there is no honest in-app fix: it would be the second "Skip to main content" on the page, sitting in the middle of the settings body rather than as the first focusable element (where SC 2.4.1 requires it), pointing at an anchor the fragment does not own.

    An ISettings::getForm() template is never a document root by construction, so the scope rule could key on that directly rather than on the path glob.

    Left unfixed in larpingapp and documented in ConductionNL/larpinq#289. Closing my duplicate #232 in favour of this.

  2. rubenvdlinde commented on Aug 8, 2026

    @rubenvdlinde
    ContributorAuthor

    Ninth and tenth instance, scholiq origin/development @ fc1dffe:

    [gate-38] skip-link: FAIL — 2 root component(s) without skip-link / <NcContent>
    src/views/settings/AdminRoot.vue: no <NcContent> shell, no skip-link affordance
    templates/settings/admin.php: no <NcContent> shell, no skip-link affordance
    

    templates/settings/admin.php is nine lines and contains no markup to skip past:

    $appId = OCA\Scholiq\AppInfo\Application::APP_ID;
    Util::addScript($appId, $appId . '-settings');
    ?>
    <div id="scholiq-settings"></div>

    It is the mount point exactly as described — one empty div and a script tag.

    src/views/settings/AdminRoot.vue is the second half of the same finding and is also not an app root: it renders inside Nextcloud's own settings chrome, which already provides the page landmarks and the skip target. Its template is a plain <div class="scholiq-admin"> holding CnVersionInfoCard, ScholiqSettings, DataExchangeSettingsSection and ActionAuthMatrix.

    Adding <NcContent> to either would nest a second app-content landmark inside the settings page — a worse outcome for a screen-reader user than the finding it clears. Not silenced here, and no skip-link added; recorded against this issue instead.

  3. added a commit that references this issue on Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions