Repository navigation
style: use signal theme tokens in app views - #376
Merged
DeepDiver1975 merged 4 commits intoSep 17, 2026
Merged
Conversation
Signed-off-by: Berkcan <72012560+berkcantmr@users.noreply.github.com>
Signed-off-by: Berkcan <72012560+berkcantmr@users.noreply.github.com>
Signed-off-by: Berkcan <72012560+berkcantmr@users.noreply.github.com>
Signed-off-by: Berkcan <72012560+berkcantmr@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified, and rendered output is unchanged.
Pull request overview
Updates app views to use shared signal theme tokens while preserving rendered output.
Changes:
- Replaces hardcoded task colors with
SignalBrush. - Uses
SignalColorfor the home accent gradient. - Documents the cleanup in
CHANGELOG.md.
File summaries
| File | Description |
|---|---|
src/LageBuch.App.Shared/Views/TasksView.axaml |
Uses the shared signal brush. |
src/LageBuch.App.Shared/Views/HomeView.axaml |
Uses the shared signal color. |
CHANGELOG.md |
Documents the token cleanup. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
@claude review |
|
Claude finished @DeepDiver1975's task in 51s —— View job Review
Verdict: ✅ Looks good — no issues found. Reviewed all 3 changed files:
Checks performed:
Nothing to change here — clean, minimal, correctly scoped token cleanup. |
4 of 5 tasks
DeepDiver1975
added a commit
that referenced
this pull request
Sep 18, 2026
…ner glow The content column carried HorizontalAlignment="Center" with MaxWidth="720", which sizes it to its widest child. That child is the virtualized recent-files ListBox, whose desired width is whatever rows happen to be realized -- a long path pinned the column to 720px, and scrolling it out of view dropped the column to ~643px, so the whole page jumped sideways on every scroll. Stretch pins the column to min(viewport, 720) instead, which no child can move. The list also carried MaxHeight="420", giving it a scrollbar nested inside the page's, so the wheel moved several rows before the page moved at all. It now sizes to its (at most ten) entries and the page is the only thing that scrolls. Separately, the corner decoration rendered as a 320x320 grey rectangle with hard left and bottom edges: it faded to `Transparent`, which is transparent WHITE and interpolates through grey, its last stop sat at offset 0.7 so the box was cut mid-gradient, and StartPoint="0%,0%" put the bright end at the box's top-left, pointing into the page rather than at the corner it decorates. A radial fade anchored on that corner, ending on a zero-alpha stop of the same hue, has none of the three problems, and the negative margins that used to shove the hard edges off-screen are no longer needed. Both stops now come from the theme: #376 had just moved the bright one onto SignalColor, and the faded one is a new SignalFadedColor beside it, so the pair cannot drift apart. Measured on the regenerated docs/screenshots/home.png: the one-pixel step from (0,0,0) to (4,3,3) down the decoration's left edge is gone, and the glow is now brightest at the corner (12,3,3) rather than 240px inside the page. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
added a commit
that referenced
this pull request
Sep 18, 2026
…ner glow (#395) * fix(home): stop the Übersicht reflowing mid-scroll and redraw the corner glow The content column carried HorizontalAlignment="Center" with MaxWidth="720", which sizes it to its widest child. That child is the virtualized recent-files ListBox, whose desired width is whatever rows happen to be realized -- a long path pinned the column to 720px, and scrolling it out of view dropped the column to ~643px, so the whole page jumped sideways on every scroll. Stretch pins the column to min(viewport, 720) instead, which no child can move. The list also carried MaxHeight="420", giving it a scrollbar nested inside the page's, so the wheel moved several rows before the page moved at all. It now sizes to its (at most ten) entries and the page is the only thing that scrolls. Separately, the corner decoration rendered as a 320x320 grey rectangle with hard left and bottom edges: it faded to `Transparent`, which is transparent WHITE and interpolates through grey, its last stop sat at offset 0.7 so the box was cut mid-gradient, and StartPoint="0%,0%" put the bright end at the box's top-left, pointing into the page rather than at the corner it decorates. A radial fade anchored on that corner, ending on a zero-alpha stop of the same hue, has none of the three problems, and the negative margins that used to shove the hard edges off-screen are no longer needed. Both stops now come from the theme: #376 had just moved the bright one onto SignalColor, and the faded one is a new SignalFadedColor beside it, so the pair cannot drift apart. Measured on the regenerated docs/screenshots/home.png: the one-pixel step from (0,0,0) to (4,3,3) down the decoration's left edge is gone, and the glow is now brightest at the corner (12,3,3) rather than 240px inside the page. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com> * test(home): find controls by name instead of comparing doubles CodeQL flagged three cs/equality-on-floats in the new HomeLayoutTests: the helpers located the content column and the corner decoration by matching their MaxWidth and Width against a literal, which is exact equality on a double. The code_scanning ruleset blocks a pull request that introduces an alert, so this was a merge blocker rather than advice. Both controls now carry an x:Name and are looked up by it, the way OpenErrorBanner and RecentFilesHint already were -- that removes the comparison rather than hiding it behind a tolerance, and reads better besides. The one remaining exact comparison, Assert.Equal(0, page.Offset.Y), takes the precision overload; it is the same smell wearing a method call, which is why CodeQL does not see it. AGENTS.md's static-analysis list gains the rule, next to Path.Join and CA1031, so the next person writing a layout test does not rediscover it from a blocked pull request. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com> --------- Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SignalBrush.SignalColor.Fixes #344
Verification
make test PROJECT=tests/LageBuch.Acceptance.Tests: 170 passed, 1 skipped, 0 failed.Screenshots
Aufgaben
Home