Skip to content

style: use signal theme tokens in app views - #376

Merged
DeepDiver1975 merged 4 commits into
CodeForFire:mainfrom
berkcantmr:style/use-signal-theme-token
Sep 17, 2026
Merged

DeepDiver1975 merged 4 commits into
CodeForFire:mainfrom
berkcantmr:style/use-signal-theme-token

Conversation

@berkcantmr

Copy link
Copy Markdown
Contributor

Summary

  • Replace the two hardcoded signal-red task text colors with SignalBrush.
  • Replace the home accent gradient literal with SignalColor.
  • Document the token cleanup in the changelog.

Fixes #344

Verification

  • Commits follow Conventional Commits and are DCO signed off.
  • All commits are cryptographically signed and show as Verified on GitHub.
  • make test PROJECT=tests/LageBuch.Acceptance.Tests: 170 passed, 1 skipped, 0 failed.
  • Filtered render tests: 2 passed, 0 failed.
  • UI changes include before/after screenshots using fictional data.
  • Corresponding before/after PNGs are byte-identical, confirming no visual drift.

Screenshots

Aufgaben

Before After
Aufgaben before Aufgaben after

Home

Before After
Home before Home after

Signed-off-by: Berkcan <72012560+berkcantmr@users.noreply.github.com>
Signed-off-by: Berkcan <72012560+berkcantmr@users.noreply.github.com>
Signed-off-by: Berkcan <72012560+berkcantmr@users.noreply.github.com>
Signed-off-by: Berkcan <72012560+berkcantmr@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 16, 2026 23:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified, and rendered output is unchanged.

Pull request overview

Updates app views to use shared signal theme tokens while preserving rendered output.

Changes:

  • Replaces hardcoded task colors with SignalBrush.
  • Uses SignalColor for the home accent gradient.
  • Documents the cleanup in CHANGELOG.md.
File summaries
File Description
src/LageBuch.App.Shared/Views/TasksView.axaml Uses the shared signal brush.
src/LageBuch.App.Shared/Views/HomeView.axaml Uses the shared signal color.
CHANGELOG.md Documents the token cleanup.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@berkcantmr
berkcantmr requested a balanced review from Copilot September 16, 2026 23:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@DeepDiver1975

Copy link
Copy Markdown
Contributor

@claude review

@claude

claude Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Claude finished @DeepDiver1975's task in 51s —— View job


Review

  • Gather context (PR diff, files, CLAUDE.md/AGENTS.md instructions)
  • Review changed files for correctness, style, and adherence to repo guidelines
  • Post review feedback

Verdict: ✅ Looks good — no issues found.

Reviewed all 3 changed files:

  • src/LageBuch.App.Shared/Views/TasksView.axaml:10,20 — #FF3D2E → {StaticResource SignalBrush} for .prio-high and .due foreground.
  • src/LageBuch.App.Shared/Views/HomeView.axaml:12 — #FF3D2E → {StaticResource SignalColor} for the gradient stop.
  • CHANGELOG.md — adds a ### Changed entry under [Unreleased], as required by AGENTS.md.

Checks performed:

  • SignalColor/SignalBrush are defined in src/LageBuch.App.Shared/Theme/Tokens.axaml:29,50 as #FF3D2E, so this is a pure token substitution with identical resolved values — consistent with the PR's claim of byte-identical before/after screenshots.
  • Tokens.axaml is merged app-wide via Theme/Styles.axaml:8, so StaticResource resolves correctly from both views (same pattern already used in ScbaView.axaml, ForcesView.axaml, FilesView.axaml, IncidentWorkspaceView.axaml).
  • One commit (6e639cb) accidentally clobbered several unrelated CHANGELOG.md entries (attestation notes, unrelated bugfixes) when the changelog line was added; the very next commit (cc9ce53) restores them. Diffing the branch tip against the pre-PR base confirms the net changelog diff is exactly the intended 3-line addition with nothing else lost — no action needed, just noting it was caught and fixed within the same PR.
  • No other hardcoded #FF3D2E occurrences remain in the two touched views.
  • Follows AGENTS.md conventions: Conventional Commit subjects, DCO sign-off present on all commits, changelog entry included for a src/ change.

Nothing to change here — clean, minimal, correctly scoped token cleanup.

@DeepDiver1975
DeepDiver1975 merged commit ef79a3c into CodeForFire:main Sep 17, 2026
6 checks passed
DeepDiver1975 added a commit that referenced this pull request Sep 18, 2026
…ner glow

The content column carried HorizontalAlignment="Center" with MaxWidth="720",
which sizes it to its widest child. That child is the virtualized recent-files
ListBox, whose desired width is whatever rows happen to be realized -- a long
path pinned the column to 720px, and scrolling it out of view dropped the column
to ~643px, so the whole page jumped sideways on every scroll. Stretch pins the
column to min(viewport, 720) instead, which no child can move.

The list also carried MaxHeight="420", giving it a scrollbar nested inside the
page's, so the wheel moved several rows before the page moved at all. It now
sizes to its (at most ten) entries and the page is the only thing that scrolls.

Separately, the corner decoration rendered as a 320x320 grey rectangle with hard
left and bottom edges: it faded to `Transparent`, which is transparent WHITE and
interpolates through grey, its last stop sat at offset 0.7 so the box was cut
mid-gradient, and StartPoint="0%,0%" put the bright end at the box's top-left,
pointing into the page rather than at the corner it decorates. A radial fade
anchored on that corner, ending on a zero-alpha stop of the same hue, has none
of the three problems, and the negative margins that used to shove the hard
edges off-screen are no longer needed. Both stops now come from the theme:
#376 had just moved the bright one onto SignalColor, and the faded one is a new
SignalFadedColor beside it, so the pair cannot drift apart.

Measured on the regenerated docs/screenshots/home.png: the one-pixel step from
(0,0,0) to (4,3,3) down the decoration's left edge is gone, and the glow is now
brightest at the corner (12,3,3) rather than 240px inside the page.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975 added a commit that referenced this pull request Sep 18, 2026
…ner glow (#395)

* fix(home): stop the Übersicht reflowing mid-scroll and redraw the corner glow

The content column carried HorizontalAlignment="Center" with MaxWidth="720",
which sizes it to its widest child. That child is the virtualized recent-files
ListBox, whose desired width is whatever rows happen to be realized -- a long
path pinned the column to 720px, and scrolling it out of view dropped the column
to ~643px, so the whole page jumped sideways on every scroll. Stretch pins the
column to min(viewport, 720) instead, which no child can move.

The list also carried MaxHeight="420", giving it a scrollbar nested inside the
page's, so the wheel moved several rows before the page moved at all. It now
sizes to its (at most ten) entries and the page is the only thing that scrolls.

Separately, the corner decoration rendered as a 320x320 grey rectangle with hard
left and bottom edges: it faded to `Transparent`, which is transparent WHITE and
interpolates through grey, its last stop sat at offset 0.7 so the box was cut
mid-gradient, and StartPoint="0%,0%" put the bright end at the box's top-left,
pointing into the page rather than at the corner it decorates. A radial fade
anchored on that corner, ending on a zero-alpha stop of the same hue, has none
of the three problems, and the negative margins that used to shove the hard
edges off-screen are no longer needed. Both stops now come from the theme:
#376 had just moved the bright one onto SignalColor, and the faded one is a new
SignalFadedColor beside it, so the pair cannot drift apart.

Measured on the regenerated docs/screenshots/home.png: the one-pixel step from
(0,0,0) to (4,3,3) down the decoration's left edge is gone, and the glow is now
brightest at the corner (12,3,3) rather than 240px inside the page.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>

* test(home): find controls by name instead of comparing doubles

CodeQL flagged three cs/equality-on-floats in the new HomeLayoutTests: the
helpers located the content column and the corner decoration by matching their
MaxWidth and Width against a literal, which is exact equality on a double. The
code_scanning ruleset blocks a pull request that introduces an alert, so this
was a merge blocker rather than advice.

Both controls now carry an x:Name and are looked up by it, the way
OpenErrorBanner and RecentFilesHint already were -- that removes the comparison
rather than hiding it behind a tolerance, and reads better besides. The one
remaining exact comparison, Assert.Equal(0, page.Offset.Y), takes the precision
overload; it is the same smell wearing a method call, which is why CodeQL does
not see it.

AGENTS.md's static-analysis list gains the rule, next to Path.Join and CA1031,
so the next person writing a layout test does not rediscover it from a blocked
pull request.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>

---------

Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

style: use the SignalBrush token instead of three hardcoded #FF3D2E literals

3 participants