Repository navigation
feat(tasks): allow editing Aufgaben fields and extending the timer - #255
DeepDiver1975 wants to merge 7 commits into
Conversation
|
Follow-up fix pushed to this branch: renamed the quick-extend button from "+5" to "+5 min", and fixed the extension math so hitting it on an already-overdue task sets the new due time to 🤖 Generated with Claude Code |
|
Follow-up fix: WICHTIG/DRINGL. lost their red/amber/muted priority color-coding when those columns became editable ComboBoxes — the style rules were still scoped to a Restored the coloring on the Before (all three rows look identical): After (High = red border + bold, Medium = amber border, Low = muted, no border accent): 🤖 Generated with Claude Code |
|
Follow-up fix from a visual UX pass on the live app: focusing the WICHTIG/DRINGL. ComboBoxes showed two mismatched, nested rectangles — the new rounded priority-color border, plus Fluent's own square black/white "current cell" focus indicator drawn on top of it. Reads as a rendering glitch. Root cause: Also spot-checked the ETB tab (plain read-only text cells, no per-control focus ring) to confirm removing this doesn't leave keyboard navigation "invisible" — the row-selection highlight still shows clearly. Noted but deliberately out of scope for this fix: the grid stretches to fill its panel regardless of row count, leaving empty space below a short list — this is a pre-existing convention shared by every grid tab in the app, not a regression, so it's left for a separate cross-tab pass. 🤖 Generated with Claude Code |
DeepDiver1975
left a comment
There was a problem hiding this comment.
@dcoapp recheck
2bfe134 to
e879fba
Compare
|
Rebased onto current What I changedThe conflict. Only The missing changelog entry. This PR touches
Widened to 145 / 145 / 210.
Verification
Screenshot
🤖 Generated with Claude Code |
Wichtigkeit, Dringlichkeit, Zugeteilt an and Aufgabe were read-only in the AUFGABEN grid, and there was no way to add time to a running timer. Add IncidentTask.WithDetails/WithExtendedTimer plus Incident.UpdateTask/ExtendTaskTimer (silent, like AddTask), the matching sync commands, and wire the grid's cells to editable controls with a "+5" quick action. Fixes #246 Co-authored-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com> Signed-off-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
The #246 commit didn't build: TasksViewModel.cs tripped SA1512 (a single-line comment block followed by a blank line), TasksView.axaml had an invalid XML comment (-- inside the content), and the test double SnapshotRoundTrippingSession was missing the new IIncidentSession members UpdateTask/ExtendTaskTimer, matching the AddTask/SetTaskCompleted delegation pattern already there. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GqpTMbqRRgLQSjX9T2VUFF Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
…asks The task list's quick-extend button said "+5" without units; rename to "+5 min". More importantly, extending the timer on an already-overdue task added 5 minutes to the stale due time instead of the current time, so the task often stayed overdue after the click. WithExtendedTimer now rebases to "now" once a task is overdue, while still stacking onto the existing due time for a task that isn't due yet. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JRukwMVSLfCNhtsssTNyWK Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Making these columns editable ComboBoxes (instead of plain TextBlocks) left the prio-high/medium/low style rules dangling on a "TextBlock." selector that a ComboBox never matches, so every row rendered in the same flat color and the at-a-glance priority signal was gone. Retarget the rules at the ComboBox and color both the text and the border, not just the text -- a colored word alone is a weaker signal once it sits inside a bordered, chevron-decorated control. High also gets semibold weight, matching the old TextBlock and the "FÄLLIG" badge; low stays visually quiet by design. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JRukwMVSLfCNhtsssTNyWK Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Fluent's DataGridCell draws its own square "current cell" focus indicator (two stacked rectangles) on top of the cell's content, independent of whatever's inside the cell. It was invisible-ish on a plain-text cell, but now visibly clashes with the Aufgaben priority ComboBoxes' new rounded, colored border -- two mismatched nested rectangles that read as a rendering glitch. Every editable control here already shows its own focus ring (ComboBox/TextBox :focus), and DataGridRow already highlights on selection, so the square overlay is redundant everywhere, not just on the new colored cells. Suppress it in the shared theme rather than scoping to Tasks, since FocusVisualPrimary/Secondary are template parts of DataGridCell itself and can't be reached from outside based on what a specific cell's content looks like. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JRukwMVSLfCNhtsssTNyWK Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
The PR predates the `changelog-check` CI job, so it touches `src/` without an entry under `[Unreleased]` and would now fail that check. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Regenerating docs/screenshots/aufgaben.png -- stale since this branch made the grid editable, and required by AGENTS.md because the website build copies it -- showed the new controls clipping their own content. WICHTIG at Width="120" cut "Niedrig" off: a ComboBox reserves room for its chevron, so less is left for the text than the read-only TextBlock had. A triage column that cannot display one of its three possible values is worse than what it replaced. DRINGL. at 130 was borderline; both are now 145. ZUGETEILT at Width="150" cut "Florian Musterstadt 41/1" off -- an ordinary Funkrufname, and one the demo Einsatz already contains. The old DataGridTextColumn auto-sized and never showed this. Now 210. AUFGABE keeps Width="*" and takes whatever is left. docs/demo/einsatz-flow.gif is assembled from docs/screenshots, so it is regenerated with it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
e879fba to
65e653f
Compare
…le (#569) * feat(tasks): edit an Aufgabe in a panel, priorities on a coloured scale An Aufgabe could not be changed once created (#246). It can now be corrected in a panel that takes the input dock's place: Wichtigkeit, Dringlichkeit, Zugeteilt an and the text. The panel opens with the row's pencil, Enter or F2, and follows the inline overlay keyboard contract. The grid stays read-only coloured text. Live controls in its cells (#255) turned Hoch and Niedrig into identical drop-downs. That removed the triage colours, which are what the list is read for. - Wichtigkeit and Dringlichkeit are picked on a Niedrig | Mittel | Hoch scale whose chosen segment fills in the grid's colour for that level. The same scale is used in the edit panel, the input dock and the task dialog. TriageSegments gives the ListBox focus from code, Left/Right across a UniformGrid, and Enter through to the form. - +5 MIN, in the panel and on the Aufgabe-fällig bar, puts a task off; an overdue one from now. Its alarm sounds again when it falls due. - ZUGETEILT becomes ZUGETEILT AN. - A client may now send updateTask and extendTaskTimer, so ProtocolVersion and MinimumProtocolVersion rise to 7. The domain, sync command and session layers are taken from #255. Fixes #246 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com> * fix(tasks): keep the triage scale level with the fields beside it In the edit panel, SPEICHERN and ABBRECHEN sat about 7dp below the fields' line. The app's recent-files ListBoxItem style spaces its cards 7dp apart (Margin 0,0,0,7). The triage segments inherited that margin, so the scale measured 43dp against the 36dp fields. Its row grew to match, and the bottom-aligned buttons dropped with it. The triage item style now resets the margin. The comment that blamed Fluent for the boxes between segments is corrected: they also came from the recent-files style. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com> --------- Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
superseded by #569 |









Summary
Aufgaben (tasks) fields in the AUFGABEN grid — Wichtigkeit, Dringlichkeit,
Zugeteilt an, Aufgabe — were entirely read-only after creation, and a
running timer couldn't be extended. Fixes #246.
Changes
IncidentTask.WithDetails/WithExtendedTimerplusIncident.UpdateTask/ExtendTaskTimer(silent domain edits, no ETBentry — same idiom as
AddTask).UpdateTaskCommand,ExtendTaskTimerCommand)wired through
LocalIncidentSession/RemoteIncidentSession/CommandApplier.ZUGETEILT is an AutoCompleteBox (callsigns/Funktionen/personnel suggest,
free text otherwise), AUFGABE is a TextBox (commits on
LostFocus, notper keystroke), and TIMER gets a "+5" quick-action button.
invalid
--inside an AXAML XML comment, and a test double(
SnapshotRoundTrippingSession) that didn't yet implement the two newIIncidentSessionmembers.Checklist
git commit -s)dotnet buildanddotnet testpass locally