You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Understand the request: which fields need to become editable
Assess complexity and propose a solution
Report findings/plan in this comment
Root cause
TasksView.axaml renders every AUFGABEN column as read-only:
WICHTIGKEIT, DRINGL., TIMER, AUFGABE are DataGridTemplateColumns with IsReadOnly="True" and plain TextBlocks (src/LageBuch.App.Shared/Views/TasksView.axaml:95-134).
ZUGETEILT is a DataGridTextColumn also marked IsReadOnly="True" (line 123).
Only the checkbox (IsDone) is two-way bound.
There's also no domain support for editing: Incident.AddTask (src/LageBuch.Domain/Incident.cs:825) and Incident.SetTaskCompleted (line 857) are the only mutators — there's no "update task fields" or "extend due time" method, and no sync command for either.
Proposed solution
Follow the existing Forces tab pattern (ForcesViewModel/ForcesView.axaml), which already does inline, always-editable DataGrid rows gated by IsEnabled="{Binding !IsReadOnly}", pushing changes back through a callback into the session on each change:
Add Incident.UpdateTask(Guid taskId, string text, string? assignee, TaskImportance importance, TaskUrgency urgency, ...), validated like AddTask (enum range checks, text length/non-empty).
Add Incident.ExtendTaskTimer(Guid taskId, int minutes) for the "+5 min" action, extending DueAt (needs a decision on behavior when DueAt == DateTimeOffset.MaxValue, i.e. a task created with no timer — likely disable the button in that case).
Sync surface
New UpdateTaskCommand / ExtendTaskTimerCommand records in SyncCommand.cs (with [JsonDerivedType] entries), handled in CommandApplier.cs.
New IIncidentSession.UpdateTask(...) / ExtendTaskTimer(...) methods, implemented in LocalIncidentSession (mutate + save) and RemoteIncidentSession (send command).
No SQLite migration needed — Text/Assignee/Importance/Urgency/DueAt are already persisted columns; editing just changes values already round-tripped through Rehydrate.
ViewModel (TaskRow in TasksViewModel.cs)
Turn Text, Assignee, Importance, Urgency into [ObservableProperty]s with partial void On...Changed handlers that push through the session (mirroring TaskRow.OnIsDoneChanged / ForceUnitRow's _onEdited/_onStrengthEdited).
Add an ExtendTimerCommand (+5 min button per row).
View (TasksView.axaml)
Replace the static TextBlocks for WICHTIGKEIT/DRINGLICHKEIT with the same ComboBox used in the input dock / TaskDialogView.
Replace ZUGETEILT's read-only text column with an AutoCompleteBox (same AssigneeOptions).
Make AUFGABE an editable TextBox.
Add a small "+5" button next to the TIMER column, disabled once a task has no active due time or is completed.
Drop the grid's blanket IsReadOnly="{Binding IsReadOnly}" in favor of per-control IsEnabled="{Binding !IsReadOnly}", as Forces does.
Open design question worth confirming before implementing
Incident.AddTask is documented as deliberately silent — "tasks are work management, not the operational log" (Incident.cs:818-824), unlike EditRolePhone/UpdateForceUnit, which log a correction line to the ETB. I'd default edits to stay silent too (consistent with AddTask/RenameFile), but since this issue is explicitly about correcting task data (typos, reassignment), it's worth confirming whether a silent correction is acceptable or whether an audit trail is wanted here.
Complexity assessment
This touches 7 files across 4 layers (domain, sync commands/applier, both IIncidentSession implementations, ViewModel, view) plus new tests (domain, CommandApplier round-trip, ViewModel) and a screenshot per this repo's PR requirements (AGENTS.md) — a complex change, not a one-file fix. Given the trigger comment asked for analysis rather than a straight implementation, I've stopped at the design here. Let me know if you'd like me to go ahead and implement it (and to confirm the silent-vs-logged question above) and I'll open a PR.
Done — implementation pushed, build/test verification not possible in this sandbox
Implemented edit capability for Aufgaben (tasks), following the design from the earlier analysis comment (Forces-tab pattern: inline always-editable DataGrid rows).
Sync: UpdateTaskCommand / ExtendTaskTimerCommand (no operator on the wire, silent) + CommandApplier handling
IIncidentSession.UpdateTask/ExtendTaskTimer implemented in LocalIncidentSession and RemoteIncidentSession
ViewModel: TaskRow.Text/Assignee/Importance/Urgency are now [ObservableProperty]s that write through on change (mirrors ForceRow); added ExtendTimerCommand (+5 min, disabled once done or for a task created without a timer)
View: WICHTIG/DRINGL. are now ComboBoxes, ZUGETEILT an AutoCompleteBox, AUFGABE an editable TextBox, TIMER gets a "+5" button
Build & run tests — blocked: dotnet build/dotnet test (and even dotnet --version, python3) require approval in this sandboxed job and there's no one to approve it non-interactively. I reviewed every diff by hand instead (signatures, tag balancing in the .axaml, unused-variable checks against this repo's TreatWarningsAsErrors/AnalysisMode=All), but this is not a substitute for an actual compile+test run.
Screenshots — blocked for the same reason: the render harness (WorkspaceRenderHelper/TasksTabRenderTests) needs dotnet test to run.
Commit, push
If you can grant this job's tooling dotnet build/dotnet test permissions (or point me at how to update --allowedTools), I can come back and run the suite plus capture the required before/after screenshots per AGENTS.md. Otherwise, please run dotnet test locally before merging — happy to fix anything that surfaces.
Design note carried over from the analysis: edits stay silent (no ETB line), consistent with AddTask/RenameFile; only a KeyNotFoundException/ArgumentException on bad input, same as the existing task mutators.
Reopened — closed by accident. PR #309 (the v0.5.0 changelog prep) described #255 as "closes #246" in its body, and GitHub took that as a closing keyword on merge. #255 is still open and deferred to 0.5.1; this bug is not fixed yet.
Editing a task crosses the wire as a new SyncCommand; today only addTask and setTaskCompleted exist (src/LageBuch.Sync/SyncCommand.cs:41-42). A peer at the floor cannot handle a new command, so this has to raise MinimumProtocolVersion (currently 4, see AGENTS.md, Sync protocol version). Every device in a fleet then needs the update, which belongs in the release notes.
Activity
DeepDiver1975 commentedon Sep 6, 2026
@claude analyse and propose a solution
claude commentedon Sep 6, 2026
Claude finished @DeepDiver1975's task in 1m 44s —— View job
Analysis: Aufgaben (tasks) editing
Todo list
Root cause
TasksView.axamlrenders everyAUFGABENcolumn as read-only:WICHTIGKEIT,DRINGL.,TIMER,AUFGABEareDataGridTemplateColumns withIsReadOnly="True"and plainTextBlocks (src/LageBuch.App.Shared/Views/TasksView.axaml:95-134).ZUGETEILTis aDataGridTextColumnalso markedIsReadOnly="True"(line 123).IsDone) is two-way bound.There's also no domain support for editing:
Incident.AddTask(src/LageBuch.Domain/Incident.cs:825) andIncident.SetTaskCompleted(line 857) are the only mutators — there's no "update task fields" or "extend due time" method, and no sync command for either.Proposed solution
Follow the existing Forces tab pattern (
ForcesViewModel/ForcesView.axaml), which already does inline, always-editableDataGridrows gated byIsEnabled="{Binding !IsReadOnly}", pushing changes back through a callback into the session on each change:Domain (
IncidentTask.cs/Incident.cs)IncidentTask.With(text, assignee, importance, urgency)wither.Incident.UpdateTask(Guid taskId, string text, string? assignee, TaskImportance importance, TaskUrgency urgency, ...), validated likeAddTask(enum range checks, text length/non-empty).Incident.ExtendTaskTimer(Guid taskId, int minutes)for the "+5 min" action, extendingDueAt(needs a decision on behavior whenDueAt == DateTimeOffset.MaxValue, i.e. a task created with no timer — likely disable the button in that case).Sync surface
UpdateTaskCommand/ExtendTaskTimerCommandrecords inSyncCommand.cs(with[JsonDerivedType]entries), handled inCommandApplier.cs.IIncidentSession.UpdateTask(...)/ExtendTaskTimer(...)methods, implemented inLocalIncidentSession(mutate + save) andRemoteIncidentSession(send command).Text/Assignee/Importance/Urgency/DueAtare already persisted columns; editing just changes values already round-tripped throughRehydrate.ViewModel (
TaskRowinTasksViewModel.cs)Text,Assignee,Importance,Urgencyinto[ObservableProperty]s withpartial void On...Changedhandlers that push through the session (mirroringTaskRow.OnIsDoneChanged/ForceUnitRow's_onEdited/_onStrengthEdited).ExtendTimerCommand(+5 min button per row).View (
TasksView.axaml)TextBlocks forWICHTIGKEIT/DRINGLICHKEITwith the sameComboBoxused in the input dock /TaskDialogView.ZUGETEILT's read-only text column with anAutoCompleteBox(sameAssigneeOptions).AUFGABEan editableTextBox.TIMERcolumn, disabled once a task has no active due time or is completed.IsReadOnly="{Binding IsReadOnly}"in favor of per-controlIsEnabled="{Binding !IsReadOnly}", as Forces does.Open design question worth confirming before implementing
Incident.AddTaskis documented as deliberately silent — "tasks are work management, not the operational log" (Incident.cs:818-824), unlikeEditRolePhone/UpdateForceUnit, which log a correction line to the ETB. I'd default edits to stay silent too (consistent withAddTask/RenameFile), but since this issue is explicitly about correcting task data (typos, reassignment), it's worth confirming whether a silent correction is acceptable or whether an audit trail is wanted here.Complexity assessment
This touches 7 files across 4 layers (domain, sync commands/applier, both
IIncidentSessionimplementations, ViewModel, view) plus new tests (domain,CommandApplierround-trip, ViewModel) and a screenshot per this repo's PR requirements (AGENTS.md) — a complex change, not a one-file fix. Given the trigger comment asked for analysis rather than a straight implementation, I've stopped at the design here. Let me know if you'd like me to go ahead and implement it (and to confirm the silent-vs-logged question above) and I'll open a PR.DeepDiver1975 commentedon Sep 6, 2026
@claude open pr
claude commentedon Sep 6, 2026
Claude finished @DeepDiver1975's task in 10m 6s —— View job •
claude/issue-246-20260906-2137• Create PR ➔Done — implementation pushed, build/test verification not possible in this sandbox
Implemented edit capability for Aufgaben (tasks), following the design from the earlier analysis comment (Forces-tab pattern: inline always-editable
DataGridrows).Todo list
IncidentTask.WithDetails(...)/WithExtendedTimer(...)+Incident.UpdateTask(...)+Incident.ExtendTaskTimer(...)(silent, matchingAddTask's "tasks aren't ETB events" precedent)UpdateTaskCommand/ExtendTaskTimerCommand(no operator on the wire, silent) +CommandApplierhandlingIIncidentSession.UpdateTask/ExtendTaskTimerimplemented inLocalIncidentSessionandRemoteIncidentSessionTaskRow.Text/Assignee/Importance/Urgencyare now[ObservableProperty]s that write through on change (mirrorsForceRow); addedExtendTimerCommand(+5 min, disabled once done or for a task created without a timer)WICHTIG/DRINGL.are nowComboBoxes,ZUGETEILTanAutoCompleteBox,AUFGABEan editableTextBox,TIMERgets a "+5" buttonIncidentTaskAggregateTests), sync (CommandApplierTests,CommandSerializationTests,WorkspaceCollaborationTestshost↔client round trip), session (LocalSessionTaskTests), ViewModel (TasksViewModelTests)dotnet build/dotnet test(and evendotnet --version,python3) require approval in this sandboxed job and there's no one to approve it non-interactively. I reviewed every diff by hand instead (signatures, tag balancing in the.axaml, unused-variable checks against this repo'sTreatWarningsAsErrors/AnalysisMode=All), but this is not a substitute for an actual compile+test run.WorkspaceRenderHelper/TasksTabRenderTests) needsdotnet testto run.If you can grant this job's tooling
dotnet build/dotnet testpermissions (or point me at how to update--allowedTools), I can come back and run the suite plus capture the required before/after screenshots perAGENTS.md. Otherwise, please rundotnet testlocally before merging — happy to fix anything that surfaces.Design note carried over from the analysis: edits stay silent (no ETB line), consistent with
AddTask/RenameFile; only aKeyNotFoundException/ArgumentExceptionon bad input, same as the existing task mutators.ci(claude): install .NET SDK and allow dotnet in Claude's job
ci(claude): allow dotnet build/test in Claude's GitHub Actions job (#249
fix(tasks): build-fix the Aufgaben editing feature
DeepDiver1975 commentedon Sep 11, 2026
Reopened — closed by accident. PR #309 (the v0.5.0 changelog prep) described #255 as "closes #246" in its body, and GitHub took that as a closing keyword on merge. #255 is still open and deferred to 0.5.1; this bug is not fixed yet.
feat(tasks): allow editing Aufgaben fields and extending the timer
fix(tasks): build-fix the Aufgaben editing feature
feat(tasks): allow editing Aufgaben fields and extending the timer
fix(tasks): build-fix the Aufgaben editing feature
docs: add keyboard-control milestone v0.8 to the roadmap (#546)
DeepDiver1975 commentedon Oct 1, 2026
Planning note: this stays in v0.8, but as its own item rather than a child of the keyboard epic #545. It is a field bug in its own right.
SyncCommand; today onlyaddTaskandsetTaskCompletedexist (src/LageBuch.Sync/SyncCommand.cs:41-42). A peer at the floor cannot handle a new command, so this has to raiseMinimumProtocolVersion(currently 4, see AGENTS.md, Sync protocol version). Every device in a fleet then needs the update, which belongs in the release notes.docs: move #282 to v0.11 and list #246 apart from the keyboard epic
docs: move #282 to v0.11 and list #246 apart from the keyboard epic (#…