Skip to content

style: use the SignalBrush token instead of three hardcoded #FF3D2E literals #344

Closed

Description

@DeepDiver1975

src/LageBuch.App.Shared/Theme/Tokens.axaml defines the design tokens, including
the signal red used for primary actions:

<Color x:Key="SignalColor">#FF3D2E</Color>                                  <!-- line 29 -->
<SolidColorBrush x:Key="SignalBrush" Color="{StaticResource SignalColor}" /> <!-- line 50 -->

Three views still hardcode that same hex instead of using the token:

  • src/LageBuch.App.Shared/Views/TasksView.axaml line 10
  • src/LageBuch.App.Shared/Views/TasksView.axaml line 20
  • src/LageBuch.App.Shared/Views/HomeView.axaml line 12

What to do

Replace those three literals with {StaticResource SignalBrush}, or
{StaticResource SignalColor} where the property wants a Color rather than a
brush. Nothing else.

This is a deliberate no-op visually: the hex is identical, so the rendered pixels
must not change. That is what makes it safe and what makes it verifiable.

Leave these two alone, they are different systems:

  • src/LageBuch.App/Assets/icon.svg — an image asset, not themed XAML
  • src/LageBuch.Documents/Sections/CoMessprotokollSection.cs — the QuestPDF report, which does not read Avalonia resources

Verify

make test PROJECT=tests/LageBuch.Acceptance.Tests

The render test suite compares rendered output, so it will catch any accidental
pixel drift.

Difficulty: easy.


New here?

Comment to claim this issue and it is yours. If no pull request appears within
seven days it goes back in the pool, no hard feelings.

Before you open the PR, please skim CONTRIBUTING.md:
commits need DCO sign-off (git commit -s) and a Conventional Commit subject.
Changes under src/ additionally need an entry under ## [Unreleased] in
CHANGELOG.md — CI fails the PR otherwise.

Questions are welcome right here or in
Discussions.

Activity

  1. berkcantmr commented on Sep 16, 2026

    @berkcantmr
    Contributor

    I’d like to work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomersuxUser interface and usability

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions