Skip to content

Portability review: what is Bavarian, what is German, what is universal (tracking) #405

Open

Description

@DeepDiver1975

A review of main (ecb341b) asking three questions: how much of the implemented logic works for another Bavarian Feuerwehr, how much works elsewhere in Germany, and — setting the missing i18n aside — how much would work anywhere. This issue is the frame; the individual findings are filed separately below.

The short answer

Another Bavarian brigade: everything, unchanged. There is no catalogue of Bavarian practice to port. MasterDataStore.GetOrCreate seeds nothing and StammdatenCatalogue never rejects an unknown value, so roles, vehicle status, Trupp types, vehicles, call signs, Wachen, checklist contents and links are all user-supplied. IncidentNumber is eighteen lines whose only rule is non-blank — the B 1.2 JJMMTT lfd.Nr. scheme exists solely as a placeholder hint in IncidentDataDialogView.axaml:26 and a line in the README. There is no Dienstgrad model, no Landkreis, no Kreisbrandinspektion, no Alarmstufen, no AAO, no FMS status enum, no vehicle-type taxonomy and no Funkrufname grammar anywhere in src/.

Rest of Germany: everything, and one word is wrong. FwDV 7 and the AGW behind the CO bands are federal. The one Bavarian-but-not-German artefact is the label "ILS" (#400).

Anywhere else, ignoring language: the chassis travels intact — the append-only ETB with correction-by-annotation, role handover, tasks, attachments, links, checklists, the reminder timers, the file-per-incident format with its 21 migrations, offline multi-device sync, and the whole persistence layer. None of it keys off German law; the evidentiary model is general legal-record practice.

Two domain modules do not travel, and they are the only two: Atemschutz and CO-Messprotokoll.

Filed

Defects in Bavaria today, independent of any export ambition:

Germany-wide:

Outside the German doctrine:

Added as comments to existing issues rather than filed fresh:

Not filed, deliberately

ForceUnit's shape — StrengthText is $"{Zf}/{Officer}/{Mannschaft}/{Total}" with exactly two leadership tiers baked into the aggregate — has no equivalent in services that count "engine with a crew of four". The right answer is almost certainly to render the four integers through a formatter rather than reshape the aggregate, since those integers are already a schema and sync-wire contract. That is a sub-point of #299 and needs no issue of its own until someone actually wants it.

Two incidental findings, neither worth an issue: the README's "Sirene" (README.md:68) does not exist — the retreat alarm is a clip repeated every 15 s, which #81 decided deliberately — and the spoken cues are four pre-recorded German WAVs rather than TTS, so localising audio means re-recording, not changing a locale string. The German words are not in the repo as text at all, only as XML comments on AlarmSound.

Why this is worth having written down

Nothing here argues Lagebuch should target other countries. The useful output is the opposite: it shows that the Bavarian assumptions people would expect to be baked in mostly are not, and that the ones that genuinely are — a flat Rückzugsdruck, AGW ppm bands, EG/OG/UG, a Trupp type identified by its German name — are in two modules and a handful of constants. Anyone reading Domain should know which constants are universal and which are local, and right now only CoSeverity says so in its own doc comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions