Skip to content

feat(rückmeldung): "ILS" is hardcoded — including in the ETB entry written to the incident file #400

Open

Description

@DeepDiver1975

From a portability review of main (ecb341b).

The gap

"ILS" — Integrierte Leitstelle — is the Bavarian name for the dispatch centre. Elsewhere in Germany the counterpart is a Kreisleitstelle, Rettungsleitstelle or plain Leitstelle; in Austria it is a Landeswarnzentrale or Bezirksalarmzentrale. The word is hardcoded in three places:

  • the workspace button — src/LageBuch.App.Shared/Views/IncidentWorkspaceView.axaml:170
  • the two settings labels — src/LageBuch.App.Shared/Views/MasterDataEditorView.axaml:74,80
  • the ETB entry written into the incident file — src/LageBuch.AppLogic/ViewModels/ReminderViewModel.cs:121:
EtbDirection.Outgoing, "Rückmeldung an ILS", from: _session.Operator?.CallSign, to: "ILS");

The first two are labels. The third is data: it lands in etb_entries.text and etb_entries.to and stays there for the life of the file.

Why this one is worth thinking about rather than just renaming

Everything else a brigade would recognise as local vocabulary is already master data — roles, vehicle status, Trupp types, call signs, checklists. StammdatenCatalogue never rejects an unknown value. The dispatch counterparty is the one operational concept the app names for you.

A string in IncidentSettings (md_settings, alongside ils_reminder_interval_minutes) covers the two labels cheaply. The ETB entry is the interesting half, because writing the configured label into the file makes the record locally correct but the file no longer self-describing, while writing a stable key and rendering the label at display time means old files and new files disagree about what they contain.

That is the same question #350 has to answer for every other piece of German wording the domain persists, so this issue should probably wait on that decision rather than pre-empt it — but the dispatch label is a good concrete test case for whatever gets decided, because unlike "Einsatz begonnen" it genuinely varies between installs within Germany.

Scope note

The ils_number column in incident_meta is unrelated legacy — a retired second number merged back into the Einsatznummer on load (IncidentRepository.cs:633-639). Not part of this.

Activity

  1. DeepDiver1975 commented on Sep 30, 2026

    @DeepDiver1975
    ContributorAuthor

    #521 takes the practical half of this, because #415 needs to recognise the Leitstelle by name:

    The reminder writes the configured name into etb_entries as plain text, like every other ETB entry today. So the key-vs-rendered-text question is still open here, and still waits on #350.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesti18nLocalization and translatable strings

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions