Skip to content

feat(atemschutz): the retreat rule is a flat 50 bar — the Einstiegsdruck never enters it, and bar is a literal not a unit #402

Open

Description

@DeepDiver1975

From a portability review of main (ecb341b). The largest single item that review turned up; filing it for the record rather than proposing it be done soon.

What the rule is today

// src/LageBuch.Domain/Atemschutz/AtemschutzTrupp.cs
public const int DefaultReturnPressureBar = 50;                 // :31
public bool IsPressureAlarm => (IsActive || IsWithdrawing)      // :328
    && LatestPressure is { } p && p <= ReturnPressureBar;

A flat absolute comparison against a per-Trupp scalar seeded from IncidentSettings.ReturnPressureBar. There is no computed retreat pressure anywhere in the repo — no two-thirds rule, no reserve calculation, no cylinder-volume or consumption model. Greps for 2/3, Zweidrittel, Reserve, Flasche find nothing.

Two consequences

Entry pressure is captured but never used. Register demands an Einstiegsdruck and validates it (:117-162), and then it plays no part in any alarm. A Trupp starting at 200 bar and one starting at 300 bar alarm at the same 50 bar, having consumed very different fractions of their air. The Einstiegsdruck is documentation only.

Whether that is wrong for German practice is a question for someone who teaches Atemschutz, not for me — a fixed Rückzugsdruck is a defensible and widely taught rule, and it is configurable per install. Flagging it because the captured-but-unused input looks like an unfinished thought rather than a decision.

bar is not a unit, it is a literal. PressureReading is (DateTimeOffset Time, int Bar); the sync command is RecordScbaPressureCommand(Guid TruppId, int Bar); the column is return_pressure_bar; the master-data key is return_pressure_bar; and " bar" is concatenated as a string suffix in nine places across the UI, the PDF and the domain exception message (:349). There is no conversion path.

Also hardcoded rather than configured: the 300-bar entry default is a UI literal (ScbaViewModel.cs:228,524), so a brigade on 200-bar sets retypes it on every registration; MaxPressureBar = 400 (:33); and the pressure-check interval defaults to a third of the Einsatzzeit (ScbaViewModel.cs:376-382) rather than to the domain's own DefaultPressureControlIntervalMinutes.

Why this blocks any use outside the German doctrine

A fixed bar threshold cannot express either of the two rules used in the English-speaking fire services: UK BA entry control computes a time-of-whistle from cylinder pressure and consumption rate, and NFPA 1404's rule of air management is a fraction (leave by one third remaining). Neither is a constant.

Shape of a fix, if it is ever wanted

  • a pressure unit on IncidentSettings (bar/psi) with display and validation derived from it, rather than a literal suffix;
  • entry pressure as a first-class input to the alarm rule;
  • the rule itself selected from { absolute threshold, fraction of entry pressure, time-based }, defaulting to the current absolute behaviour so no existing install changes.

This touches PressureReading, the sync command, the schema, the PDF and AtemschutzTests (:211-226 pins the current semantics and would be rewritten deliberately, not adjusted). It is a milestone, not a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions