Repository navigation
adds support for http_proxy and https_proxy - #13
Closed
MartinKnopf wants to merge 4 commits into
Closed
MartinKnopf wants to merge 4 commits into
MartinKnopf wants to merge 4 commits into
Conversation
rauchg
reviewed
Dec 9, 2018
|
|
||
| const proxyAddress = process.env.http_proxy | ||
| || process.env.HTTP_PROXY | ||
| || process.env.https_proxy |
Member
There was a problem hiding this comment.
is the lowercase version really a thing 😨
leo
suggested changes
Feb 26, 2019
leo
left a comment
leo
left a comment
Contributor
There was a problem hiding this comment.
Shouldn't this be an option instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
this pull request is preparing support for proxies in
now-cli(vercel/vercel#255). I tested it behind a corporate proxy.Cheers,
Martin