Skip to content

update-check doesn't use proxy from environment #14

Open

Description

@samdbmg

Not sure if this is one for here or https://github.com/zeit/serve but it looks like update-check doesn't pick up the proxy from the $HTTP_PROXY/$HTTPS_PROXY env vars, or anywhere else as far as I can tell (possibly because http/https don't do it automatically?)
As a result serve takes a very long time before the update check times out when behind a proxy, which I'm sure it didn't used to? Much as in an ideal world there wouldn't be any proxies, the reality of corporate networks is far from ideal!

I've tried this on Ubuntu 16.04.1 (node v8.12.0) and macOS 10.13.6 (node v9.11.2)

serve is a brilliant little tool by the way!

Activity

  1. MartinKnopf commented on Nov 7, 2018

    @MartinKnopf

    I added support for http_proxy with pull request #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions