Repository navigation
Fixes #39742 - Add allowed_nested_id to ForeignInputSetsController - #1067
Merged
Merged
Conversation
ofedoren
changed the title
ofedoren
marked this pull request as ready for review
September 7, 2026 12:48
Contributor
|
Thank you @ofedoren ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
theforeman/foreman#11215 had a change that caused REX CI turn red. Previously we treated any
<resource>_idin params as a parent resource, with that change we check only ones listed inallowed_nested_idoverride. Currently we don't have such override for foreign input sets controller, thus we ignore the parent id.