Skip to content

Fixes #39718 - Fix NoMethodError when organization_id/location_id passed to images API - CP 3.18 - #11326

Open
dkelson wants to merge 1 commit into
theforeman:3.18-stablefrom
dkelson:39718-cp-3.18
Open

dkelson wants to merge 1 commit into
theforeman:3.18-stablefrom
dkelson:39718-cp-3.18

Conversation

@dkelson

@dkelson dkelson commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Cherry-pick of #11215 for 3.18.

On 3.18.2, hammer users with organization/location defaults can't manage template inputs. hammer template-input create fails with a 422 ("This template is locked", "Input type is not included in the list") and hammer template-input list returns a 500. The organization_id/location_id that hammer adds get picked as the nested parent, so the template is looked up by the location's id.

This needs theforeman/foreman_remote_execution#1067 alongside it, or the foreign input sets API loses its parent template. 3.18 ships REX 16.5.x, which has no stable branch I could target. Could someone cut a 16.5.z with it, or tell me where to send it?

Tested by applying both changes to a 3.18.2 / Katello 4.20 install: template-input create and list work with organization/location ids, and so do the foreign input set, report template and audit lists.

@pr-processor pr-processor Bot added Not yet reviewed Stable branch PRs that are opened against a stable branch. Usually a cherry pick labels Oct 10, 2026
@lzap

lzap commented Oct 14, 2026

Copy link
Copy Markdown
Member

Okay, first question: is this technically viable for 3.18? @evgeni @adamruzicka

Second question is for the backporting process: how to do this properly (I assume we would need 5.0 and 3.19 as well)? @ogajduse @Odilhao

@evgeni

evgeni commented Oct 14, 2026

Copy link
Copy Markdown
Member

I don't think there are any more 3.18 releases planned where this could be shipped. (But that part is a question to Odilon and Ondrej)

Whether it's a good idea to backport this to 3.18, idk. "It's probably fine" is what my brain says, but… Don't trust it too much.

@ogajduse

Copy link
Copy Markdown
Member

I don't think there are any more 3.18 releases planned where this could be shipped. (But that part is a question to Odilon and Ondrej)

Whether it's a good idea to backport this to 3.18, idk. "It's probably fine" is what my brain says, but… Don't trust it too much.

With the current workload, I do not expect any more releases within the 3.18 series.

@adamruzicka

Copy link
Copy Markdown
Contributor

is this technically viable for 3.18?

Iirc this required changes in plugins as well. We'd have to pick them all and coordinate the releases so that all of them go out at the same time

@lzap

lzap commented Oct 16, 2026

Copy link
Copy Markdown
Member

Audit and reports is owned by @andreilakatos @kmalyjur @Lukshio @MariaAga @pondrejk @rmynar @pnovotny

@evgeni

evgeni commented Oct 20, 2026

Copy link
Copy Markdown
Member

#11215 (comment) seems to indicate "no, don't pick"

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not yet reviewed Stable branch PRs that are opened against a stable branch. Usually a cherry pick

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

6 participants