Skip to content

Fixes #39803 - Stabilize hostgroup form test - #11291

Merged
ofedoren merged 1 commit into
theforeman:developfrom
jakduch:fix/hostgroup-js-timeout
Sep 25, 2026
Merged

ofedoren merged 1 commit into
theforeman:developfrom
jakduch:fix/hostgroup-js-timeout

Conversation

@jakduch

@jakduch jakduch commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

What changed

  • use a unique hostgroup name for every test attempt
  • wait for the browser redirect after submitting the form
  • verify the created record only after the redirect completes

Why

The same timeout occurred independently in #11280 and #11284. The test queried the database before synchronizing with the browser submission and reused a fixed name across retries, so a late submission could poison a later attempt with a duplicate name.

Verification

  • ruby -c test/integration/hostgroup_js_test.rb
  • git diff --check

The full Rails integration test could not be run locally because the checkout does not have the required Ruby bundle installed.

@ofedoren ofedoren left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, thanks @jakduch !

Worst case, we'll revisit this one.

@ofedoren
ofedoren merged commit bb21660 into theforeman:develop Sep 25, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants