Skip to content

Fixes #22777 - Include IPv6 DNS in dual-stack ifcfg - #11288

Merged
lzap merged 1 commit into
theforeman:developfrom
jakduch:fix/22777-ipv6-dns
Sep 29, 2026
Merged

lzap merged 1 commit into
theforeman:developfrom
jakduch:fix/22777-ipv6-dns

Conversation

@jakduch

@jakduch jakduch commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

The generic kickstart ifcfg snippet selected either IPv4 or IPv6 DNS servers. On a dual-stack interface the IPv4 subnet always won, so IPv6 resolvers were omitted.

This combines the unique resolvers from both subnets and preserves their order. A safe-mode renderer test verifies all IPv4 and IPv6 DNS entries.

@jakduch

jakduch commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

The failing Ruby 3.3 integration job is the shared HostgroupJSTest#test_0002_creates a hostgroup with provisioning data timeout, unrelated to this IPv6 template change. The same failure appeared in #11280 and #11284; #11291 (Redmine #39803) contains the shared test fix.

@lzap lzap left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be safe, we do not have any dual-stack snapshot tests.

@lzap
lzap merged commit cbf96cc into theforeman:develop Sep 29, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants