Repository navigation
G1: Fix intermediate overflow in adjoining width adjustments - #1920
Merged
Merged
Conversation
Messhias
approved these changes
Oct 14, 2026
Messhias
left a comment
Messhias
left a comment
Contributor
There was a problem hiding this comment.
Adjoining width adjustments avoid intermediate overflow. Full ci claim on the combined G1 source is enough.
Co-authored-by: Codex <noreply@openai.com>
bflatastic
force-pushed
the
codex/r65-width-finite
branch
from
October 15, 2026 20:22
e2af8ff to
9851140
Compare
Member
|
Thanks @sanyamsingh001! Merged after a full gate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjoining adjustments avoid intermediate overflow; invalid normalized or resulting factors fail without changing the document or history.
Regression coverage includes native round-trips with Undo/Redo, finite scaling and atomic rejection. Existing Width Point Edit behavior is preserved, including Shift for existing points and an unchecked adjoining option for newly created points.
Follow-up to #1814.
Validation: A full CI retry on the five-unit combined source at
a0671777passed all seven stages with 6,613 test outcomes on 2026-10-14. An earlier full-CI run on the identical source panicked in the randomizedai_mutated_save_never_panicstest; the cause remains unresolved. This five-fix batch does not claim to repair that failure. All three added Width regressions passed, including native round-trip/history and atomic rejection.