Skip to content

G1: create width points through Width Point Edit - #1814

Merged
bflatastic merged 1 commit into
storytold:mainfrom
sanyamsingh001:codex/r62-width-create
Oct 13, 2026
Merged

bflatastic merged 1 commit into
storytold:mainfrom
sanyamsingh001:codex/r62-width-create

Conversation

@sanyamsingh001

Copy link
Copy Markdown
Contributor

Double-clicking a stroked segment with the Width tool now opens Width Point Edit with sampled side widths. OK creates the point and optionally adjusts adjoining widths in one undo step. Cancel or Delete discards the pending point without changing the document or redo history.

Existing dialog controls and point editing are preserved. Regressions cover profiles, compound paths, adjoining adjustment, actual dialog events and Undo/Redo. New error messages are translated in all message-complete catalogs.

Validation: 28 focused Width tests and all seven stages of cargo xtask ci passed on the combined changes (6,222 passing tests). The headless capture exercised opening and Cancel; the original dialog PNG was visually reviewed.

Reference: Variable-width strokes.

@Messhias Messhias left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Width Point Edit can create a point on a stroked path; adjustAdjoining on new points uses sampled widths. Engine/tool/dialog tests and full ci claim are enough.

Co-authored-by: Codex <noreply@openai.com>
@bflatastic
bflatastic force-pushed the codex/r62-width-create branch from c0241ea to 0e6b2e3 Compare October 13, 2026 22:39
@bflatastic
bflatastic merged commit db0c8e9 into storytold:main Oct 13, 2026
@bflatastic

Copy link
Copy Markdown
Member

Thanks @sanyamsingh001. Merged on top of #1630, rebased on current main.

The public stroke page documents it: to create or modify a width point using the Width Point Edit dialog, double-click the stroke with the Width tool. The two PRs touched the same lines, so I merged them by hand: ui.widthPointEdit takes index?, t? and adjustAdjoining?, and Shift applies to a double-click on an existing width point, as documented (a new point opens with the box clear). The full gate (fmt, clippy, tests, assets, brands, layers, wasm) passed on the rebased stack; a double-click on a plain stroke opened the dialog with the sampled widths and OK made the point, and stroke.widthPoint.set with adjustAdjoining on a new point worked over MCP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants