Repository navigation
Conversation
…wn tree main is red on 'refuse docs/src-map.md stale vs src/': the header says 203 modules indexed and gen-src-map finds 204. One line. This is not confined to main. The gate measures a PR merged with main, so every open Python PR inherits the failure and each has to merge main and regenerate to clear it individually. Fixing it here clears it once. Stand: Echo Act IV Mini
Coverage Gate✅ No Python changes — nothing to gate (bar: 95% on changed lines). |
|
This is the second time, and the recurrence is the more useful finding.
That makes this a design gap rather than a chore. Options, roughly in increasing cost:
I have not implemented any of them: which one is right depends on whether the map is |
|
@sonichi flagging you — one generated line, clears one of the two checks currently red on main. |
qingyun-wu
left a comment
There was a problem hiding this comment.
Reviewed exact head f391296a501116ec0e4eb523bdfc43d522c756f3.
APPROVE — code-ready; no blocking finding in this generated one-line repair.
The failure exists on origin/main at 1f526886: python3 scripts/gen-src-map.py --check exits 1 with the stale-map diagnostic. The same command passes on both this PR head and GitHub's merge ref 3257110f. The full diff is only docs/src-map.md's generated count changing from 203 to 204; git diff --check and the REVIEW hardcoded-path scan also pass.
Worst-case user disruption is none: this changes documentation generated from the existing src/ tree and no runtime behavior. Hosted source-map, coverage, lint, ruff, shellcheck, and workspace gates are green. Code-ready; final merge-readiness still requires the in-progress clean-install CI and CLA status to finish green.
Reviewed by Qingyun's Personal Codex.
This one line clears TWO gates per PR, not one — measuredThe case for merging this first got stronger. From my Reproduced on a clean So the accounting for any open Python PR is:
One correction to my own earlier reasoningI had been comparing a PR's red checks against |
|
Closing: already fixed on main. And The knock-on matters more than this PR. While main's count line was one behind its tree, that single staleness made three checks fail on any PR carrying main's HEAD — That hold is now lifted — main is clean on this axis, so updating a branch no longer inherits the triple. |
main is red on its own src-map gate
mainat1f526886fails two checks. This fixes one of them:The shipped check, run on a clean
origin/mainworktree:The whole diff is the header count:
203 modules indexed.→204 modules indexed.After:
gen-src-map: docs/src-map.md is up to date.Why this is worth a PR rather than leaving to the next toucher
The gate measures a PR merged with main, so a stale map on main fails every open
Python PR regardless of what that PR changed. I hit it on two of mine today (#2741,
#2757) and cleared it on each by merging main and regenerating — which works, but is
per-PR and has to be repeated by every author. Fixing it here clears it once.
Credit for the diagnosis: Sutando-Pro identified the merged-with-main mechanism after
hitting identical symptoms on #2779 —
gen-src-mapproducing no diff in the branchalone while CI still failed.
Scope
One generated file, one line. No source, no tests, no behaviour.