Repository navigation
Conversation
jiapingW
requested review from
FlamingoPg,
FrankLeeeee,
shuaills and
sleepcoo
as code owners
October 14, 2026 03:27
3 of 6 tasks
jiapingW
force-pushed
the
codex/pr942-11-portable-recipes
branch
from
October 14, 2026 09:00
97cf2d5 to
eaa14f1
Compare
jiapingW
force-pushed
the
codex/pr942-10-consumer-dispatch
branch
from
October 14, 2026 09:00
ff15381 to
cb2ca89
Compare
jiapingW
force-pushed
the
codex/pr942-10-consumer-dispatch
branch
from
October 14, 2026 09:45
cb2ca89 to
aa8d222
Compare
jiapingW
force-pushed
the
codex/pr942-11-portable-recipes
branch
from
October 14, 2026 09:45
eaa14f1 to
e35167c
Compare
| "top_k": 16, | ||
| "ce_weight": 0.1, | ||
| "alignment_weight": 0.5, | ||
| "alignment_warmup_steps": 146, |
There was a problem hiding this comment.
Suggested change
| "alignment_warmup_steps": 146, | |
| "alignment_warmup_steps": null, |
Setting this to null lets the code-loss ramp follow the LR warmup, the default introduced in #1004.
maocheng23
force-pushed
the
codex/pr942-10-consumer-dispatch
branch
from
October 21, 2026 21:54
aa8d222 to
3aac14a
Compare
maocheng23
force-pushed
the
codex/pr942-11-portable-recipes
branch
from
October 21, 2026 21:54
e35167c to
2c146ee
Compare
This was referenced Oct 21, 2026
maocheng23
force-pushed
the
codex/pr942-11-portable-recipes
branch
from
October 21, 2026 22:10
2c146ee to
e35167c
Compare
maocheng23
force-pushed
the
codex/pr942-10-consumer-dispatch
branch
from
October 21, 2026 22:10
3aac14a to
aa8d222
Compare
jiapingW
force-pushed
the
codex/pr942-10-consumer-dispatch
branch
from
October 22, 2026 04:47
aa8d222 to
7aad50d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The newly split training capabilities need portable, checked examples with explicit storage semantics.
Modifications
Add six RTX PRO5000 PerfectBlend recipes plus causal DSpark and DSpine draft configs. Use repository/working-directory-relative paths and configurable service examples. Scheduling examples use the method-independent
two_window_bucketedandtwo_window_joint_balancedpolicies. Omit max_checkpoints in every new recipe; regression checks verify the resolved unlimited default of 0. Include config inventory/wiring checks and ignore local deployment artifacts.Stack and dependencies
Layer 10/10 split from #942. Previous layer: #966 (
codex/pr942-10-consumer-dispatch). Review the diff against this PR's base branch; it contains only this layer. The full stack index is maintained in #942.Actual prerequisites: #958, #959, #960, #961, #963, #965, #966
The linear stack is the review/merge order. Model-specific optimizations are independently opt-in; the projection-checkpointing and attention layers expose shared capabilities. When merging a lower PR with squash, restack the remaining branches before merging them so already-reviewed commits do not reappear. The repository GPU test workflow only auto-runs for PRs targeting main; upper layers need that CI run when retargeted, while lint runs for all PRs.
Source: #942 at
211b87fc7d707e3a628cb95de5c73340af863c04, split onto mainfdcc2eddf1b56b5b24a5a15d3abcb366adfeb5aa. The original branch is preserved.Accuracy Test
e35167c693d6: 135 targeted regression tests passed, covering reference dispatch, capture metadata, configuration, recipes, and package architecture on H20 (Python 3.11.12 / PyTorch 2.13.0+cu130).Layer command (run in this branch's checkout,
PYTHONPATH=.):Qwen3 tokenizer regressions reuse the cached official tokenizer with
HF_HUB_OFFLINE=1andHF_HUB_CACHEpointing to that cache. No training job was launched.Benchmark & Profiling
No new end-to-end throughput or downstream accuracy benchmark was run for this split. Model-side tests exercise numerical parity and gradients; historical measurements remain in #942 with their original scope and caveats.
Checklist