Repository navigation
[DSpine 4/4] perf(dspine): add Liger and streamline objective execution - #1007
Closed
maocheng23 wants to merge 1 commit into
Closed
maocheng23 wants to merge 1 commit into
maocheng23 wants to merge 1 commit into
Conversation
maocheng23
requested review from
FlamingoPg,
FrankLeeeee,
shuaills and
sleepcoo
as code owners
October 21, 2026 21:55
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DSpine can reuse the existing optional Liger kernels and avoid redundant objective work during accumulation prepasses. These execution optimizations are separated from the architecture, objective and runtime integration.
Changes
model.use_liger_kernelthrough the explicit RMSNorm/SwiGLU kernel factories, preserving checkpoint keys and avoiding global Transformers patching.Liger remains opt-in. The flattened projection and cheaper prepass are the DSpine implementation paths already present in original #965. Floating-point rounding may differ across GEMM layouts; no universal speedup is claimed.
Stack
DSpine 4/4, extracted from original #965 (
b32657405d7df33f049cc638da3d739c240e82b4), within workstream 8 of #942.Order: #965 -> #1005 -> #1006 -> this PR -> #966 -> #967. Base: #1006 /
codex/pr965-03-training; review only the base-relative diff.This PR's complete file tree is identical to the original #965 tree. No tests or behavior were removed by the split. #966 and #967 are restacked on top with their respective file trees also unchanged. Original tips remain on backup branches; original authorship is preserved. The adapted integration originates in #942 and credits #917; this does not close #917.
Validation