Repository navigation
Conversation
jiapingW
requested review from
FlamingoPg,
FrankLeeeee,
shuaills and
sleepcoo
as code owners
October 14, 2026 03:27
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #963. Domino and DSpark now share
training.cache_vocab_projection,training.flatten_vocab_projection, and the vocabulary projection helper. #965 has been retargeted to #963. This branch is retained for reference.Motivation
DSpark vocabulary projection can use 2-D GEMMs and retain frozen results across objective recomputation.
Modifications
Add separate opt-in flatten/cache flags, DSpark-only validation, builder wiring, and explicit Liger kernel injection. Compare losses, metrics, all gradients, checkpoint keys, and resume contracts. Flattening can change floating-point rounding; caching trades memory for recomputation.
Stack and dependencies
Layer 8/11 split from #942. Previous layer: #963 (
codex/pr942-07-domino-optimizations). Review the diff against this PR's base branch; it contains only this layer. The full stack index is maintained in #942.Actual prerequisites: #960, #962
The linear stack is the review/merge order. Model-specific optimizations are independently opt-in; the projection-checkpointing and attention layers expose shared capabilities. When merging a lower PR with squash, restack the remaining branches before merging them so already-reviewed commits do not reappear. The repository GPU test workflow only auto-runs for PRs targeting main; upper layers need that CI run when retargeted, while lint runs for all PRs.
Source: #942 at
211b87fc7d707e3a628cb95de5c73340af863c04, split onto mainfdcc2eddf1b56b5b24a5a15d3abcb366adfeb5aa. The original branch is preserved.Accuracy Test
46c322216e4b: 5 tests run, zero failures/errors on H20 with Python 3.11.12 / PyTorch 2.13.0+cu130.97cf2d5065c8: 401 integration tests run, zero failures/errors; 2 skipped. Modules run in fresh processes because the existing checkpoint tests retain a process-global NCCL group that interferes with later CPU/Gloo tests. This is targeted regression coverage, not a full-suite or downstream task-accuracy claim.Layer command (run in this branch's checkout,
PYTHONPATH=.):Qwen3 tokenizer regressions reuse the cached official tokenizer with
HF_HUB_OFFLINE=1andHF_HUB_CACHEpointing to that cache. No training job was launched.Benchmark & Profiling
No new end-to-end throughput or downstream accuracy benchmark was run for this split. Model-side tests exercise numerical parity and gradients; historical measurements remain in #942 with their original scope and caveats.
Checklist