Cjl/giga state hash by cody-littley · Pull Request #4341 · sei-protocol/sei-chain

cody-littley · 2026-09-25T14:36:54Z

New methods on StateDB for getting recent hashes, and for signaling when safe to delete
HashVault internalized inside StateDB
HashVault no longer permits gaps in blocks
HashVault's "crash on equivocation" feature is now optional via configuration
StateDB setup/recovery now must consider HashVault

cursor · 2026-09-25T14:37:21Z

PR Summary

High Risk
Changes core state open/recovery, equivocation handling, and durable hash history; misconfiguration or recovery edge cases could prevent startup or weaken slash protection.

Overview
Giga StateDB now owns the Pebble hash vault as SC’s first hash listener, records FlatKV block hashes on commit, and exposes GetBlockHeight / GetBlockHash on the StateDB interface. Open and recovery were reworked: NewStateDB takes HashVaultConfig and an optional rollbackTo, with offline recoverStores planning rewinds when the vault is empty or behind SC (including configurable hash-vault-empty-rollback-blocks, default 1000). Rollbacks no longer truncate the vault; re-execution is checked against stored hashes. An empty WAL requires SC, SS, and the vault to already agree.

Operator config replaces the old unsafe kill switch. hash-vault-disabled-unsafe is gone in favor of hash-vault-halt-on-mismatch (default: log and replace recorded hashes) and hash-vault-empty-rollback-blocks. The vault refuses height gaps, can Get / Reset / accept mismatches without halting, and joins the storage garbage collector prune set. Block hash plumbing uses uint64 across listeners and lthash.BlockHash. GigaRouter no longer configures hash vault directly; Autobahn storage wiring passes node config into GigaStorageConfig.HashVaultConfig.

^{Reviewed by Cursor Bugbot for commit e7df1c3. Bugbot is set up for automated code reviews on this repo. Configure here.}

cursor

Stale Bugbot comment from a previous run.

github-actions · 2026-09-25T15:07:41Z

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`✅ passed`	`✅ passed`	`✅ passed`	Sep 29, 2026, 4:15 PM

cursor

Stale Bugbot comment from a previous run.

seidroid

The PR moves the hash vault into the giga StateDB and makes it record FlatKV state checksums. Two problems block it: existing Autobahn nodes keep the same vault directory, which still holds the old app hashes, so they will fail to open on upgrade; and the app hash sent to AppQC voting is no longer checked for equivocation before it is published.

Findings: 2 blocking | 2 non-blocking | 3 posted inline

Blockers

None at the file/PR level.
2 blocking issue(s) flagged inline on specific lines.

Non-blocking

[suggestion] hash-vault-disabled-unsafe is removed with no deprecation policy. Viper ignores unknown keys, so an operator who set it to true gets a node that silently runs the vault with halting on. Log a startup warning when the old key is present, or add a release note pointing to hash-vault-halt-on-mismatch = false (see REVIEW_GUIDELINES §5).
1 suggestion(s)/nit(s) flagged inline on specific lines.

codecov · 2026-09-25T15:11:48Z

Codecov Report

❌ Patch coverage is 78.64924% with 98 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.48%. Comparing base (398513d) to head (e7df1c3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
sei-db/state_db/giga/state_db_recovery.go	76.47%	24 Missing ⚠️
sei-db/state_db/sc/hashvault/pebble_hashvault.go	80.18%	21 Missing ⚠️
sei-db/state_db/giga/state_db.go	79.76%	17 Missing ⚠️
sei-db/state_db/giga/state_db_replay.go	76.27%	14 Missing ⚠️
...state_db/sc/hashvault/pebble_hashvault_rollback.go	66.66%	9 Missing ⚠️
giga/evmonly/memory_store.go	0.00%	6 Missing ⚠️
sei-db/state_db/giga/state_db_hash_vault.go	76.19%	5 Missing ⚠️
sei-db/config/giga_config.go	80.00%	1 Missing ⚠️
sei-db/state_db/sc/flatkv/snapshot.go	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4341      +/-   ##
==========================================
- Coverage   67.74%   67.48%   -0.27%     
==========================================
  Files        2174     2120      -54     
  Lines      168819   164708    -4111     
==========================================
- Hits       114374   111156    -3218     
+ Misses      54436    53543     -893     
  Partials        9        9

Flag	Coverage Δ
sei-chain-pr	`82.59% <83.72%> (?)`
sei-db	`74.81% <ø> (ø)`
sei-db-state-db	`?`
sei-db-state-db-pr	`83.69% <78.12%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
config/tendermintbase/tendermintbase.go	`100.00% <100.00%> (ø)`
giga/metrics/autobahn_loop.go	`92.59% <ø> (ø)`
sei-db/bootstrap/recovery.go	`88.65% <100.00%> (+0.48%)`	⬆️
sei-db/bootstrap/storage_manager.go	`80.00% <100.00%> (ø)`
sei-db/state_db/sc/composite/hashlog.go	`56.25% <100.00%> (ø)`
sei-db/state_db/sc/composite/store.go	`79.06% <100.00%> (ø)`
sei-db/state_db/sc/flatkv/finalization_manager.go	`87.09% <100.00%> (ø)`
sei-db/state_db/sc/flatkv/lthash/hash_engine.go	`83.33% <100.00%> (ø)`
.../state_db/sc/flatkv/lthash/hash_engine_messages.go	`61.53% <ø> (ø)`
sei-db/state_db/sc/flatkv/store.go	`86.98% <100.00%> (+3.08%)`	⬆️
... and 20 more

... and 125 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

wen-coding · 2026-09-25T16:18:08Z

 	}
+	// PLACEHOLDER: keeps the newest placeholderBlockHashRetention blocks' hashes. A real threshold, set by
+	// what giga execution needs block hashes for, should be wired in here.
+	if err := stateStore.PruneBlockHashesBelow(blockHashesPrunedBelow(req.Context.Number)); err != nil {


I'm a bit confused how we see things work. Why the prune signal comes from execution?

I thought our agreed API in March offsite was:

consensus prepares the blocks ready for execution, and notifies storage (by saving into BlockDB)

storage triggers execution whenever it sees fit

after execution, storage notifies consensus which AppHash is ready for voting

then consensus notifies storage which ones are ready for pruning
?

Did I remember that correctly?

Based on our discussion (offline), I've changed things in the following way:

Pruning methods are now removed from public API

HashVault now determines its retention window via the rollback window and the lookback window, just like other stores

A hard requirement: it is now unsafe to allow the lookback window config to be smaller than the number of blocks in an epoch. Not enforced in code, we may enforce a minimum in code at a later date.

wen-coding · 2026-09-25T19:52:16Z

+}
+
+// GetBlockHash returns the hash the hash vault holds for blockNumber.
+func (s *StateDB) GetBlockHash(blockNumber uint64) ([32]byte, gigatypes.BlockHashStatus, error) {


Hmm, I thought we said GetAppHash. If GetBlockHash succeeds means this blocks has executed and the states are persisted in storage that works as well, but the consensus protocol might need AppHash to send out AppVote.

Active discussion on this on slack, will continue the discussion there.

cursor

Stale Bugbot comment from a previous run.

cursor

Cursor Bugbot has reviewed your changes using default effort and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit bfb833b. Configure here.}

cody-littley · 2026-09-29T16:20:23Z

@seidroid review

seidroid

This PR moves the hash vault into the giga StateDB, where it records FlatKV state checksums. It adds recovery and refill logic and includes good tests. Nothing blocks merge, but two points need an explicit decision or a small fix: the AppQC-published app hash no longer has an equivocation guard, and legacy app hashes stay in the reused vault directory.

Findings: 0 blocking | 2 non-blocking | 2 posted inline

Blockers

None at the file/PR level.

Non-blocking

None at the file/PR level.
2 suggestion(s)/nit(s) flagged inline on specific lines.

Superseded: latest AI review found no blocking issues.

Cody Littley added 3 commits September 24, 2026 13:55

refactor giga state store for hashes

e09411d

revert hashvault changes

0120d78

handle some edge cases

812e878

cody-littley self-assigned this Sep 25, 2026

cody-littley requested review from codchen, philipsu522, shemnon, wen-coding and yzang2019 as code owners September 25, 2026 14:36

cursor Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread sei-db/state_db/giga/state_db_recovery.go

Merge branch 'main' into cjl/giga-state-hash

1bc64c4

cursor Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread sei-db/config/giga_config.go

seidroid Bot previously requested changes Sep 25, 2026

View reviewed changes

Comment thread sei-db/config/giga_config.go

Comment thread sei-tendermint/internal/p2p/giga_router_common.go

Comment thread sei-db/state_db/giga/types/state_db.go

wen-coding mentioned this pull request Sep 25, 2026

Derive Autobahn AppHash from the state-store hash callback (CON-444) #4306

Draft

2 of 3 tasks

wen-coding reviewed Sep 25, 2026

View reviewed changes

wen-coding mentioned this pull request Sep 25, 2026

Backport giga-1: Add Giga fetch/serve and BlockDB prune metrics (CON-438) #4331

Merged

wen-coding reviewed Sep 25, 2026

View reviewed changes

cody-littley added the non-app-hash-breaking label Sep 28, 2026

remove pruning API

1e059dc

cursor Bot reviewed Sep 28, 2026

View reviewed changes

Comment thread sei-db/state_db/sc/hashvault/hashvault_config.go

Merge branch 'main' into cjl/giga-state-hash

bfb833b

cursor Bot reviewed Sep 28, 2026

View reviewed changes

Comment thread sei-db/state_db/giga/state_db_recovery.go

Comment thread sei-db/config/giga_config.go

Comment thread cmd/seid/cmd/legacy_config_fuzz_test.go Outdated

Cody Littley added 2 commits September 29, 2026 10:54

Merge branch 'main' into cjl/giga-state-hash

88864b1

fix broken test

e7df1c3

seidroid Bot approved these changes Sep 29, 2026

View reviewed changes

Comment thread sei-tendermint/internal/p2p/giga_router_common.go

Comment thread sei-db/config/giga_config.go

cody-littley marked this pull request as draft September 30, 2026 15:59

Conversation

cody-littley commented Sep 25, 2026

Uh oh!

cursor Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

seidroid Bot left a comment

Choose a reason for hiding this comment

Blockers

Non-blocking

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wen-coding Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

cody-littley Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

wen-coding Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

cody-littley Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cody-littley commented Sep 29, 2026

Uh oh!

seidroid Bot left a comment

Choose a reason for hiding this comment

Blockers

Non-blocking

Uh oh!

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cursor Bot commented Sep 25, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

github-actions Bot commented Sep 25, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

codecov Bot commented Sep 25, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading