Repository navigation
Backport giga-1: Add Giga fetch/serve and BlockDB prune metrics (CON-438) - #4331
Conversation
## Summary
- Add `tendermint_autobahn_blockstore_prune_watermark` at the BlockDB
prune choke point (actual floor after clamp, seeded on open).
- Add `tendermint_p2p_giga_fetch{resource,reason}` for GetBlock,
FullCommitQC, AppQC, CommitQC, and lane-proposal client paths (`ok`,
`unavailable`, `open_stream`, `send`, `receive`, `decode`, `process`,
`wrong_lane`).
- Add `tendermint_p2p_giga_serve{resource,reason}` on GetBlock
empty/error replies (`pruned`, `not_found`, `store_error`) so a lagging
node's `unavailable` can be joined with a tip node's `pruned`.
## Test plan
- [x] `GOWORK=off go test --count=0 ./sei-tendermint/autobahn/blockstore
./sei-tendermint/internal/p2p/giga
./sei-tendermint/internal/autobahn/data`
- [x] `scripts/ramtest.sh ./sei-tendermint/autobahn/blockstore/...
./sei-tendermint/internal/p2p/giga/...
./sei-tendermint/internal/autobahn/data/...`
- [x] On a giga testnet node, scrape Prometheus and confirm
`prune_watermark`, `fetch`, and `serve` series appear; compare a lagging
node's `fetch{resource="block",reason="unavailable"}` with a tip node's
`serve{resource="block",reason="pruned"}` and
`next_block{stage="receive"}`.
Made with [Cursor](https://cursor.com)
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
(cherry picked from commit b9f0e8f)
PR SummaryLow Risk Overview Blockstore: exposes Giga P2P: adds Reviewed by Cursor Bugbot for commit 5d95f77. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
There was a problem hiding this comment.
This is a clean backport of #4329 to giga-1. It adds counters for Giga fetch and serve outcomes, plus a BlockDB prune-watermark gauge. The dependencies it uses (utils.Clamp, BlockDB.GetPruneWatermark, the tmprometheus vec types) exist on this branch. The instrumentation leaves control flow unchanged and has test coverage; I found nothing to block the merge.
Findings: 0 blocking | 0 non-blocking | 0 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- None at the file/PR level.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## giga-1 #4331 +/- ##
===========================================
+ Coverage 65.55% 79.32% +13.76%
===========================================
Files 2081 12 -2069
Lines 157460 827 -156633
===========================================
- Hits 103222 656 -102566
+ Misses 54097 171 -53926
+ Partials 141 0 -141
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
What is in giga-1 that's not on main which makes us wnat to backport this @wen-coding @philipsu522 ? |
All the panic fixes? Without them the giga testnet will die. I have a plan to replace the evmonly cursor persistence with #4306, but it has a dependency on #4341, so I'm fine if we just persist the cursors for now. |
All good discussed in DM, happy to land anything in giga-1 as long as it is a backport from main 🙌 |
Backport of #4329 to
giga-1.