Repository navigation
chore(deps): tighten the jsdom cap to >=27, measured not assumed - #429
Merged
Merged
Conversation
The jsdom hold landed in #426 with `versions: ['>=28']`, on the assumption that the accname whitespace regression began in 28. That assumption was wrong and the cap let Dependabot raise #427 (25.0.1 -> 27.4.0). #427 failed jobs 4 and 6 with EXACTLY the same five tests as the jsdom 30 PR did - T-UX-145c, T-AVREV-009a, T-PHONE-005a, T-PHONE-005b and T-TOOLBAR-002b - while the other ten jobs, including 9 . test:a11y (Playwright, real browsers), passed. Same signature, same conclusion: the markup is right and jsdom is wrong, from 27 onward. 26 remains known good, so the cap stays as small as the evidence supports. The runbook paragraph is corrected in place with the superseded sentence struck through below it, per the F-001 rule. Closes #427 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c372e6ba-4c3f-419a-9f77-b9e23adfc874
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The jsdom hold landed in #426 with
versions: ['>=28']. That bound was anassumption about where the accname whitespace regression began, not a
measurement — and it was wrong. The gap let Dependabot immediately raise #427
(
jsdom25.0.1 → 27.4.0).#427 failed jobs
4 · test:unit + coverageand6 · test:webwith exactlythe same five tests as the jsdom 30 PR:
T-UX-145c— the trigger counts active filter values but not the search termT-AVREV-009a— two labelled sections, each row with its fact, as-of date and answersT-PHONE-005a— every chip is a native checkbox that writes the URLT-PHONE-005b— Reset clears every filter but keeps the search textT-TOOLBAR-002b— an active filter is shown by count and state, but search alone is notTest Files 4 failed | 104 passed (108)·Tests 5 failed | 1619 passed (1624)⚠ The other ten jobs passed on that same commit, including
9 · test:a11y— Playwright against real browsers. That is the identicaljsdom-red / real-browser-green split documented in #426, and it carries the
identical conclusion: the markup in
FilterBar.tsxis correct and thesimulation is not.
FilterBar.tsxis therefore unchanged here.So the first bad major is 27, not 28. jsdom 26 remains known good (the
upstream report reproduces clean on 26.1.0), so the cap stays as small as the
evidence supports.
Linked issue / task
Closes #427. Corrects the cap introduced in #426 (which closed #405).
Type of change
infra/**) —.github/dependabot.ymlTesting done
Dependabot configuration and documentation only; no acceptance criterion
changes, so no AC → test mapping applies (
specs/testing.md§10).Gates run locally on this branch:
npm run format:checkpython -c "import yaml; ..."(parse.github/dependabot.yml)jsdomnow parses as{'versions': ['>=27']}; all 8 ignore entries intactThe evidence for the bound itself is CI on #427, linked above
(run
37818405831): 10 jobs green, jobs 4 and 6 red on the 5 named tests.T-INFRA-018dreads onlypackage.json,.nvmrcandDockerfile, sochanging a
dependabot.ymlignore bound does not affect it.Checklist
T-MIG-001). — no migrations.dependabot.ymlcomment and runbook §5 carry the corrected bound first, with the superseded>=28sentence struck through below it.