Repository navigation
build(deps-dev): bump jsdom from 25.0.1 to 30.1.2 - #405
dependabot[bot] wants to merge 2 commits into
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
|
Dependabot can't authenticate to a private package registry. Because of this, Dependabot cannot update this pull request. |
|
@dependabot recreate |
|
Dependabot can't authenticate to a private package registry. Because of this, Dependabot cannot update this pull request. |
…ry (#416) `package-lock.json` carried 442 `resolved` URLs naming `ms-feed-*.pkgs.visualstudio.com`, the internal Microsoft proxy feed. They entered through a local `npm install` on a Microsoft-managed machine, which is exactly the hazard `docs/runbooks/update-dependencies.md` section 6 warns about. The consequence was NOT cosmetic. Dependabot treats that host as a private registry it has no credential for, and refuses the whole update: Dependabot can't authenticate to a private package registry. Because of this, Dependabot cannot update this pull request. So #403 (openai), #404 (@azure/storage-blob) and #405 (jsdom) could not rebase or recreate, and every future bump touching those packages would have failed the same way. CI never showed it: the `1es-public` feed is anonymously readable, so GitHub runners install from it happily and all 13 jobs stay green. The only symptom was `Dependabot Updates` workflow runs ending in `failure`. The change is a host-prefix rewrite and nothing else: https://ms-feed-N.pkgs.visualstudio.com/1es-public/_packaging/npm-public/npm/registry/<pkg>/-/<file>.tgz -> https://registry.npmjs.org/<pkg>/-/<file>.tgz No `npm install` was run, so no version moved and no transitive dependency changed. No `integrity` hash changed either - it is the same tarball at its public address, so the recorded hash stays valid. The sha1/sha512 populations are identical before and after (412 / 135), which is the point: regenerating the lockfile here would have DOWNGRADED sha512 entries to sha1 (section 6), so this deliberately does not do that. Verified: every one of the 884 changed lines is a `resolved` line, the file still parses, and `check:deps` + `check:licences` pass. Docs: adds runbook section 6a for the lockout and its repair, and corrects the `sha1-` / `ms-feed-*` correlation in section 6 in place - sha1 hashes and public URLs now coexist, so that correlation is no longer a valid test. Unblocks #403, #404, #405. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c372e6ba-4c3f-419a-9f77-b9e23adfc874
|
@dependabot recreate |
aa45f82 to
c19abfb
Compare
Blocked by vitest, not by anything in this repo — hold until vitest ≥ 5.0.3This bump is correct but ordered wrong. 10 web tests fail across the image-ingest ⚠ The failing frame is Vitest's, not ours. jsdom 30.1 moved the Fixed upstream in vitest v5.0.3:
This repo is on vitest 5.0.0 ( Required order
⚠ Do not "fix" this by mocking ⚠ Equally, do not pin Leaving this open and blocked rather than closing it, so the ordering is not rediscovered. Context: the reason this PR could not be rebased or recreated for the past week was a |
|
A newer version of jsdom exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
Bumps [jsdom](https://github.com/jsdom/jsdom) from 25.0.1 to 30.1.2. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v25.0.1...v30.1.2) --- updated-dependencies: - dependency-name: jsdom dependency-version: 30.1.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
79f70a0 to
1102111
Compare
Generated from the updated lockfile by .github/workflows/dependabot-notices.yml. Dependabot changes the installed tree but cannot run the repo script that regenerates this file, so every bump would otherwise fail check:licences and T-LICENSE-001c for a reason unrelated to the dependency being bumped.
…426) jsdom >= 28 drops the separator space between a text node and an adjacent inline element when computing an accessible name, so `All<span class="sr-only"> statuses</span>` in FilterBar.tsx is named "Allstatuses" and the filters trigger is named "Filters4 active". accname 1.2 step 2I says to append with a space, and Chrome, Firefox and Safari all do. The markup is correct and CI proves it: on the same commit where `4 - test:unit + coverage` and `6 - test:web` went red (T-PHONE-005a, T-PHONE-005b, T-UX-145c, T-TOOLBAR-002b, T-AVREV-009a), the Playwright real-browser job `9 - test:a11y` passed. Reshaping FilterBar.tsx to satisfy jsdom would make the real accessible name worse in order to make a non-conformant simulation agree. No dependency bump clears this. The space logic lives in dom-accessibility-api, not jsdom; its latest release (0.7.1) contains no fix, and @testing-library/dom pins ^0.5.9 so 0.7.x is unreachable. Upstream jsdom#4091 is closed not_planned on process grounds (the repro used a third-party library), not on the merits. Capped by version at >=28 rather than by update-type, like @types/node: 26 is known good, so the cap stays as small as the evidence supports. Also corrects in place the now-false dependabot.yml comment claiming jsdom carries no ignore, keeping the superseded text struck through below it. Note: the separate `_bytes` failure that first blocked PR #405 was a real vitest/jsdom incompatibility and is FIXED, not held - vitest 5.0.3 (#420) resolved it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c372e6ba-4c3f-419a-9f77-b9e23adfc874
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
…-011) (#431) Closes #417. main once carried 442 "resolved" URLs naming ms-feed-*.pkgs.visualstudio.com, written by a local `npm install` on a Microsoft-managed machine. That both published an internal host from a public repository and SILENTLY DISABLED dependabot for every affected package -- #403/#404/#405 could neither rebase nor recreate for nine days -- while all twelve CI jobs stayed green, because the 1es-public feed is anonymously readable. Repaired in #416; this closes the three open questions #417 left. Q1, a CI gate: tools/check-lockfile-registry.mjs + npm run check:lockfile, asserted by T-CI-011 in tests/infra/lockfileRegistry.spec.ts and run in the "3 . audit" job. An ALLOW-list of registry.npmjs.org, not an ms-feed-* denylist: the next proxy to leak in will have a different hostname. It keys on the URL, never on sha1- -- after #416 the two populations no longer correlate (~412 sha1- hashes, zero proxy URLs), so a sha1- check would fail the clean tree, which is why runbook section 6 still declines that one. Q2, other leaks of the internal host: the same gate fails on any committed .npmrc, whatever it contains. .npmrc is not gitignored, so one would be a real and visible risk; machine-specific registry config belongs in ~/.npmrc. Q3, the local-install story: runbook sections 2 and 4 both instructed a local `npm install`, which is the action that CAUSES this defect and contradicted sections 6/6a. Both corrected in place with the superseded text struck through below (F-001 rule). Section 6a's "No CI gate" conclusion is likewise corrected: it was sound for sha1- and wrongly extended to the resolved URL. Verified end-to-end against the real contamination: pointed at the lockfile of a branch that still carries it, the gate reports 447 entries across four hosts collapsed to four lines, and exits 1. WARNING for anyone with in-flight branches: 194 of 198 local branches in this clone are still contaminated and will now fail CI. Apply the section 6a host rewrite before pushing; it needs no install, no version change and no integrity change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c372e6ba-4c3f-419a-9f77-b9e23adfc874
Bumps jsdom from 25.0.1 to 30.1.2.
Release notes
Sourced from jsdom's releases.
... (truncated)
Commits
a23bfb730.1.264a75d2Update dependencies and dev dependencies7bf9653Invalidate styles after CSSOM and control state changesfe9009cUpdate focused area handlinga8d28b3Release windows retained by stylesheet parsing05a2c01Deduplicate generated CSS property metadata1efa190Reduce generated CSS property dataa372e12Avoid Document named-property rebuilds after irrelevant tree mutationsb2cd235Update css-color0542d2bRelease idle MutationObserver bookkeepingMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for jsdom since your current version.
Install script changes
This version modifies
preparescript that runs during installation. Review the package contents before updating.