Skip to content

Do not checkout Cargo for bootstrap tests - #164857

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Kobzol:bootstrap-no-cargo-checkout
Oct 25, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Kobzol:bootstrap-no-cargo-checkout

Conversation

@Kobzol

@Kobzol Kobzol commented Oct 24, 2026

Copy link
Copy Markdown
Member

The comment claimed that some tests require it, but I suspect that hasn't been true for some time.

Noted by @RalfJung in #164837.

r? jieyouxu

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 24, 2026
@rustbot

rustbot commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@jieyouxu jieyouxu left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

📌 Commit cbf6e4a has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 24, 2026
…, r=jieyouxu

Do not checkout Cargo for bootstrap tests

The comment claimed that some tests require it, but I suspect that hasn't been true for some time.

Noted by @RalfJung in rust-lang#164837.

r? jieyouxu
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 24, 2026
…, r=jieyouxu

Do not checkout Cargo for bootstrap tests

The comment claimed that some tests require it, but I suspect that hasn't been true for some time.

Noted by @RalfJung in rust-lang#164837.

r? jieyouxu
rust-bors Bot pushed a commit that referenced this pull request Oct 24, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #164028 (Add a future incompat warning for #[no_link])
 - #164834 (miri subtree update)
 - #164849 (Use the span of the doctest code block fence for figuring out the line number)
 - #164869 (rustc_codegen_gcc subtree update)
 - #157123 (library: optimize truncate method)
 - #159916 (Optimize `str.escape_default().to_string()`)
 - #164857 (Do not checkout Cargo for bootstrap tests)
 - #164872 (cg_llvm: clarify Send / Sync story for modules)
jhpratt added a commit to jhpratt/rust that referenced this pull request Oct 25, 2026
…, r=jieyouxu

Do not checkout Cargo for bootstrap tests

The comment claimed that some tests require it, but I suspect that hasn't been true for some time.

Noted by @RalfJung in rust-lang#164837.

r? jieyouxu
rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026
Rollup of 11 pull requests

Successful merges:

 - #161362 ( rustdoc: Correctly handle reexports when --document-private-items is used)
 - #162808 (Enable `--generate-link-to-definition` rustdoc option on std docs)
 - #164834 (miri subtree update)
 - #164869 (rustc_codegen_gcc subtree update)
 - #157123 (library: optimize truncate method)
 - #159916 (Optimize `str.escape_default().to_string()`)
 - #164508 (ping me for layout invariant changes)
 - #164758 (Update dependency jinja2 to v3.1.6 [SECURITY])
 - #164857 (Do not checkout Cargo for bootstrap tests)
 - #164872 (cg_llvm: clarify Send / Sync story for modules)
 - #164881 (Add FIXME comments to `from_ascii_bytes_radix_impl`)
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Oct 25, 2026
…, r=jieyouxu

Do not checkout Cargo for bootstrap tests

The comment claimed that some tests require it, but I suspect that hasn't been true for some time.

Noted by @RalfJung in rust-lang#164837.

r? jieyouxu
rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026
Rollup of 12 pull requests

Successful merges:

 - #164834 (miri subtree update)
 - #164869 (rustc_codegen_gcc subtree update)
 - #157123 (library: optimize truncate method)
 - #159916 (Optimize `str.escape_default().to_string()`)
 - #164508 (ping me for layout invariant changes)
 - #164758 (Update dependency jinja2 to v3.1.6 [SECURITY])
 - #164802 (Migrate stable-specific run-make tests to UI tests)
 - #164836 (Add regression test for #162109)
 - #164857 (Do not checkout Cargo for bootstrap tests)
 - #164868 (Fix skipping library build with `--keep-stage[-std]`)
 - #164872 (cg_llvm: clarify Send / Sync story for modules)
 - #164881 (Add FIXME comments to `from_ascii_bytes_radix_impl`)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 25, 2026
…, r=jieyouxu

Do not checkout Cargo for bootstrap tests

The comment claimed that some tests require it, but I suspect that hasn't been true for some time.

Noted by @RalfJung in rust-lang#164837.

r? jieyouxu
rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - #161362 ( rustdoc: Correctly handle reexports when --document-private-items is used)
 - #164764 (Test(lib/sync): Fix `test_rwlock_max_readers` for 32bit architectures)
 - #164869 (rustc_codegen_gcc subtree update)
 - #157123 (library: optimize truncate method)
 - #159916 (Optimize `str.escape_default().to_string()`)
 - #164508 (ping me for layout invariant changes)
 - #164758 (Update dependency jinja2 to v3.1.6 [SECURITY])
 - #164836 (Add regression test for #162109)
 - #164857 (Do not checkout Cargo for bootstrap tests)
 - #164868 (Fix skipping library build with `--keep-stage[-std]`)
 - #164872 (cg_llvm: clarify Send / Sync story for modules)
 - #164881 (Add FIXME comments to `from_ascii_bytes_radix_impl`)
rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026
…uwer

Rollup of 20 pull requests

Successful merges:

 - #160404 (fd-views: AsRef<File>&Co. for BorrowedFd)
 - #161362 ( rustdoc: Correctly handle reexports when --document-private-items is used)
 - #163769 (reborrow: Fix various ICEs related to auto reborrowing of user-space types)
 - #164764 (Test(lib/sync): Fix `test_rwlock_max_readers` for 32bit architectures)
 - #164860 (std::fs: read interrupted by a signal, read_buf_exact_at reports EOF.)
 - #164869 (rustc_codegen_gcc subtree update)
 - #157123 (library: optimize truncate method)
 - #159916 (Optimize `str.escape_default().to_string()`)
 - #163510 (process: Improve the output of `Debug` for `ExitStatus` on Unix)
 - #164508 (ping me for layout invariant changes)
 - #164758 (Update dependency jinja2 to v3.1.6 [SECURITY])
 - #164816 (Take the colon span into account for struct field initializers)
 - #164836 (Add regression test for #162109)
 - #164846 (Remove contradictory inequalities from overflow safety docs)
 - #164857 (Do not checkout Cargo for bootstrap tests)
 - #164868 (Fix skipping library build with `--keep-stage[-std]`)
 - #164872 (cg_llvm: clarify Send / Sync story for modules)
 - #164880 (Add context span showing item that can't be annotated)
 - #164881 (Add FIXME comments to `from_ascii_bytes_radix_impl`)
 - #164884 (Windows: bounds-check the reparse point name in `read_link`)
rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026
…uwer

Rollup of 20 pull requests

Successful merges:

 - #160404 (fd-views: AsRef<File>&Co. for BorrowedFd)
 - #161362 ( rustdoc: Correctly handle reexports when --document-private-items is used)
 - #163769 (reborrow: Fix various ICEs related to auto reborrowing of user-space types)
 - #164764 (Test(lib/sync): Fix `test_rwlock_max_readers` for 32bit architectures)
 - #164860 (std::fs: read interrupted by a signal, read_buf_exact_at reports EOF.)
 - #164869 (rustc_codegen_gcc subtree update)
 - #157123 (library: optimize truncate method)
 - #159916 (Optimize `str.escape_default().to_string()`)
 - #163510 (process: Improve the output of `Debug` for `ExitStatus` on Unix)
 - #164508 (ping me for layout invariant changes)
 - #164758 (Update dependency jinja2 to v3.1.6 [SECURITY])
 - #164816 (Take the colon span into account for struct field initializers)
 - #164836 (Add regression test for #162109)
 - #164846 (Remove contradictory inequalities from overflow safety docs)
 - #164857 (Do not checkout Cargo for bootstrap tests)
 - #164868 (Fix skipping library build with `--keep-stage[-std]`)
 - #164872 (cg_llvm: clarify Send / Sync story for modules)
 - #164880 (Add context span showing item that can't be annotated)
 - #164881 (Add FIXME comments to `from_ascii_bytes_radix_impl`)
 - #164884 (Windows: bounds-check the reparse point name in `read_link`)
@rust-bors
rust-bors Bot merged commit a7c8318 into rust-lang:main Oct 25, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 25, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026
Rollup merge of #164857 - Kobzol:bootstrap-no-cargo-checkout, r=jieyouxu

Do not checkout Cargo for bootstrap tests

The comment claimed that some tests require it, but I suspect that hasn't been true for some time.

Noted by @RalfJung in #164837.

r? jieyouxu
@Kobzol
Kobzol deleted the bootstrap-no-cargo-checkout branch October 25, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants