[the8472]

View all comments

tracking issue: #160402

This uses #[unstable_feature_bound] so the trait impls are not insta-stable, so no FCP needed yet. But they're infectious to callers which means we currently can't dogfood the added API in std itself.

[rustbot]

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: @ChrisDenton, libs
• @ChrisDenton, libs expanded to 13 candidates
• Random selection from 6 candidates

[jhpratt]

Let me know when CI is passing and I'll take a look.

[the8472]

@rustbot ready

[jhpratt]

@bors r+

[rust-bors]

📌 Commit 335e8c8 has been approved by jhpratt

It is now in the queue for this repository.

[rust-bors]

⌛ Testing commit 335e8c8 with merge 0e257b5...

Workflow: https://github.com/rust-lang/rust/actions/runs/39019991801

[rust-bors]

This pull request was unapproved.

This PR was contained in a rollup (#164456), which was unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

• https://github.com/rust-lang/rust/actions/runs/39019991801

View changes since this unapproval

[the8472]

@bors try jobs=test-aarch64-msvc-1

[rust-bors]

☀️ Try build successful (CI)
Build commit: 5efc99c (5efc99c0438eba2af63f369353f9657e39b1b339)
Base parent: a7c37f9 (a7c37f9f0ee5e93396106e9de20f4a86b4154e63)

[the8472]

fixed the doctest cfgs, no other changes

@bors r=jhpratt

[rust-bors]

📌 Commit 2de7d9c has been approved by jhpratt

It is now in the queue for this repository.

[jhpratt]

@bors r- #164658 (comment)

---- library/std/src/os/fd/owned.rs - os::fd::owned::BorrowedFd<'_>::to_view (line 96) stdout ----
Test executable failed (exit status: 1).

stderr:
error: unsupported operation: obtaining metadata is only supported on file-backed file descriptors
   --> /checkout/library/std/src/sys/pal/unix/weak/syscall.rs:13:26
    |
 13 |                   unsafe { fun($($param),*) }
    |                            ^^^^^^^^^^^^^^^^ unsupported operation occurred here
    |
   ::: /checkout/library/std/src/sys/fs/unix.rs:166:9
    |
166 | /         syscall!(
167 | |             fn statx(
168 | |                 fd: c_int,
169 | |                 pathname: *const c_char,
...   |
173 | |             ) -> c_int;
174 | |         );
    | |_________- in this macro invocation
    |
    = help: this is likely not a bug in the program; it indicates that the program performed an operation that Miri does not support
    = note: stack backtrace:
            0: std::sys::fs::unix::try_statx::statx
                at /checkout/library/std/src/sys/pal/unix/weak/syscall.rs:13:26: 13:42
            1: std::sys::fs::unix::try_statx
                at /checkout/library/std/src/sys/fs/unix.rs:182:31: 182:69
            2: std::sys::fs::unix::File::file_attr
                at /checkout/library/std/src/sys/fs/unix.rs:1261:41: 1266:14
            3: std::fs::File::metadata
                at /checkout/library/std/src/fs.rs:1150:9: 1150:31
            4: main::_doctest_main_library_std_src_os_fd_owned_rs_96_0
                at library/std/src/os/fd/owned.rs:9:12: 9:61
            5: main
                at library/std/src/os/fd/owned.rs:13:3: 13:54
            6: <fn() as std::ops::FnOnce<()>>::call_once - shim(fn())
                at /checkout/library/core/src/ops/function.rs:250:5: 250:71
    = note: this error originates in the macro `syscall` (in Nightly builds, run with -Z macro-backtrace for more info)

[rust-bors]

This pull request was unapproved.

This PR was contained in a rollup (#164658), which was unapproved.

View changes since this unapproval

[rustbot]

Any special-casing of Miri in the standard library requires review.

cc @rust-lang/miri

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[RalfJung]

Please add a FIXME pointing to rust-lang/miri#5453, we should support that.

View changes since the review

[RalfJung]

On Windows we should skip most of these tests anyway? Is this one really being executed?

View changes since the review

[the8472]

I don't know, I added it preemptively on the assumption that if it doesn't work on unix+miri it's unlikely to work on windows+miri either.

[RalfJung]

Most of the std test suite fails in Miri under Windows, so there's no point in excluding a few tests.