Skip to content

Rollup of 4 pull requests - #164556

Merged
rust-bors[bot] merged 9 commits into
rust-lang:mainfrom
tgross35:rollup-zzts1cI
Oct 19, 2026
Merged

Rollup of 4 pull requests#164556
rust-bors[bot] merged 9 commits into
rust-lang:mainfrom
tgross35:rollup-zzts1cI

Conversation

@tgross35

@tgross35 tgross35 commented Oct 19, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

kianalikasana and others added 9 commits October 11, 2026 14:04
kianalikasana
Add windows_subsystem attribute documentation
a738796
@kiana1kaslana @bushrat011899
Update library/core/src/attribute_docs.rs
f0c6287 
Co-authored-by: Zachary Harrold <zac@harrold.com.au>
@brad0
Bump libc to v0.2.191
b728431
@GuillaumeGomez
Clean up tests/rustdoc-html
f994970
@estebank
[tiny] Remove some useless .into() calls
cb8b18d
@tgross35
Rollup merge of rust-lang#163732 - brad0:libc_crate, r=tgross35
5f1f67a 
Bump libc to v0.2.191

Various bug fixes and additions including getexecpath() support.
@tgross35
Rollup merge of rust-lang#164189 - kiana1kaslana:docs-windows-subsyst…
b301ccb 
…em, r=bushrat011899

Add `windows_subsystem` attribute documentation

part of [rust-lang#157604](rust-lang#157604).
@tgross35
Rollup merge of rust-lang#164532 - estebank:usesless-into-calls, r=ko…
846e829 
…bzol

[tiny] Remove some useless `.into()` calls

Detected while working on rust-lang#129249.
@tgross35
Rollup merge of rust-lang#164523 - GuillaumeGomez:more-html-cleanups,…
eacfabf 
… r=Urgau

Clean up `tests/rustdoc-html`

Yet another one. This one is a bit different though because it made me realize that a `!has` was not checking anything so I fixed it. I'm considering more and more to remove the use of `!` or at least strongly restrict it.

r? @Urgau
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Oct 19, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 19, 2026
@tgross35

tgross35 commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@bors r+ force rollup=never p=5

@rust-bors

rust-bors Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit eacfabf has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2026
@rust-bors rust-bors Bot mentioned this pull request Oct 19, 2026
Merged
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 19, 2026
@rust-bors

rust-bors Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: tgross35
Duration: 3h 15m 3s
Pushing 588c7e9 to main...

@rust-bors
rust-bors Bot merged commit 588c7e9 into rust-lang:main Oct 19, 2026
15 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 19, 2026
@rust-bors rust-bors Bot mentioned this pull request Oct 19, 2026
Open
@github-actions

github-actions Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b6eeb93 (parent) -> 588c7e9 (this PR)

Test differences

Show 38 test diffs

Stage 1

  • [rustdoc-html] tests/rustdoc-html/display/staged-api-deprecated-unstable-32374.rs: [missing] -> pass (J0)
  • [rustdoc-html] tests/rustdoc-html/display/staged-api-feature-issue-27759.rs: [missing] -> pass (J0)
  • [rustdoc-html] tests/rustdoc-html/display/useless_lifetime_bound.rs: [missing] -> pass (J0)
  • [rustdoc-html] tests/rustdoc-html/display/viewpath-rename.rs: [missing] -> pass (J0)
  • [rustdoc-html] tests/rustdoc-html/display/viewpath-self.rs: [missing] -> pass (J0)
  • [rustdoc-html] tests/rustdoc-html/lifetime-name.rs: pass -> [missing] (J0)
  • [rustdoc-html] tests/rustdoc-html/staged-api-deprecated-unstable-32374.rs: pass -> [missing] (J0)
  • [rustdoc-html] tests/rustdoc-html/staged-api-feature-issue-27759.rs: pass -> [missing] (J0)
  • [rustdoc-html] tests/rustdoc-html/typedef/lifetime-name.rs: [missing] -> pass (J0)
  • [rustdoc-html] tests/rustdoc-html/useless_lifetime_bound.rs: pass -> [missing] (J0)
  • [rustdoc-html] tests/rustdoc-html/viewpath-rename.rs: pass -> [missing] (J0)
  • [rustdoc-html] tests/rustdoc-html/viewpath-self.rs: pass -> [missing] (J0)

Stage 2

  • [rustdoc-html] tests/rustdoc-html/display/staged-api-deprecated-unstable-32374.rs: [missing] -> pass (J1)
  • [rustdoc-html] tests/rustdoc-html/display/staged-api-feature-issue-27759.rs: [missing] -> pass (J1)
  • [rustdoc-html] tests/rustdoc-html/display/useless_lifetime_bound.rs: [missing] -> pass (J1)
  • [rustdoc-html] tests/rustdoc-html/display/viewpath-rename.rs: [missing] -> pass (J1)
  • [rustdoc-html] tests/rustdoc-html/display/viewpath-self.rs: [missing] -> pass (J1)
  • [rustdoc-html] tests/rustdoc-html/lifetime-name.rs: pass -> [missing] (J1)
  • [rustdoc-html] tests/rustdoc-html/staged-api-deprecated-unstable-32374.rs: pass -> [missing] (J1)
  • [rustdoc-html] tests/rustdoc-html/staged-api-feature-issue-27759.rs: pass -> [missing] (J1)
  • [rustdoc-html] tests/rustdoc-html/typedef/lifetime-name.rs: [missing] -> pass (J1)
  • [rustdoc-html] tests/rustdoc-html/useless_lifetime_bound.rs: pass -> [missing] (J1)
  • [rustdoc-html] tests/rustdoc-html/viewpath-rename.rs: pass -> [missing] (J1)
  • [rustdoc-html] tests/rustdoc-html/viewpath-self.rs: pass -> [missing] (J1)

Additionally, 14 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 588c7e92f931498b1552ee64cad77fb0344cabfa --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. test-x86_64-mingw-2: 1h 38m -> 2h 53m (+75.7%)
  2. dist-arm-linux-gnueabi: 1h 4m -> 1h 39m (+54.9%)
  3. test-i686-gnu-2: 1h 6m -> 1h 41m (+52.3%)
  4. dist-x86_64-msvc: 2h 11m -> 3h 13m (+46.5%)
  5. test-x86_64-msvc-1: 1h 47m -> 2h 35m (+45.3%)
  6. test-various: 2h 25m -> 1h 26m (-40.2%)
  7. test-x86_64-msvc-ext1: 1h 46m -> 2h 28m (+40.1%)
  8. test-x86_64-gnu-next-trait-solver-polonius: 1h 2m -> 38m 20s (-38.6%)
  9. dist-loongarch64-musl: 2h 1m -> 1h 18m (-35.6%)
  10. dist-powerpc64-linux-gnu: 1h 38m -> 1h 5m (-32.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@tgross35
tgross35 deleted the rollup-zzts1cI branch October 19, 2026 07:18
@rust-timer

rust-timer commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (588c7e9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.9% [4.0%, 5.8%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.1% [-4.9%, -3.4%] 2
All ❌✅ (primary) - - 0

Cycles

Results (primary 2.7%, secondary -4.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.7% [2.7%, 2.7%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.0% [-4.0%, -4.0%] 1
All ❌✅ (primary) 2.7% [2.7%, 2.7%] 1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 489.811s -> 493.578s (0.77%)
Artifact size: 408.98 MiB -> 409.12 MiB (0.03%)

@rust-bors

rust-bors Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#163732 Bump libc to v0.2.191 a41f724bb767a11ab3ff555dde324b11326c58c2
(link)
#164189 Add windows_subsystem attribute documentation 525e687d628be9a4ebca871541b485425b3cf054
(link)
#164532 [tiny] Remove some useless .into() calls 99afa905d2fb2809be5d6ff3aa0f5eeb5a689cc6
(link)
#164523 Clean up tests/rustdoc-html 0425317fc76d6d8a90eefbcd710cb5296abb52fa
(link)

parent commit: b6eeb93c99

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

7 participants

@tgross35 @rust-timer @rustbot @kiana1kaslana @brad0 @GuillaumeGomez @estebank