Skip to content

[tiny] Remove useless .into() calls - #163723

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
estebank:remove-useless-into
Oct 4, 2026
Merged

rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
estebank:remove-useless-into

Conversation

@estebank

@estebank estebank commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 3, 2026
@rustbot

rustbot commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, types
  • compiler, types expanded to 77 candidates
  • Random selection from 18 candidates

@estebank
estebank force-pushed the remove-useless-into branch from f8d7376 to 3ab8f66 Compare October 3, 2026 23:42
@estebank
estebank force-pushed the remove-useless-into branch from 3ab8f66 to 59a2426 Compare October 3, 2026 23:46
@rustbot

rustbot commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

@rustbot

rustbot commented Oct 4, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

@clarfonthey clarfonthey left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty reasonable.

View changes since this review

@chenyukang

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c7ebf41 has been approved by chenyukang

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2026
@estebank

estebank commented Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

These were found while working on #129249. The initial implementation of that lint had caught a few already, but I hadn't touched that branch in a year, so it's not surprising that new cases of these cropped up in the meantime :)

rust-bors Bot pushed a commit that referenced this pull request Oct 4, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #162974 (FCW for `#[panic_handler]` on `unsafe fn`.)
 - #163627 (Add documentation for the `no_main` and `repr` attributes)
 - #163671 (Add `--frontend-threads` option to `./x perf`)
 - #163694 (c_str_alloc_error test: mention why this is mostly Miri-only)
 - #163711 (Stabilize `CStr::display`)
 - #163723 ([tiny] Remove useless `.into()` calls)
@rust-bors
rust-bors Bot merged commit 1afe421 into rust-lang:main Oct 4, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 4, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 4, 2026
Rollup merge of #163723 - estebank:remove-useless-into, r=chenyukang

[tiny] Remove useless `.into()` calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants