Add --frontend-threads option to ./x perf - #163671
Merged
rust-bors[bot] merged 2 commits intoOct 4, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
Wait, I recognize that username. Hi :D |
Contributor
Author
|
Hey! Good to see you around :D |
Member
|
r? kobzol Thanks! @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 4, 2026
…uwer Rollup of 6 pull requests Successful merges: - #162974 (FCW for `#[panic_handler]` on `unsafe fn`.) - #163627 (Add documentation for the `no_main` and `repr` attributes) - #163671 (Add `--frontend-threads` option to `./x perf`) - #163694 (c_str_alloc_error test: mention why this is mostly Miri-only) - #163711 (Stabilize `CStr::display`) - #163723 ([tiny] Remove useless `.into()` calls)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 4, 2026
Rollup merge of #163671 - itsjunetime:perf_frontend_threads_opt, r=Kobzol Add `--frontend-threads` option to `./x perf` This just adds an option to pass through the `--frontend-threads` option to `rustc-perf` through `./x perf` (which option is documented in the [`rustc-perf` repo](https://github.com/rust-lang/rustc-perf/blob/main/collector/README.md#benchmarking-options). Before this, `./x perf` had no way of telling `rustc-perf` how many frontend threads to use, so it always defaulted to 1. This made it a bit more difficult to test perf-related chnages to the parallel frontend. I tested this option locally and it seems to work perfectly fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just adds an option to pass through the
--frontend-threadsoption torustc-perfthrough./x perf(which option is documented in therustc-perfrepo. Before this,./x perfhad no way of tellingrustc-perfhow many frontend threads to use, so it always defaulted to 1. This made it a bit more difficult to test perf-related chnages to the parallel frontend.I tested this option locally and it seems to work perfectly fine.