Repository navigation
Avoid long iterator chain in all_rust_features - #163685
Merged
Merged
Conversation
rustbot
added
S-waiting-on-author
panstromek
marked this pull request as ready for review
October 3, 2026 05:07
Collaborator
|
Target features are being changed; ensure all ABI effects are being accounted for cc @RalfJung |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
Makes sense, thanks. |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Oct 3, 2026
… r=RalfJung Avoid long iterator chain in all_rust_features This chain creates an absolute monster type that clutters my cachegrind diffs :) This should make it simpler. I believe we've also seen `chain` to optimize poorly, but I don't think that's a concern here. It might also compile faster, we know that deep types created with iterator chains tend to scale poorly.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 3, 2026
Rollup of 6 pull requests Successful merges: - #163627 (Add documentation for the `no_main` and `repr` attributes) - #163663 (reflection: fix ICE when TypeId::info called on ADT) - #138744 (Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678)) - #163633 (core: io: clean `unused_variables` lint under `no_io_statics`) - #163681 (Make the tracking issue template better suited for experiments) - #163685 (Avoid long iterator chain in all_rust_features)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 3, 2026
… r=RalfJung Avoid long iterator chain in all_rust_features This chain creates an absolute monster type that clutters my cachegrind diffs :) This should make it simpler. I believe we've also seen `chain` to optimize poorly, but I don't think that's a concern here. It might also compile faster, we know that deep types created with iterator chains tend to scale poorly.
This was referenced Oct 3, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 3, 2026
…uwer Rollup of 8 pull requests Successful merges: - #163645 (add `ignore-compare-mode-next-solver` to all next-solver tests) - #163663 (reflection: fix ICE when TypeId::info called on ADT) - #163454 (Improve suggestion for lifetime preceding type in generics) - #163561 (tests: accept noundef in a couple more places) - #163633 (core: io: clean `unused_variables` lint under `no_io_statics`) - #163681 (Make the tracking issue template better suited for experiments) - #163685 (Avoid long iterator chain in all_rust_features) - #163690 (refactor: migrate to LLVM-C's `LLVMGetOrInsertFunction`) Failed merges: - #161491 (Rip out old solver coherence)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 3, 2026
Rollup merge of #163685 - panstromek:all_rust_features_iter, r=RalfJung Avoid long iterator chain in all_rust_features This chain creates an absolute monster type that clutters my cachegrind diffs :) This should make it simpler. I believe we've also seen `chain` to optimize poorly, but I don't think that's a concern here. It might also compile faster, we know that deep types created with iterator chains tend to scale poorly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This chain creates an absolute monster type that clutters my cachegrind diffs :) This should make it simpler.
I believe we've also seen
chainto optimize poorly, but I don't think that's a concern here. It might also compile faster, we know that deep types created with iterator chains tend to scale poorly.