Skip to content

tests: accept noundef in a couple more places - #163561

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
durin42:llvm-24-extra-noundefs
Oct 3, 2026
Merged

tests: accept noundef in a couple more places#163561
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
durin42:llvm-24-extra-noundefs

Conversation

@durin42

@durin42 durin42 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

LLVM 24 got smarter and is able to mark some more things noundef, which showed up in some of our test checks.

@rustbot label: +llvm-main

@durin42
tests: accept noundef in a couple more places
cfa655a 
LLVM 24 got smarter and is able to mark some more things noundef, which
showed up in some of our test checks.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 30, 2026
@rustbot

rustbot commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 21 candidates

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Sep 30, 2026
@nnethercote

nnethercote commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Maybe this review should be done by someone with SPARC familiarity, but:

  • Isn't rustc still on LLVM23?
  • How does this PR have changes to expected output without any other changes? Do SPARC tests not run on CI?

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2026
@rustbot

rustbot commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@durin42

durin42 commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Maybe this review should be done by someone with SPARC familiarity, but:

  • Isn't rustc still on LLVM23?

Yes, but for several years we've been maintaining a buildkite that lets us keep Rust HEAD working against LLVM HEAD. It's a business requirement for us at work, but it's also made LLVM upgrades for Rust take significantly less time.

  • How does this PR have changes to expected output without any other changes? Do SPARC tests not run on CI?

This change is a result of LLVM's optimizer being better in LLVM 24 and figuring out additional noundef attributes without any action required on our part. If you look for other PRs marked with the llvm-main flag you'll see this sort of test-only fix for LLVM-next is pretty routine.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 2, 2026
@nnethercote

nnethercote commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Is that buildkite comparing HEAD vs HEAD the only CI testing that this file participates in? I can see how this change would keep that working, I'm unclear about whether any CI still tests LLVM 23 and could be broken by this change.

@nikic

nikic commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

The test runs on all LLVM versions. {{( noundef)?}} will accept both the undef being there and being missing, so it's compatible with different versions of LLVM.

@bors r+ rollup

@rust-bors

rust-bors Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

📌 Commit cfa655a has been approved by nikic

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 3, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163561 - durin42:llvm-24-extra-noundefs, r=…
4916d11 
…nikic

tests: accept noundef in a couple more places

LLVM 24 got smarter and is able to mark some more things noundef, which showed up in some of our test checks.

@rustbot label: +llvm-main
This was referenced Oct 3, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 3, 2026
@bors
Auto merge of #163695 - JonathanBrouwer:rollup-qSYnNoO, r=JonathanBro…
db8f076 
…uwer

Rollup of 8 pull requests

Successful merges:

 - #163645 (add `ignore-compare-mode-next-solver` to all next-solver tests)
 - #163663 (reflection: fix ICE when TypeId::info called on ADT)
 - #163454 (Improve suggestion for lifetime preceding type in generics)
 - #163561 (tests: accept noundef in a couple more places)
 - #163633 (core: io: clean `unused_variables` lint under `no_io_statics`)
 - #163681 (Make the tracking issue template better suited for experiments)
 - #163685 (Avoid long iterator chain in all_rust_features)
 - #163690 (refactor: migrate to LLVM-C's `LLVMGetOrInsertFunction`)

Failed merges:

 - #161491 (Rip out old solver coherence)
@rust-bors
rust-bors Bot merged commit 304792b into rust-lang:main Oct 3, 2026
13 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 3, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 3, 2026
@bors
Unrolled build for #163561 in rollup 163695
07f337a 
Rollup merge of #163561 - durin42:llvm-24-extra-noundefs, r=nikic

tests: accept noundef in a couple more places

LLVM 24 got smarter and is able to mark some more things noundef, which showed up in some of our test checks.

@rustbot label: +llvm-main
@github-actions github-actions Bot mentioned this pull request Oct 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nnethercote nnethercote

Labels

llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

4 participants

@durin42 @rustbot @nnethercote @nikic