Repository navigation
Conversation
ubuntu-latest now gives the Ubuntu 26.04 image, and Playwright 1.59.1
refuses to install Chromium there ("Playwright does not support chromium
on ubuntu26.04-x64"), so every pull request's e2e job has failed in its
install step since, before a single test ran. The retry loop can't help.
24.04 is the image every e2e run passed on until now. The lint-type-test
job still passes on 26.04 and is left as it is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LrYa57fvbqWjZj89iH975K
richshaw
added
bug
Claude
Tophat: passedThis only changes CI config (
Not UX. Generated by Claude Code |
richshaw
left a comment
richshaw
left a comment
There was a problem hiding this comment.
Review: passed (round 1)
A four-line CI change. The e2e job runs on ubuntu-24.04 instead of ubuntu-latest, which has moved to Ubuntu 26.04, where Playwright 1.59.1 refuses to install Chromium. A comment says why, and when to move back. lint-type-test stays on ubuntu-latest, since it passes there. The install retry loop from #551 is untouched, and so is every test step. Nothing is skipped or loosened.
Blocking (0)
Optional (1): a Playwright upgrade that supports 26.04 would let the pin go. That's a separate change, as the description says.
Earlier threads: none.
Checks: CI on 16521f5 is green: lint-type-test, e2e (Chromium installed on ubuntu-24.04, and the suite ran), CodeQL and Analyze. Two independent reviews of #604 and #605 confirmed that the copy of this commit carried in #604 (0331eb5) is identical: same message, same patch-id, same resulting ci.yml. So this and #604 can merge in either order without a conflict.
This waits for you because it touches .github/workflows/, which is high-risk. Until something like it is on main, every PR's e2e fails at install, so it unblocks the board.
https://claude.ai/code/session_01LrYa57fvbqWjZj89iH975K
Generated by Claude Code
richshaw
added
pipeline:owner
Claude
Playwright 1.59 can't install Chromium on the ubuntu-latest 26.04 image. Same change as #607; a no-op once that lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GzHBSajHsqVk57cvHdphNN
ubuntu-latest is now 26.04, where Playwright 1.59 cannot install Chromium, so e2e fails before any test runs. Same change as #607; it no-ops once that lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HfQvAkAuqbvPj5963Aacgi
Nothing outside its own unit test called it; the MCP step-up 403 comes from requireBearerAuth via resolveBearerActor. flow.db.test.ts now pins that challenge's error and resource_metadata too. Also pins CI's e2e job to ubuntu-24.04 (same change as #607). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HfQvAkAuqbvPj5963Aacgi
|
Closing: this change is already on Generated by Claude Code |
richshaw
removed
the
pipeline:owner
Claude
The problem
Every pull request's
e2ejob has failed since about 05:39 UTC on 25 October, in its install step, before a single test ran.ubuntu-latestnow gives the Ubuntu 26.04 image, and Playwright 1.59.1 won't install Chromium there:It fails the same way three times, so the retry loop from #551 can't help. Seen on #604, #605 and #606. The last green runs,
mainat 4ed27a9 and #603, ran on the old image.mainwill go red on its next push.The fix
e2eruns onubuntu-24.04, the image every e2e run passed on until now. A comment says why, and to move back toubuntu-latestwith a Playwright release that supports 26.04.lint-type-teststill passes on 26.04 and is left onubuntu-latest.Before merging
This touches
.github/workflows/, so it waits for you. Its owne2erun on this PR is the test: it should get past "Install Playwright Chromium" and run the suite.Generated by Claude Code