[richshaw]

Fixes #20. PR 5 of 5. Merge after #608, which it's stacked on, and so after the rest of the stack (#604, #605, #606).

The problem

No help page covers closing a signup. Nothing tells an organizer what Close signup does to the people already signed up, to reminders, or to the link. Now that a closed signup can be reopened (#608), nothing says how either.

The fix

A new page, "Close or reopen a signup" (src/help/articles/close-or-reopen-a-signup.tsx), scaffolded with new-article.mjs and registered in src/help/articles.ts and bodies.tsx. It has three sections:

• Close your signup:
  • from Your signups, the three dots next to Share (next to the title on a phone);
  • then Close signup, which asks first. The page says what the question tells you, and that Not yet leaves it open.
• While it's closed:
  • the closed status and the Signup closed box on every tab;
  • Closed on the public page and on each slot that isn't full (a full slot says Full);
  • everyone keeps their spot, from the imported KEEPS_THEIR_SPOT, and can still change their details or cancel with the link they got when they signed up, but can't take more spots;
  • reminders still go out;
  • nothing is deleted, and the link stays the same.
• Reopen your signup:
  • "At the top of the page, choose Reopen signup, next to Preview. On a phone, choose the three dots next to your signup's title first.", matching Add Reopen signup beside Preview, and to the phone's ⋯ #608's new placement;
  • it doesn't ask first and emails nobody;
  • the box goes, and the signup is open again at the same link;
  • a closing time that has passed, which only an AI assistant or the API can set, is removed; one still to come stays, and nobody can sign up after it.

The help index description now mentions closing and reopening.

CHANGELOG: a line under Added.

Facts checked against the code:

• reminders: notifiableRules treats closed like open;
• no email goes out on close or reopen: nothing in src/jobs or src/email acts on signup.closed or signup.reopened;
• full slots say Full: signup-view.tsx;
• the edit link's wording on a closed signup;
• reopening clears a passed closing time: reopenSignup;
• a closing time still to come shuts sign-ups once it passes: signupShutReason.

Tests

The walkthrough is tests/e2e/help/close-or-reopen-a-signup.spec.ts. It finds every control by the article's UI names, so renaming one fails it.

On a computer, it:

1. signs someone up;
2. opens the signup from Your signups;
3. checks the three dots sit next to Share;
4. closes it from the panel, after Not yet first leaves it open;
5. checks the box on Build, Responses and Settings;
6. checks the public page and the participant's edit link;
7. sets a passed closing time through the API;
8. checks Reopen signup sits next to Preview, reopens, and checks the time is gone and Sign up is back.

It takes the article's three screenshots along the way.

On a phone, the three dots are beside the title. It closes from the sheet, and checks the three dots stay once it's closed. It then reopens from them, where the sheet holds Preview and Reopen signup.

Earlier, the phone walkthrough found two bugs in #608's sheet, now fixed there (bc159d0, 3ca991f).

The picture for the Reopen step, reopen-button.png, shows just Preview and Reopen signup (280×68). It replaces the grey box's computer-width capture, which was too small to read on a phone.

Ran and passed on 3ba5494:

• pnpm lint, pnpm typecheck, pnpm knip and pnpm test (1746, including articles.test.tsx's style rules and its "every screenshot has a file, alt text and its real size");
• pnpm build && pnpm budgets (/help/[slug] 111.6 of 113 kB);
• organizer.spec.ts, every help walkthrough and a11y.spec.ts (41).

The screenshots, under public/help/close-or-reopen-a-signup/, were taken by the walkthrough with HELP_SCREENSHOTS=1.

Legal

No change. This page describes behaviour the earlier PRs added, and it stores and sends nothing.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LrYa57fvbqWjZj89iH975K

[richshaw]

UX walkthrough on e604ee5: the steps match the screen, and one picture is too small on a phone

In today's UX walkthrough, a tester followed this page on a computer and then a phone. Their signup had one slot with room and one that was full. They closed it and reopened it using the article alone. Every step's wording matched the screen. The facts also held when we checked them:

• Reminders still go out while it's closed: I made one come due on a closed signup and ran the dispatch.
• Closing and reopening email nobody.
• A full slot says Full.
• The participant's link still lets them change their details or cancel.
• A closing time that has passed is cleared on reopen, and one still to come stays.

The run was on 9f68b2f. I checked the article again on e604ee5, after the restack moved Reopen signup next to Preview.

What people see is too small to read on a phone

At 390px wide, what-people-see.png (1408×680) shows at 356px, a quarter of its size. "This signup is no longer collecting responses." and each slot's Closed come out about 7px tall. The other two pictures show at about half size and read fine. People mostly open this page on a phone, so a capture at phone width (a 390px viewport) would show what most of them see, and would read at full size. Minor.

Smaller

• "Pause" doesn't lead here. The word isn't in the title, the summary on the help index or the page itself, and the help pages have no search. The tester searched the page for "pause" and "stop sign" and found nothing. They found it only by reading the four titles. Saying "pause" somewhere, for example "Pause sign-ups, or stop them…" in the summary, would catch it. Polish.
• Nothing on the signup page leads here. The close question and the Signup closed box don't link to this page. Help in the header goes to the index. Polish, and maybe not for this PR.

---

Generated by Claude Code

[richshaw]

Review: passed (round 3)

Round 2 passed cef5b86. The only change since is e604ee5, which merges #608's c7c9100. That commit corrects a CHANGELOG line and some comments, and was reviewed on #608 (round 6). Nothing in this PR's own files changed.

• The merge brings in exactly c7c9100. git diff cef5b86 e604ee5 matches git diff aeb4241 c7c9100 line for line, apart from context: CHANGELOG.md, and doc comments in actions.ts and ReopenButton.tsx.
• This PR's own diff is unchanged. git diff c7c9100 e604ee5 matches git diff aeb4241 cef5b86 line for line. The only difference is a context line, the web-app line this merge took from #608. That's 10 files, +487/−1, and git diff 3ba5494 e604ee5 touches none of them: not src/help, public/help, tests/e2e/help or seo.test.ts.
• The CHANGELOG conflict was resolved as described. e604ee5 has #608's corrected web-app line ("A refusal shows on its own line under the header on a computer, …") once, at line 11. This branch's help-page line is at line 12, also once. There are no conflict markers, and the combined diff shows nothing else changed.
• No runtime code changed since 3ba5494. The shared check prints 0, and still does with #608's head excluded too. The only non-merge commits in that range are #608's aeb4241 (e2e only) and c7c9100 (comments and CHANGELOG). This PR has no commits of its own since 3ba5494.

The article doesn't describe refusals, so #608's corrected wording leaves it as it was. Round 2's sentence-by-sentence check against the code still holds.

Blocking (0): none.

Optional (1): Still open from round 1: shot() is copied in all three help walkthroughs under tests/e2e/help/ and could move to tests/e2e/helpers/.

Earlier threads: none. Copilot couldn't review (quota used up).

Checks:

• CI on e604ee5 is green: lint-type-test, e2e, CodeQL and both Analyze jobs.
• On e604ee5 I ran the help and sitemap unit tests (articles.test.tsx, seo.test.ts): 54 passed.
• The tophat passed on 3ba5494 (comment), and no runtime code has changed since.

Why this waits for you: it's UX: a new public help page, and a new description on the /help index.

• Look at /help/close-or-reopen-a-signup on a phone and on a computer (the tophat's 610r-phone-article).
• Look at the three pictures in public/help/close-or-reopen-a-signup/.
• Merge it after #608.

https://claude.ai/code/session_01LrYa57fvbqWjZj89iH975K

---

Generated by Claude Code

[richshaw]

Tophat: passed

Ran 2ad6df0 on a production build, Postgres 16, Chromium at 390×844 and in the walkthrough at 1280×900. Since the last tophat (3ba5494), the help page follows #608's change, made on the owner's call: the grey Signup closed box now shows once, right after you close the signup, not on every visit.

Check	Result	What I saw
"While it's closed"	✅	"Your signup is marked closed at the top of the page. Right after you close it, a grey box under its title says Signup closed." That matches #608 at 2f9c722 (its tophat, comment 6402788227).
"Reopen your signup"	✅	"Your signup is marked open again. You don't need to send the link again, since it hasn't changed." It no longer says the box goes away.
Pictures	✅	Re-taken with HELP_SCREENSHOTS=1, and byte-identical to before: none of them shows the box.
Phone	✅	No sideways scroll.
Walkthrough	✅	It checks the box right after closing, the closed status on every tab, and that the box has gone when you come back later. The help and organizer e2e pass 37/37 on 2ad6df0, and the full suite passed 86/86 on 4bff51b.
Checks on 2ad6df0	✅	Lint, typecheck, knip, unit tests, build and budgets.
Console	✅	No errors.

UX: two sentences on the help page.

---

Generated by Claude Code

[richshaw]

Review: passed (round 4)

Round 3 passed e604ee5. Since then:

• 22103c2 merges #608's f565650, which shows the grey box only once. Only CHANGELOG conflicted.
• 4bff51b brings the article in line with it:
  • "While it's closed" now says "Your signup is marked closed at the top of the page. Right after you close it, a grey box under its title says Signup closed."
  • "Reopen your signup" now says "Your signup is marked open again…", without "The grey box goes away".
  • The .ui.ts comment for signupClosed says when the box shows.
  • On a computer, the walkthrough checks the box right after closing, the closed status on every tab, and no box when coming back from Your signups. The phone walkthrough still checks the box after closing from the sheet, and that it's gone after Reopen.
• 2ad6df0 merges #608's 2f9c722 cleanly. This PR's own changes are the same before and after it: git diff f565650 4bff51b and git diff 2f9c722 2ad6df0 add and remove the same lines.

I checked the article against the code at 2ad6df0:

• "marked closed at the top of the page": both headers show StatusPill beside the title (SignupHeader.tsx:101, MobileSignupHeader.tsx:58). The layout holds them, so it's on every tab.
• "Right after you close it, a grey box under its title says Signup closed":
  • ClosedNotice shows the box under the header only after Close signup on this page. It stays on every tab until its ✕ or the next page load.
  • Coming back to the signup later shows no box.
  • The sentence claims no more than that, and it reads naturally straight after the steps.
• "marked open again" after Reopen: the pill reads open once reopenAction revalidates the layout. Dropping "The grey box goes away" was right, because by the time someone comes back to reopen, there's usually no box.
• Nothing left in src/help: no other text says the box is on every tab or that it goes away. I searched for "every tab", "grey box" and "banner".
• The pictures don't show the box, so none needed re-taking. Each is still exactly twice the size the article gives it: 672×390, 560×136 and 1408×680.
• The rest of the article: round 2's sentence-by-sentence check still holds. Nothing it relied on changed in 4bff51b or the merges. CI's e2e on this SHA runs the walkthrough with main's #602, which changed the sign-up sheet, and it still finds the public page's "Closed" and the edit link's wording.

#608's round 7 blocker is about a closed signup's empty Responses tab, which this article doesn't describe. Whichever fix #608 takes, this page needs only the merge.

Blocking (0): none.

Optional (2):

• Still open from round 1: shot() is copied in all three help walkthroughs under tests/e2e/help/, and could move to tests/e2e/helpers/.
• From the UX walkthrough comment on this PR: on a 390px phone, what-people-see.png (1408×680) shows 356px wide, so its "Closed" text is about 7px tall. A capture at phone width would read at full size. Its alt text says what it shows, and no step depends on it.

Earlier threads: none. Copilot couldn't review (quota used up).

Checks:

• CI on 2ad6df0 is green: lint-type-test, e2e (88 passed), CodeQL and both Analyze jobs.
• Locally on 2ad6df0, the help and sitemap unit tests pass (src/help and seo.test.ts, 59). They include articles.test.tsx's style rules and picture sizes.
• Tophat: passed on 2ad6df0, the head (comment).

Why this waits for you: it's UX: a new public help page, and a new description on the /help index.

• Look at /help/close-or-reopen-a-signup on a phone and on a computer, and at the three pictures in public/help/close-or-reopen-a-signup/.
• Merge it after #608, which needs one more round first.

https://claude.ai/code/session_01LrYa57fvbqWjZj89iH975K

---

Generated by Claude Code