[richshaw]

Fixes #504 (part 3 of 3; parts 1 and 2 are #535 and #536). Part of #498. Stacked on #536; the diff here is only "People for each slot".

What changes

On the review page, next to the slots' headline ("4 slots · 2 days · 1 to 3 people each"), there's now People for each slot: a number box and Set. It appears when the draft has at least two slots.

• Set gives every slot that number of spots, then says "Set every slot to 4 people." with Undo. Undo puts back what each slot had before.
• If every slot already has that number, it says "Every slot is already for 3 people." with no Undo, and nothing is written.
• The box starts with the shared number when every slot has the same one.
• On a phone, the control wraps under the headline.

How it works

• A new service, updateSlotCapacities in src/services/slots.ts. The issue suggested the slots/bulk route, but that route only adds slots. The service:

  • runs in one transaction under the signup and slot locks, in the documented order;
  • refuses unknown ids;
  • refuses a capacity below the spots already taken, mirroring updateSlot, so it's safe on a published signup too;
  • skips unchanged slots, and writes nothing when nothing changes;
  • otherwise writes one slot.updated row { bulk: true, slotIds, changed: ['capacity'] }.

  It returns each changed slot's previous capacity.

• The review page calls it through setCapacityAction → setDraftCapacity in src/services/draft-fixes.ts. That shares loadDraft, so it works on drafts only and refuses viewers. A fingerprint of all the draft's slots, as the page showed them, must match the slots as they are now. Otherwise: "That changed since you opened this page, so nothing was done."

• Undo with a staleness guard. Undo goes through the shared undoDraftFixAction. It's refused ("That changed again since…") unless every slot still exists and still has the number Set gave it. So a number changed since, in the slot editor, the builder or by an assistant, is never overwritten, and a second Undo is refused.

• One line, one Undo. It shares the card's status line and last-action Undo with the one-tap fixes and Remove day (Remove a whole day from the draft review page, with Undo #536). An open slot editor saves first. A refusal shows by the control and takes focus.

• Telemetry: review.slots_edited { kind: 'set_capacity' } after Set, and review.fix_undone { kind: 'set_capacity' } after Undo. docs/telemetry.md and the privacy page say so.

Budget

/app/signups/[id]: 114.9 / 115 kB, so no change to the budget.

Help

"Create and publish your first signup": "To give every slot the same number of spots, type the number in People for each slot, above your slots. Then choose Set. Right after, Undo puts back what each slot had." A new walkthrough test sets three slots at 1, 2 and 3 to 4, checks the rows and the headline, then undoes and reloads. The review page's picture (check-your-signup.png) is re-taken to show the control, with the pointer moved off the rows first.

Checks

• pnpm lint && pnpm typecheck && pnpm knip && pnpm test: pass (1571)
• pnpm test:db: pass (634), including:
  • the service's tests: bulk set, no limit, unchanged skipped, unknown id, below spots taken on a published signup, viewer, deleted signup, round trip, concurrent calls;
  • 9 action tests.
• pnpm build && pnpm budgets: pass
• Full e2e (chromium): 65 passed

Tophat

In the running app with made-up data (4 slots at 5, 1, 2 and 3 spots):

• Set 4: "Set every slot to 4 people.", with focus on Undo. One bulk slot.updated row covers all 4, and review.slots_edited is written.
• Undo: each slot gets its own number back, and review.fix_undone is written.
• Set 3, then 3 again: the second time says "Every slot is already for 3 people.", with no Undo and nothing written.
• Phone (390×844): the control sits under the headline and fits.
• No server errors.

---

Generated by Claude Code

[richshaw]

Tophat: pass in the running app with made-up data (pat@example.com).

• Set 4 on 4 slots (5, 1, 2 and 3 spots). The page says "Set every slot to 4 people." and focus moves to Undo. One bulk slot.updated row and review.slots_edited {kind: set_capacity} are written. (93c73e1)
• Undo gives each slot its own number back and writes review.fix_undone. (93c73e1)
• No change: Set 3 when every slot already has 3 writes nothing. (93c73e1)
• No change keeps the last Undo (960aa8b). Remove day on Thu, Jun 13, then Set 3 with every slot already at 3. "Every slot is already for 3 people." shows as a note by the box and takes focus, and the Remove day line and its Undo stay. That Undo still brings Jun 13 back. Before the review fixes, the note replaced the line and the day could no longer be brought back.
• Phone (390×844): the control wraps under the headline and fits. No console errors.

Code review on this PR, fixed in 960aa8b:

• Checks run under the lock. updateSlotCapacities takes three optional guards: onlyDraft, wholeSignup (the ids sent must be every slot as locked) and a per-slot expected capacity. Set uses the first two, so a publish or a new slot landing between the page's read and the lock is refused, and no live signup is changed. Undo uses onlyDraft and expected, so a number changed meanwhile is never overwritten. DB tests cover each guard landing while the call waits behind the lock.
• No-change answers. They keep the card's last Undo and show as a note by the control.
• Capacity is capped at MAX_CAPACITY on the shared CapacitySchema. A too-big number now gets a structured invalid_input and its own words ("That's more people than one slot can take."), not a 500.
• The typed number survives a refused Set.
• One copy of the fallback words, passed from the server.

Left as is: the extra signup read and policy check that updateSlotCapacities repeats after loadDraft. It costs two round trips on a click, and the new guards need the locked read anyway.

Checks on 960aa8b: lint, typecheck and knip pass; unit (1573), test:db (645), build + budgets (/app/signups/[id] 114.9 / 115 kB) and e2e (65/65) all pass.

---

Generated by Claude Code

[richshaw]

Closing without merging, as part of the redesign in #498. The branch stays: updateSlotCapacities and the set-every-slot service and their tests are meant to be reused.

---

Generated by Claude Code