[richshaw]

Part of #504 (part 1 of 3: tap a slot to edit it; "Remove day" and "People for each slot", each with Undo, come next). Part of #498. Stacked on #534; the diff here is only slot editing.

What changes

On the review page ("Check your signup, then share it"), each slot row is now a button. Choosing it opens the builder's own SlotEditor under the row, with every field and Capacity:

• Done saves in one PATCH /api/slots/[id], the route the builder uses. It sends values only when a value changed and capacity only when that changed. It closes once the page has come back from the server, puts focus back on the row, and shows "Saved" beside it.
• Cancel (or Escape) throws the changes away. Done with nothing changed just closes.
• One slot is open at a time. Choosing another slot while one is open saves the open one first. If that save is refused, it stays open with the reason.
• Duplicate and Delete aren't offered here. Adding and removing slots and fields stays in the builder, through "Edit everything in the builder", as the issue says.
• "Add to list" on a list field saves the new choice through the field route first, as the builder does.

Notes for review

• One editor, one save path. SlotEditor gains optional onDuplicate/onDelete (hidden when absent), an optional Cancel, and a saving state. The number handling for a slot's values moved into src/components/build-shared/slotValues.ts (toStringValues, toSlotValues, slotPatch), which both the builder and the review page now build their request bodies from, so the two can't send a slot differently. useReviewSave now takes the save function, so the cards and the slot rows share the "save, refresh, then say Saved" behaviour.
• Nothing is saved until Done. The builder saves 800 ms after typing stops; here an explicit Done means a quick close can't lose an edit, as the issue asks. The page refreshes after every save, so a change an AI assistant made meanwhile shows up.
• The editor isn't in the first load. ReviewSlotPanel, which brings SlotEditor and the list picker with it, loads on first tap, or when a row is hovered or focused, as the share step loads its QR encoder.
• Budgets, raised with reasons:
  • /app/signups/[id]: 113 → 114 kB (measured 113.6). The row buttons and the panel's loader are in the first load.
  • /app/signups/[id]/build: 151 → 153 kB (measured 152.4). The Build tab loads the same code as before. Because the review page now loads SlotEditor on demand, webpack moves it into a chunk of its own that both pages share, and two gzipped files cost about 1.4 kB more than one. I checked the new chunk: it holds only the editor and the list picker.
  • /login: 109 → 110 kB. Every page loads webpack's runtime, which lists the async chunks. The new one tipped /login, already at its budget, over by a rounding hair.
• Telemetry: none new. A save writes slot.updated, as the builder's do. docs/telemetry.md now says the payload doesn't say which page it came from.

Help

"Create and publish your first signup": "To change a slot, choose it. Change what you need, like its date or its Capacity, then choose Done to save it. To close it without saving, choose Cancel." The next step now starts "To add or remove slots, choose Edit everything in the builder". A new walkthrough test sets a slot's Capacity to 3 with Done and checks that it is saved after a reload, then changes another slot and cancels. The review page's screenshot is unchanged.

Checks

• pnpm lint && pnpm typecheck && pnpm knip && pnpm test: pass (1509)
• pnpm test:db: pass (592)
• pnpm build && pnpm budgets: pass with the budgets above
• Full e2e (chromium): 63 passed

Tophat

In the running app with made-up data:

• Computer: choosing "Till" opens the editor under it, with focus in the first box. Capacity 2 → 4, then Done: "Saved" shows, the row says "4 people", and focus is back on the row.
• Cancel: a renamed value is thrown away.
• Switching rows: with a change typed into one row, choosing the other row saves it ("Cash box") and opens the other.
• Escape closes the editor.
• Phone (390×844): the editor stacks its fields, with Cancel and Done at the top.
• No console errors.

---

Generated by Claude Code

[richshaw]

Tophat: pass, in the running app with made-up data (pat@example.com).

• Computer. Choosing "Till" opens the builder's editor under it, with focus in the first box. Capacity 2 → 4 and Done shows "Saved"; the row reads "4 people" and focus returns to the row.
• Cancel throws away a renamed value.
• Switching rows. With a change typed into one row, choosing the other row saves the first and opens the second. Escape closes the editor.
• A save that moves the slot (on 70f93ac, grouped by date). Changing "Setup crew" from Thu, May 2 to Fri, May 3 and pressing Done closes the editor and shows "Saved". The slot now sits in the Fri, May 3 group (2 slots), with focus on its row. Before the review fixes, this left the editor stuck open.
• Phone (390×844). The editor stacks its fields, with Cancel and Done at the top. No console errors.

Code review on this PR. Fixed in 4e78ab5:

• Saving a slot that moves no longer leaves the editor stuck. The list (ReviewSlotEditing) now owns save → refresh → close, so a row that moves to another group comes back closed with "Saved", and its folded group opens to take focus. Two component tests remount the row under a new group key.
• List choices wait for Done. Cancel and Escape drop them.
• Add to list sends only { config }, so a stale page can't turn a field back into a list.
• Row names are an sr-only "Edit slot — " plus the row's visible text and its group's date, so the name contains what's on screen and rows on different days can be told apart.
• The page sends only the rows it draws, and toBuildFields is now one shared function.
• Docs. docs/telemetry.md notes that signup.editor_opened/review.notice_shown are written again on each refresh. The CHANGELOG says plainly that nothing is saved until Done, that leaving with an open, changed slot drops the change, and that a save replaces the slot's values whole, as the builder's does.

70f93ac fixes the walkthrough's setup: it removes the template's empty slot and opens every group.

Left as is:

• No unload or navigation guard for an open, changed slot. Nothing is saved until Done, and the PR and CHANGELOG say so.
• No per-key merge on PATCH /api/slots/[id]. Last save wins, as in the builder; that's an API change for its own PR.
• The builder still sends fieldType with Add to list (useBuildState's updateField). That's outside this PR.

Checks.

• On 70f93ac: the help walkthrough spec, 6/6.
• On 4e78ab5:
  • lint, typecheck, knip;
  • unit (1514) and test:db (592);
  • build + budgets (/app/signups/[id] 113.7 / 114 kB; /login 109.0 / 110);
  • e2e 62/63, the one failure being the walkthrough setup fixed in 70f93ac.

---

Generated by Claude Code

[richshaw]

Closing without merging. If the fixes move into the Build page (#498), slots are already edited there, so this page's editor isn't needed. The branch stays.

---

Generated by Claude Code