Repository navigation
chore(deps): pin @remoteoss/json-schema-form to the kit's required floor - #1554
Merged
Merged
Conversation
Declare @remoteoss/json-schema-form exactly and make check-single-schema-form fail unless the declared version equals the floor of the range the installed kit requires, printing the version to set. Range drift (^1.2.18 vs the kit's ^1.2.19) previously went undetected because the check only counted installed copies. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (291 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
2 tasks
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…-form-to-kit-requirement # Conflicts: # example/package-lock.json
jordividaller
approved these changes
Oct 15, 2026
…-form-to-kit-requirement # Conflicts: # example/package-lock.json # example/package.json
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@remoteoss/json-schema-formis now pinned exactly, and CI fails when the pin falls out of step with what the form kit requires.Why
The kit moved to
^1.2.19(#1547) whilepackage.jsonstill said^1.2.18, and nothing flagged it. The existing check only counted installed copies, so a stale range slipped through. The pin plus the new check makes the drift fail loudly and tells you the version to set.What changed
Toggle details
package.json/ lockfile:@remoteoss/json-schema-form^1.2.18→1.2.18.scripts/check-single-schema-form.ts: after the single-copy check, compares the declared version with the floor of the range declared by the installed@remoteoss/remote-json-schema-form-kit. Mismatch exits 1 and prints the version to set.json-schema-formdisabled (chore(renovate): stop bumping @remoteoss/json-schema-form on its own #1546), so the pin moves with the kit by hand, guided by the check.example/has its own lockfile, which the check doesn't inspect.^1.2.19) will fail this check until its pin is bumped to1.2.19. That is the check working as intended.Screenshots
N/A
Related Resources
Testing
Pin at
1.2.18with kit 1.1.2 (^1.2.18): check passes.Pin at
1.2.17: check fails and printsSet "@remoteoss/json-schema-form": "1.2.18".Tested against the
example/app in a browserFeature flag: N/A
🤖 Generated with Claude Code
Note
Low Risk
Dependency version pins and a CI guard script only; no runtime or public API changes.
Overview
Pins
@remoteoss/json-schema-formto an exact version (1.2.19) instead of a caret range, and bumps@remoteoss/remote-json-schema-form-kitto 1.1.4 in the root and example lockfiles so the pin matches what the kit requires.Extends
scripts/check-single-schema-form.ts(run viacheck-exports/ CI): after ensuring only one installed copy of the form package, it compares the declared pin in rootpackage.jsonto the minimum version implied by the installed kit’s dependency range. A mismatch fails the script with instructions to set the correct pin. The example app’s kit devDependency is updated but the check still only inspects the root package.Reviewed by Cursor Bugbot for commit 19eb713. Bugbot is set up for automated code reviews on this repo. Configure here.