Repository navigation
chore(renovate): stop bumping @remoteoss/json-schema-form on its own - #1546
Merged
Merged
Conversation
It is declared only so the emitted types resolve, and its version has to match the one @remoteoss/remote-json-schema-form-kit resolves. A separate bump can leave two copies, so it now moves only with the kit. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
…ate installs A caret range lets npm dedupe to the copy the kit resolves, so a kit upgrade carries it along. check-single-schema-form fails check-exports when more than one version is installed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (291 total)
✅ Bundle size check passed |
jordividaller
approved these changes
Oct 13, 2026
This was referenced Oct 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@remoteoss/json-schema-formnow follows the form kit's version instead of getting standalone Renovate bumps, and CI fails if two copies ever get installed.Why
The package is declared directly only so the emitted types resolve. Its version must match the one
@remoteoss/remote-json-schema-form-kitresolves. A standalone bump (like #1545) or a kit upgrade to a new range can leave two copies installed, with types from one and runtime from the other.What changed
Toggle details
renovate.json: disables standalone updates for@remoteoss/json-schema-form.package.json: the dependency goes from1.2.18to^1.2.18, the kit's range, sonpmDeduperesolves one copy and a kit upgrade carries it along. Lockfile resolution is unchanged (1.2.18).scripts/check-single-schema-form.ts: fails whennpm lsshows more than one version. Run as part ofnpm run check-exports, so it runs in the existing "Build and Check Exports" CI job.Screenshots
N/A
Related Resources
Testing
Ran the script against the current tree: passes, one version (1.2.18).
Pointed the same script at packages with two installed versions (e.g.
@babel/code-frame): fails with the versions listed.Tested against the
example/app in a browser: N/AFeature flag: N/A
🤖 Generated with Claude Code
Note
Low Risk
Tooling and dependency-range changes only; no runtime or public API changes, with CI added to catch version skew.
Overview
Stops Renovate from bumping
@remoteoss/json-schema-formon its own and adds CI guardrails so only one copy of that package can be installed. The direct dependency exists mainly for emitted types and must stay aligned with what@remoteoss/remote-json-schema-form-kitresolves.renovate.jsondisables standalone updates for@remoteoss/json-schema-form. Inpackage.json, the version moves from a pinned1.2.18to^1.2.18(matching the kit’s range) so dedupe can keep a single install when the kit upgrades. A newcheck-single-schema-formscript runsnpm lsand fails if more than one version appears; it is wired intocheck-exportsso existing export CI catches duplicate installs early.Reviewed by Cursor Bugbot for commit b70fb04. Bugbot is set up for automated code reviews on this repo. Configure here.