Repository navigation
chore(example): bump IRL contract_details schema version to 4 - #1522
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
jordividaller
approved these changes
Oct 13, 2026
This was referenced Oct 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The example app now uses Ireland's latest contract details form (v4). Ireland also gets its own schema changelog.
Why
What changed
Toggle details
jsonSchemaVersions.ts: IRLcontract_details1 → 4.schemaVersions.ts: unchanged, because it already lists IRL v1–v4.IRL.mdcovering v2–v4, plus IRL in the README's migration list and version matrix. Each entry is based on tiger'sversion_changelog:salary_overview), jsf v1 engine. Part-time salary below the hourly-derived minimum and a missing annual gross salary are now rejected, so payloads relying on the old behavior can fail validation.Screenshots
N/A
Related Resources
18694d40(v2, reserve messaging),e59481f5(v2 salary minimum enforced under JSF v1),3f240067(v3, extreme salary),8fb85131(v4, seniority block)Testing
example/app in a browsernpm run schema-canary -- --country=IRL --versions=pinned,latestagainst sandbox: build and submit pass on pinned (v4) and latest. The v1 baseline was not run separately.eor_seniority_block,eor_seniority_block_v2_ftc(v4 seniority block); extreme-salary acknowledgement (v3)🤖 Generated with Claude Code
Note
Low Risk
Documentation and example-app schema pin only; no runtime library or API surface changes.
Overview
Aligns the example onboarding app with Ireland’s current contract details schema by pinning IRL from v1 → v4 in
jsonSchemaVersions.ts, so the demo exercises the same form and validations partners see when they upgrade.Adds Ireland-specific migration docs (
IRL.md) and lists IRL v4 in the contract-details country README (link + version matrix). The changelog calls out what upgrades imply: v2 (jsf v1 engine, stricter salary rules, display-only high-salary messaging), v3 (extreme-salary acknowledgement), and v4 (fixed-term blocked when seniority date is recognized, flag-gated). No public API changes—documentation and example configuration only.Reviewed by Cursor Bugbot for commit 3c1cbc3. Bugbot is set up for automated code reviews on this repo. Configure here.