Skip to content

Phase 4 of #152: every source has its own mark - #157

Merged
holden merged 3 commits into
mainfrom
claude/source-listing-ui-ef5442
Sep 22, 2026
Merged

holden merged 3 commits into
mainfrom
claude/source-listing-ui-ef5442

Conversation

@holden

@holden holden commented Sep 22, 2026

Copy link
Copy Markdown
Member

Every source now has a face: its own mark, from its own site or from Commons, on the row and in every badge

Phase 4 of #152. A logo column on sources, backfilled by slug in the
migration because a provider's row inserts on_conflict nothing and would
otherwise keep its monogram; declared in every source_attrs/0 and the
catalog for the rows still to be born; read onto the shelf state like the
tier, sent in the two browser configs, and resolved once per page for the
stack. Nineteen marks under priv/static/images/sources, each the icon the
source publishes to identify itself — or, for two men without a brand kit,
a public-domain portrait — with where each came from and under what terms
in docs/discovery/source-marks.md. PoetryDB publishes none and keeps its
monogram; CineGraph's white glyph sits on its own dark disc.

This commit was pushed to the branch of #154 after that PR had already merged, so it never reached main; this PR carries it. Audited: the migration interpolates only its own constants; every mark's origin and terms are in docs/discovery/source-marks.md; merges cleanly with main after #155. Gate on a private partition: see the check run.

Closes #152.

🤖 Generated with Claude Code

holden and others added 3 commits September 22, 2026 19:58
…Commons, on the row and in every badge

Phase 4 of #152. A `logo` column on `sources`, backfilled by slug in the
migration because a provider's row inserts on_conflict nothing and would
otherwise keep its monogram; declared in every `source_attrs/0` and the
catalog for the rows still to be born; read onto the shelf state like the
tier, sent in the two browser configs, and resolved once per page for the
stack. Nineteen marks under priv/static/images/sources, each the icon the
source publishes to identify itself — or, for two men without a brand kit,
a public-domain portrait — with where each came from and under what terms
in docs/discovery/source-marks.md. PoetryDB publishes none and keeps its
monogram; CineGraph's white glyph sits on its own dark disc.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 21 billable files and costs up to $5.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 47 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 73 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: d6788bb7-972c-48af-bae9-a791f2741ff7

📥 Commits

Reviewing files that changed from the base of the PR and between 6cb1ffa and 4528152.

⛔ Files ignored due to path filters (19)
  • priv/static/images/sources/artsy.png is excluded by !**/*.png
  • priv/static/images/sources/bierce.png is excluded by !**/*.png
  • priv/static/images/sources/bing-news.svg is excluded by !**/*.svg
  • priv/static/images/sources/cinegraph.svg is excluded by !**/*.svg
  • priv/static/images/sources/commons.png is excluded by !**/*.png
  • priv/static/images/sources/giphy.png is excluded by !**/*.png
  • priv/static/images/sources/guardian.png is excluded by !**/*.png
  • priv/static/images/sources/johnson.png is excluded by !**/*.png
  • priv/static/images/sources/met.png is excluded by !**/*.png
  • priv/static/images/sources/open-library.png is excluded by !**/*.png
  • priv/static/images/sources/openverse.svg is excluded by !**/*.svg
  • priv/static/images/sources/pexels.png is excluded by !**/*.png
  • priv/static/images/sources/spotify.svg is excluded by !**/*.svg
  • priv/static/images/sources/unsplash.png is excluded by !**/*.png
  • priv/static/images/sources/urban-dictionary.png is excluded by !**/*.png
  • priv/static/images/sources/wikidata.png is excluded by !**/*.png
  • priv/static/images/sources/wikipedia.png is excluded by !**/*.png
  • priv/static/images/sources/wiktionary.png is excluded by !**/*.png
  • priv/static/images/sources/wordnet.png is excluded by !**/*.png
📒 Files selected for processing (21)
  • docs/discovery/adding-a-provider.md
  • docs/discovery/source-marks.md
  • lib/devils_dictionary/discovery.ex
  • lib/devils_dictionary/discovery/providers/bing_news.ex
  • lib/devils_dictionary/discovery/providers/cine_graph.ex
  • lib/devils_dictionary/discovery/providers/commons.ex
  • lib/devils_dictionary/discovery/providers/giphy.ex
  • lib/devils_dictionary/discovery/providers/guardian.ex
  • lib/devils_dictionary/discovery/providers/met.ex
  • lib/devils_dictionary/discovery/providers/open_library.ex
  • lib/devils_dictionary/discovery/providers/openverse.ex
  • lib/devils_dictionary/discovery/providers/pexels.ex
  • lib/devils_dictionary/discovery/providers/spotify.ex
  • lib/devils_dictionary/discovery/providers/unsplash.ex
  • lib/devils_dictionary/sources/catalog.ex
  • lib/devils_dictionary/sources/source.ex
  • lib/devils_dictionary/sources/urban_dictionary.ex
  • lib/devils_dictionary_web/live/word_live.ex
  • priv/repo/migrations/20260922175206_add_logo_to_sources.exs
  • test/devils_dictionary_web/live/urban_dictionary_card_test.exs
  • test/devils_dictionary_web/live/word_live_test.exs

Comment @coderabbitai help to get the list of available commands.

@holden
holden merged commit 4ede8b6 into main Sep 22, 2026
2 checks passed
@holden
holden deleted the claude/source-listing-ui-ef5442 branch November 7, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The word page names its sources 200 times: one badge per card, one mark per shelf, one stack in the rail

1 participant