Repository navigation
Phase 4 of #152: every source has its own mark - #157
Merged
Merged
Conversation
…Commons, on the row and in every badge Phase 4 of #152. A `logo` column on `sources`, backfilled by slug in the migration because a provider's row inserts on_conflict nothing and would otherwise keep its monogram; declared in every `source_attrs/0` and the catalog for the rows still to be born; read onto the shelf state like the tier, sent in the two browser configs, and resolved once per page for the stack. Nineteen marks under priv/static/images/sources, each the icon the source publishes to identify itself — or, for two men without a brand kit, a public-domain portrait — with where each came from and under what terms in docs/discovery/source-marks.md. PoetryDB publishes none and keeps its monogram; CineGraph's white glyph sits on its own dark disc. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… into claude/source-listing-ui-ef5442
|
Warning Review limit reached
This review includes 21 billable files and costs up to $5.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 47 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 73 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: ⛔ Files ignored due to path filters (19)
📒 Files selected for processing (21)
Comment |
16 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every source now has a face: its own mark, from its own site or from Commons, on the row and in every badge
Phase 4 of #152. A
logocolumn onsources, backfilled by slug in themigration because a provider's row inserts on_conflict nothing and would
otherwise keep its monogram; declared in every
source_attrs/0and thecatalog for the rows still to be born; read onto the shelf state like the
tier, sent in the two browser configs, and resolved once per page for the
stack. Nineteen marks under priv/static/images/sources, each the icon the
source publishes to identify itself — or, for two men without a brand kit,
a public-domain portrait — with where each came from and under what terms
in docs/discovery/source-marks.md. PoetryDB publishes none and keeps its
monogram; CineGraph's white glyph sits on its own dark disc.
This commit was pushed to the branch of #154 after that PR had already merged, so it never reached main; this PR carries it. Audited: the migration interpolates only its own constants; every mark's origin and terms are in
docs/discovery/source-marks.md; merges cleanly with main after #155. Gate on a private partition: see the check run.Closes #152.
🤖 Generated with Claude Code