Repository navigation
A card's link back keeps its licence's wording when the mark is on the shelf - #155
Conversation
…he mark's image goes #152 moved Spotify's mark from the card to the shelf, and `card_mark/1` handed a card only a `:card`-placed mark — so every Music card's link-out fell through to the generic *Open at Spotify*, which is not one of the three phrases Spotify's Branding Guidelines permit, while the PR said *Listen on Spotify* stayed. Measured on `/define/war` after the merge: twelve cards, zero with the phrase. A mark carries two obligations. Its image has a placement; the wording of the link back is per item whatever that placement is. The card now reads the supplying source's mark whether it is drawn on the card or on the shelf, draws the image only for `:card`, and words the link — and its hover title — from `link_text` when the mark has one. Two tests render a shelf-placed and a card-placed mark and count the phrase on every card. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe change separates attribution-mark selection from card rendering. Shelf marks remain available for source links without rendering on cards. Source-link titles use custom mark text when present. Tests cover shelf and card placements. ChangesAttribution Mark Rendering
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The attribution wording and placement behavior are covered for both supported mark placements, with no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
After #154 every Spotify card read Open at Spotify instead of Listen on Spotify: the card only read a
:card-placed mark, and Spotify's moved to the shelf. The wording of the link back is per item wherever the image goes, so the card now reads the supplying source's mark regardless of placement, draws the image only for:card, and words the link and its hover title fromlink_text. Two chrome tests pin it for both placements. Refs #152.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes