Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Update crate names and rand deps - #9762

Merged
1 commit merged into
masterfrom
wk-update-crate-names
Sep 13, 2021
Merged

1 commit merged into
masterfrom
wk-update-crate-names

Conversation

@chevdor

@chevdor chevdor commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

This PR updates the names crate that was depedending on a very old version of rand.

@chevdor chevdor added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. A0-please_review Pull request needs code review. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit and removed A0-please_review Pull request needs code review. labels Sep 13, 2021

@bkchr bkchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty much better

@bkchr

bkchr commented Sep 13, 2021

Copy link
Copy Markdown
Member

bot merge

@ghost

ghost commented Sep 13, 2021

Copy link
Copy Markdown

Trying merge.

@ghost

ghost commented Sep 13, 2021

Copy link
Copy Markdown

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

@ghost
ghost merged commit e232df1 into master Sep 13, 2021
@ghost
ghost deleted the wk-update-crate-names branch September 13, 2021 08:52
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants