Skip to content

feat(api): add external storage and safety case commands - #229

Merged
marcuswood-oai merged 1 commit into
mainfrom
castiron/promotions/pr-98
Sep 22, 2026
Merged

feat(api): add external storage and safety case commands#229
marcuswood-oai merged 1 commit into
mainfrom
castiron/promotions/pr-98

Conversation

@marcuswood-oai

@marcuswood-oai marcuswood-oai commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds commands for external storage configuration management and safety case retrieval. Model flags continue to accept string values.

Changes

  • Add external storage create, retrieve, list, delete, and validate commands.
  • Add safety case retrieval.
  • Keep model flags as unrestricted strings.

@marcuswood-oai
feat(api): add external storage and safety case commands
57cd06b 
Castiron-Internal-PR: openai/openai-cli-internal#98
Castiron-Source-SHA: 4a4022d20ef616f11eebec4dcfdbb0bca6127ed4
Castiron-Public-Base-SHA: 0713595
@github-actions

github-actions Bot commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Castiron custom code

✅ No new custom-code files detected.

5 mixed files remain; 0 existing customizations changed.

Compared 07135953b246 → 57cd06b8b41d. Generated baselines verified.

5 existing customizations unchanged
  • pkg/cmd/adminorganizationcertificate.go
  • pkg/cmd/image.go
  • scripts/castiron/README.md
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_report.py

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 35676314141 --repo openai/openai-cli \
  --name castiron-custom-code-35676314141-1 --dir /tmp/castiron-custom-code-35676314141-1
git apply --stat /tmp/castiron-custom-code-35676314141-1/custom-code.patch
cat /tmp/castiron-custom-code-35676314141-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 07135953b2464dbae26b8e9548e24dacc070e6ba 57cd06b8b41d908e0e464e34af2713a29ea69cac
python3 scripts/castiron/custom_code_report.py report \
  --base 07135953b2464dbae26b8e9548e24dacc070e6ba \
  --head 57cd06b8b41d908e0e464e34af2713a29ea69cac --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-57cd06b8b41d
cat /tmp/castiron-custom-code-57cd06b8b41d/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@marcuswood-oai
marcuswood-oai marked this pull request as ready for review September 22, 2026 01:34
@marcuswood-oai
marcuswood-oai requested a review from a team as a code owner September 22, 2026 01:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-22T01:37:01.093499Z 57cd06b Draft marked ready
🔒 Security Review ✅ Completed 2026-09-22T01:37:56.469493Z 57cd06b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

jbeckwith-oai
jbeckwith-oai approved these changes Sep 22, 2026
View reviewed changes

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the exact head 57cd06b. External-storage and safety-case commands map to the published paths and authentication/request conventions, model flags remain unrestricted strings, and exact-head CI/Castiron validation are green.

@marcuswood-oai
marcuswood-oai added this pull request to the merge queue Sep 22, 2026
Merged via the queue into main with commit c30c961 Sep 22, 2026
16 checks passed
@marcuswood-oai
marcuswood-oai deleted the castiron/promotions/pr-98 branch September 22, 2026 01:46
@openai-sdks openai-sdks Bot mentioned this pull request Sep 22, 2026
Merged
@jbeckwith-oai jbeckwith-oai mentioned this pull request Sep 22, 2026
Merged
feiiiiii5 pushed a commit to feiiiiii5/openai-cli that referenced this pull request Sep 22, 2026
@jbeckwith-oai
test: cover external storage CLI contracts (openai#228)
cfe77c0 
## Summary

Adds regression coverage for the external-storage commands already
available on `main` through openai#229. This PR is now test-only; it does not
add or change commands, documentation, dependencies, or API behavior.

## Coverage

- AWS JSON and Azure YAML provider input through the compiled CLI.
- Admin authentication with no project-key fallback.
- Escaped IDs, bodyless operations, pagination and filters.
- Raw response preservation and rejection of malformed or missing
arguments before a request.

All fixtures use synthetic credentials and local HTTP servers. Current
`main`'s command implementations, newer DELETE guidance, safety-case
registration, and generation provenance are preserved unchanged.

## Validation

- Contract suite with race detection, repeated three times.
- Race-enabled internal tests, all-package compilation, build/lint, vet
and module integrity.
- Windows test cross-compilation and direct code/security review.

<!-- codex-thread: 01a06e98-2b11-72b0-82ee-2b563bc5d164 -->
Tmwakalasya pushed a commit to Tmwakalasya/openai-cli that referenced this pull request Sep 22, 2026
@openai-sdks @saioai
release: 1.16.0 (openai#188)
e7095dc 
Automated Release PR
---


##
[1.16.0](openai/openai-cli@v1.15.0...v1.16.0)
(2026-09-22)


### Features

* **api:** add external storage and safety case commands
([openai#229](openai#229))
([c30c961](openai@c30c961))
* **api:** add prompt-cache prewarming
([openai#196](openai#196))
([9032f58](openai@9032f58))
* **api:** add response transformation hooks
([openai#223](openai#223))
([8de34a7](openai@8de34a7))
* **api:** add webhook endpoint management
([openai#201](openai#201))
([dea465a](openai@dea465a))
* **cli:** support custom request headers
([openai#190](openai#190))
([07e3ed9](openai@07e3ed9))


### Bug Fixes

* **apiform:** preserve float32 precision in comma arrays
([openai#78](openai#78))
([774612f](openai@774612f))
* **apiform:** strip path components from upload filenames
([openai#120](openai#120))
([a92e143](openai@a92e143))
* **apiform:** support primitive pointers in comma arrays
([openai#119](openai#119))
([9d146cd](openai@9d146cd))
* **apiquery:** preserve narrow numeric parameters
([openai#76](openai#76))
([b152780](openai@b152780))
* **apiquery:** reject complex elements in comma arrays
([openai#118](openai#118))
([46faf2c](openai@46faf2c))
* **apiquery:** reject non-string map keys
([openai#88](openai#88))
([687a097](openai@687a097))
* **autocomplete:** omit hidden flags from suggestions
([openai#122](openai#122))
([137d59b](openai@137d59b))
* **cmd:** include backslash in path detection for @ file references
([openai#38](openai#38))
([f984eb1](openai@f984eb1))
* **debug:** redact sensitive response headers
([openai#32](openai#32))
([ee62f85](openai@ee62f85))
* **explore:** avoid panic when printing an empty result set
([openai#68](openai#68))
([f74838c](openai@f74838c))
* install Linux package binaries under /usr/bin
([openai#34](openai#34))
([ac4e7cb](openai@ac4e7cb))
* **jsonview:** avoid width underflow in static string rendering
([openai#117](openai#117))
([cbdf265](openai@cbdf265))
* **jsonview:** preserve literal object keys in pretty output and
explorer ([openai#143](openai#143))
([25664bf](openai@25664bf))
* omit redirect destinations from multipart upload errors
([openai#189](openai#189))
([642d511](openai@642d511))
* **output:** stop pagination at max items
([openai#43](openai#43))
([552840e](openai@552840e))
* **requestflag:** preserve JSON numbers written in exponent form
([openai#195](openai#195))
([20db45e](openai@20db45e))


### Chores

* **api:** clarify Live SIP call help
([openai#193](openai#193))
([79435c4](openai@79435c4))
* **api:** document MCP connector deprecation
([openai#202](openai#202))
([1d4e76c](openai@1d4e76c))
* **api:** update image request examples
([openai#197](openai#197))
([4b75e9b](openai@4b75e9b))
* **deps:** bump the codeql group across 1 directory with 2 updates
([openai#161](openai#161))
([97734f3](openai@97734f3))
* **deps:** bump the codeql group across 1 directory with 2 updates
([openai#224](openai#224))
([0713595](openai@0713595))
* **deps:** bump the go-minor-and-patch group across 1 directory with 2
updates ([openai#144](openai#144))
([aa1158d](openai@aa1158d))
* **deps:** update openai-go to v3.61.0
([openai#184](openai#184))
([de52b2e](openai@de52b2e))
* **deps:** update openai-go to v3.63.0
([openai#198](openai#198))
([3f2c883](openai@3f2c883))
* **deps:** update openai-go to v3.63.1
([openai#204](openai#204))
([eb415e5](openai@eb415e5))
* **deps:** update openai-go to v3.64.0
([openai#206](openai#206))
([0169bff](openai@0169bff))
* **deps:** update openai-go to v3.64.2
([openai#225](openai#225))
([a7859e5](openai@a7859e5))


### Documentation

* correct bootstrap dependency check description
([openai#181](openai#181))
([4aa657c](openai@4aa657c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
Co-authored-by: saioai <vguvvala@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbeckwith-oai jbeckwith-oai jbeckwith-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcuswood-oai @jbeckwith-oai