fix(apiform): support primitive pointers in comma arrays

[sylvesterkaczmarek]

Summary

Dereference non-nil pointer/interface elements when encoding multipart arrays with FormatComma, while preserving the existing empty-string representation for nil elements.

Problem

internal/apiform.encodeArray already special-cases nil pointer/interface elements in comma-form arrays, but non-nil pointers are never dereferenced before the primitive-type switch.

As a result, a valid primitive array such as:

[]*string{&first, nil, &second}

fails with:

comma format not supported for complex array elements

even though the pointed-to values are ordinary strings and the same encoder supports primitive values directly.

Fix

Unwrap pointer and interface layers before primitive comma serialization. If a nil value is encountered at any layer, keep the existing behavior of adding an empty comma element.

Complex non-primitive elements continue to return the same error as before.

Regression coverage

Added a focused multipart regression for []*string{&first, nil, &second} and verify it serializes as:

alpha,,beta

Validation

The branch is based directly on current upstream main (ee92673a416c0851a5fe8907a2453db7bd450633) and contains one commit touching only internal/apiform/encoder.go plus focused regression coverage. Full Go test execution is left to repository CI.

Risk

Low. The change only affects pointer/interface elements inside FormatComma arrays. Direct primitives, nil elements, complex-element rejection, and all other multipart array formats retain their existing behavior.

[markstuart-oai]

@codex review

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-15T06:43:19.825232Z	4ab802f	New commits
🔒 Security Review	✅ Completed 2026-09-15T06:44:20.565969Z	4ab802f	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cfc696f92e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Preserve float32 precision after pointer unwrapping

When a comma-form array contains a non-nil *float32, this new unwrapping path reaches the existing combined float case, which calls strconv.FormatFloat with a 64-bit size. Consequently, a value such as float32(1.2) is sent as 1.2000000476837158 rather than 1.2, unlike the scalar encoder's dedicated Float32 handling. Distinguish reflect.Float32 from reflect.Float64 when serializing these newly supported pointer elements.

Useful? React with 👍 / 👎.

[sylvesterkaczmarek]

Fixed in 877e5ff. Pointer-unwrapped float32 values now use 32-bit formatting, with a regression for float32(1.2) producing 1.2. Focused apiform tests pass.

[chatgpt-codex-connector]

Security review completed. No security issues were found in this pull request.

Reviewed commit: cfc696f92e

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

• You comment "@codex security review"
• A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

[github-actions]

Castiron custom code

✅ No new custom-code files detected.

5 mixed files remain; 0 existing customizations changed.

Compared ac4e7cb16c92 → 4ab802fcc66e. Generated baselines verified.

5 existing customizations unchanged

• pkg/cmd/adminorganizationcertificate.go
• pkg/cmd/cmd.go
• scripts/castiron/README.md
• scripts/castiron/custom_code_report.py
• scripts/castiron/test_custom_code_report.py

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 34938109832 --repo openai/openai-cli \
  --name castiron-custom-code-34938109832-1 --dir /tmp/castiron-custom-code-34938109832-1
git apply --stat /tmp/castiron-custom-code-34938109832-1/custom-code.patch
cat /tmp/castiron-custom-code-34938109832-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin ac4e7cb16c9271b712c2cde5f64a0904c8815c4e 4ab802fcc66e36ebea577c0567896031e524568a
python3 scripts/castiron/custom_code_report.py report \
  --base ac4e7cb16c9271b712c2cde5f64a0904c8815c4e \
  --head 4ab802fcc66e36ebea577c0567896031e524568a --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-4ab802fcc66e
cat /tmp/castiron-custom-code-4ab802fcc66e/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

[saioai]

i checked the updated branch at 4ab802f. the pointer cases fail on main and pass here, and #78’s direct float32 case passes against this code too. i ran the apiform race tests 10 times, plus the internal tests, compilation, vet, and module checks. those passed locally, and github’s checks are green too. looks good to me.