Skip to content

feat(api): add response transformation hooks - #223

Merged
saioai merged 1 commit into
mainfrom
castiron/promotions/pr-95
Sep 21, 2026
Merged

saioai merged 1 commit into
mainfrom
castiron/promotions/pr-95

Conversation

@HAYDEN-OAI

Copy link
Copy Markdown
Contributor

Summary

Adds response transformation hooks while preserving existing command output and request behavior.

Changes

  • Expose operation, response-kind, and cancellation context to response transformations.
  • Preserve explicit output formats, JSON transforms, pagination, and streaming behavior.

Castiron-Internal-PR: openai/openai-cli-internal#95
Castiron-Source-SHA: 2bc48244f7fdb6d215ef5c9f53bff6fb937f1d57
Castiron-Public-Base-SHA: 0169bff
@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Castiron custom code

Mixed files: 5 → 5

1 newly customized · 1 customizations removed · 0 existing customizations changed · 3 generated baselines changed

Compared 0169bff050ff → 75842b61b626. Generated baselines verified.

File Result Current custom patch
pkg/cmd/adminorganizationcertificate.go Generated baseline changed +5 / −0
pkg/cmd/cmd.go Generated baseline changed None
pkg/cmd/image.go Generated baseline changed +1 / −1
3 existing customizations unchanged
  • scripts/castiron/README.md
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_report.py

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 35628439148 --repo openai/openai-cli \
  --name castiron-custom-code-35628439148-1 --dir /tmp/castiron-custom-code-35628439148-1
git apply --stat /tmp/castiron-custom-code-35628439148-1/custom-code.patch
cat /tmp/castiron-custom-code-35628439148-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 0169bff050ff9c05c4609b669c06709306d464fa 75842b61b6269bb13e0e06cc511abf64895b6fe3
python3 scripts/castiron/custom_code_report.py report \
  --base 0169bff050ff9c05c4609b669c06709306d464fa \
  --head 75842b61b6269bb13e0e06cc511abf64895b6fe3 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-75842b61b626
cat /tmp/castiron-custom-code-75842b61b626/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@HAYDEN-OAI
HAYDEN-OAI marked this pull request as ready for review September 21, 2026 16:52
@HAYDEN-OAI
HAYDEN-OAI requested a review from a team as a code owner September 21, 2026 16:52
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-21T16:55:40.333264Z 75842b6 Draft marked ready
🔒 Security Review ✅ Completed 2026-09-21T16:55:16.105150Z 75842b6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 75842b6. The runtime move establishes a coherent one-way ownership boundary, preserves the generated command bridge and existing request behavior, and centralizes lazy response transformation across direct output, the pager and the explorer. The identity selector preserves current output; explicit presentation choices bypass default transformations. No actionable correctness or structural findings.

Validation: inspected all changed paths, rename equivalence, relocated tests, root/mTLS initialization, iterator error and cancellation handling, and passing exact-head hosted test/lint/build/CodeQL and baseline checks. No repository tests, generation or rollback were independently executed. Coordinated activation requirements remain as documented.

@saioai saioai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follows the new architecture the cli is targeting

@saioai
saioai added this pull request to the merge queue Sep 21, 2026
Merged via the queue into main with commit 8de34a7 Sep 21, 2026
16 checks passed
@saioai
saioai deleted the castiron/promotions/pr-95 branch September 21, 2026 18:42
@openai-sdks openai-sdks Bot mentioned this pull request Sep 21, 2026
Tmwakalasya pushed a commit to Tmwakalasya/openai-cli that referenced this pull request Sep 22, 2026
Automated Release PR
---


##
[1.16.0](openai/openai-cli@v1.15.0...v1.16.0)
(2026-09-22)


### Features

* **api:** add external storage and safety case commands
([openai#229](openai#229))
([c30c961](openai@c30c961))
* **api:** add prompt-cache prewarming
([openai#196](openai#196))
([9032f58](openai@9032f58))
* **api:** add response transformation hooks
([openai#223](openai#223))
([8de34a7](openai@8de34a7))
* **api:** add webhook endpoint management
([openai#201](openai#201))
([dea465a](openai@dea465a))
* **cli:** support custom request headers
([openai#190](openai#190))
([07e3ed9](openai@07e3ed9))


### Bug Fixes

* **apiform:** preserve float32 precision in comma arrays
([openai#78](openai#78))
([774612f](openai@774612f))
* **apiform:** strip path components from upload filenames
([openai#120](openai#120))
([a92e143](openai@a92e143))
* **apiform:** support primitive pointers in comma arrays
([openai#119](openai#119))
([9d146cd](openai@9d146cd))
* **apiquery:** preserve narrow numeric parameters
([openai#76](openai#76))
([b152780](openai@b152780))
* **apiquery:** reject complex elements in comma arrays
([openai#118](openai#118))
([46faf2c](openai@46faf2c))
* **apiquery:** reject non-string map keys
([openai#88](openai#88))
([687a097](openai@687a097))
* **autocomplete:** omit hidden flags from suggestions
([openai#122](openai#122))
([137d59b](openai@137d59b))
* **cmd:** include backslash in path detection for @ file references
([openai#38](openai#38))
([f984eb1](openai@f984eb1))
* **debug:** redact sensitive response headers
([openai#32](openai#32))
([ee62f85](openai@ee62f85))
* **explore:** avoid panic when printing an empty result set
([openai#68](openai#68))
([f74838c](openai@f74838c))
* install Linux package binaries under /usr/bin
([openai#34](openai#34))
([ac4e7cb](openai@ac4e7cb))
* **jsonview:** avoid width underflow in static string rendering
([openai#117](openai#117))
([cbdf265](openai@cbdf265))
* **jsonview:** preserve literal object keys in pretty output and
explorer ([openai#143](openai#143))
([25664bf](openai@25664bf))
* omit redirect destinations from multipart upload errors
([openai#189](openai#189))
([642d511](openai@642d511))
* **output:** stop pagination at max items
([openai#43](openai#43))
([552840e](openai@552840e))
* **requestflag:** preserve JSON numbers written in exponent form
([openai#195](openai#195))
([20db45e](openai@20db45e))


### Chores

* **api:** clarify Live SIP call help
([openai#193](openai#193))
([79435c4](openai@79435c4))
* **api:** document MCP connector deprecation
([openai#202](openai#202))
([1d4e76c](openai@1d4e76c))
* **api:** update image request examples
([openai#197](openai#197))
([4b75e9b](openai@4b75e9b))
* **deps:** bump the codeql group across 1 directory with 2 updates
([openai#161](openai#161))
([97734f3](openai@97734f3))
* **deps:** bump the codeql group across 1 directory with 2 updates
([openai#224](openai#224))
([0713595](openai@0713595))
* **deps:** bump the go-minor-and-patch group across 1 directory with 2
updates ([openai#144](openai#144))
([aa1158d](openai@aa1158d))
* **deps:** update openai-go to v3.61.0
([openai#184](openai#184))
([de52b2e](openai@de52b2e))
* **deps:** update openai-go to v3.63.0
([openai#198](openai#198))
([3f2c883](openai@3f2c883))
* **deps:** update openai-go to v3.63.1
([openai#204](openai#204))
([eb415e5](openai@eb415e5))
* **deps:** update openai-go to v3.64.0
([openai#206](openai#206))
([0169bff](openai@0169bff))
* **deps:** update openai-go to v3.64.2
([openai#225](openai#225))
([a7859e5](openai@a7859e5))


### Documentation

* correct bootstrap dependency check description
([openai#181](openai#181))
([4aa657c](openai@4aa657c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
Co-authored-by: saioai <vguvvala@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants