Skip to content

chore(searchIndex): remove unused ReindexingMetrics methods #35392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
detail-app wants to merge 1 commit into from
Closed

chore(searchIndex): remove unused ReindexingMetrics methods #35392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions ...ce/src/main/java/org/openmetadata/service/apps/bundles/searchIndex/ReindexingMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,12 +276,6 @@ public void decrementPendingBulkRequests() {
pendingBulkRequests.decrementAndGet();
}

// --- Backpressure ---

public void recordBackpressureEvent() {
backpressureEvents.increment();
}

// --- Promotion metrics (dynamic tags) ---

public void recordPromotionSuccess(String entityType) {
Expand Down Expand Up @@ -323,16 +317,4 @@ public void recordCircuitBreakerTrip(String transition) {
.register(meterRegistry))
.increment();
}

// --- Vector timeouts ---

public void recordVectorTimeout(int pendingCount) {
vectorTimeouts.increment();
}

// --- Queue fill ratio ---

public void updateQueueFillRatio(int percent) {
queueFillRatio.set(percent);
}
}
16 changes: 0 additions & 16 deletions ...rc/test/java/org/openmetadata/service/apps/bundles/searchIndex/ReindexingMetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,22 +339,6 @@ void testPendingBulkRequests() {
}
}

@Nested
@DisplayName("Backpressure")
class BackpressureTests {

@Test
@DisplayName("recordBackpressureEvent increments counter")
void testRecordBackpressureEvent() {
ReindexingMetrics metrics = ReindexingMetrics.getInstance();
metrics.recordBackpressureEvent();
metrics.recordBackpressureEvent();
metrics.recordBackpressureEvent();

assertEquals(3, getCounterValue("reindexing.backpressure.events"));
}
}

@Nested
@DisplayName("Promotion Metrics")
class PromotionTests {
Expand Down
Loading