Repository navigation
chore(searchIndex): remove unused ReindexingMetrics methods - #35392
Closed
detail-app[bot] wants to merge 1 commit into
Closed
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
Contributor
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
detail-app
Bot
added
the
safe to test
mohityadav766
approved these changes
Oct 15, 2026
4 tasks done
Contributor
|
Superseded by #35537, which combines this change with other queued fixes. |
github-merge-queue
Bot
removed this pull request from the merge queue due to a manual request
Oct 15, 2026
Contributor
🚦 Removed from the merge queue —
|
timothybrush
pushed a commit
to timothybrush/OpenMetadata
that referenced
this pull request
Oct 16, 2026
…, SAML tenant GUIDs, dead-code removals (open-metadata#35537) * Fixes open-metadata#35106: gate certification tag strip on supportsCertification in BundleWarmupBatcher (open-metadata#35167) * chore(searchIndex): remove unused ReindexingMetrics methods (open-metadata#35392) * chore: remove unused TeamsMessage Fact/Action model classes (open-metadata#35386) * chore: remove unused awaitVectorCompletionWithDetails and VectorCompletionResult (open-metadata#35389) * Fixes open-metadata#35078: authorize VIEW_BASIC on lineage edge-details read endpoints (open-metadata#35140) * Fixes open-metadata#34464: Accept upper/mixed-case Azure AD tenant GUIDs in SAML validation (open-metadata#34522) --------- Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com>
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove three public methods from
ReindexingMetricsthat have no productioncallers, plus the
BackpressureTestsnested class that covered one of them.recordBackpressureEvent()— its only caller lived inSearchIndexExecutor,which was deleted in Make SearchIndexing distributed-only #27971 ("Make SearchIndexing distributed-only").
recordVectorTimeout(int pendingCount)— its only caller was inOpenSearchBulkSinkand was removed in a later commit; the parameter wasignored by the body. No callers remained anywhere (not even tests).
updateQueueFillRatio(int percent)— its only caller lived inSearchIndexExecutor, deleted in Make SearchIndexing distributed-only #27971. No callers remained anywhere.The backing meter registrations (
reindexing.backpressure.events,reindexing.vector.timeouts,reindexing.queue.fill_ratio) are intentionallykept: they are observability outputs analogous to logging/debug tooling with
potential external consumers (dashboards/alerts), and write-only/read-only
variables are treated as living code.
History
Describe your changes:
N/A — small dead-code cleanup, no linked issue.
Type of change:
High-level design:
N/A — small change. Removed three uncalled public methods and their orphaned
test; nothing else wired to them.
Tests:
Use cases covered
ReindexingMetricsTestcontinues to cover initialization, joblifecycle, stage counters, bulk request metrics, payload size, pending
bulk requests, and promotion metrics.
Unit tests
BackpressureTests(tested the removedrecordBackpressureEvent).mvn test -pl openmetadata-service -Dtest=ReindexingMetricsTest→ 23/23 passing.
mvn spotless:check -pl openmetadata-servicepasses.Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording:
Not applicable — backend dead-code removal, no UI impact.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.docs/decisions/(see itsREADME.md). This description is gone from git log after the squash-merge.Dead Code PRs can be configured here.