Repository navigation
fix(vercel): mark header-only route entries as continue - #4652
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughChangesVercel header-only routes now omit Vercel route continuation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The PR is mergeable with no concrete unresolved risk identified in the reviewed scope. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Emit header-only routes least specific first so the more specific rule overrides, matching runtime route rule merging.
prevents less specific redirect rules from matching via `continue`
|
On top of the first commit: 1e42875 orders header-only routes from least to most specific so the more specific rule wins under Written with AI assistance. |
🔗 Linked issue
❓ Type of change
📚 Description
port of #4651 to main
currently setting a headers route rule means we clobber any other rules, e.g. caching rules, and always fall to a function
discovered while debugging an issue with @larbish and @atinux
📝 Checklist